Refactor: Update billing error messages in locale for consistency and clarity

app/controllers/qbo_controller.rb

@@ -33,13 +33,14 @@ class QboController < ApplicationController
   # Manual billing endpoint to trigger the billing process for a specific issue. Validates the issue and its associations, enqueues a job to bill the issue's time entries, and redirects back to the issue with a notice. If validation fails, redirects back with an error message.
   def bill
     issue = Issue.find_by(id: params[:id])
-    BillingValidator.validate!(issue)
+    raise I18n.t(:notice_error_issue_not_found) unless issue
+    raise I18n.t(:notice_billing_error_no_customer) unless issue.customer
+    raise I18n.t(:notice_billing_error_no_employee) unless issue.assigned_to&.employee_id.present?
+    raise I18n.t(:notice_billing_error_no_qbo) unless Qbo.exists?
 
     BillIssueTimeJob.perform_later(issue.id)
 
-    redirect_to issue, flash: {
-      notice: "#{I18n.t(:label_billing_enqueued)} #{issue.customer.name}"
-    }
+    redirect_to issue, flash: { notice: "#{I18n.t(:label_billing_enqueued)} #{issue.customer.name}"}
 
   rescue StandardError => e
     redirect_to issue || root_path, flash: { error: e.message }

app/services/billing_validator.rb

@@ -1,21 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-
-class BillingValidator
-
-  # Validates that the given issue is eligible for billing by checking for the presence of the issue, its associated customer, assigned employee, and an active QBO connection. Raises descriptive errors if any of these conditions are not met.
-  def self.validate!(issue)
-    raise "Issue not found" unless issue
-    raise I18n.t(:label_billing_error_no_customer) unless issue.customer
-    raise I18n.t(:label_billing_error_no_employee) unless issue.assigned_to&.employee_id.present?
-    raise I18n.t(:label_billing_error_no_qbo) unless Qbo.exists?
-  end
-end

app/services/qbo_webhook_verifier_service.rb

@@ -1,24 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class QboWebhookVerifierService
-
-  # Validates the QuickBooks webhook request by computing the HMAC signature and comparing it to the provided signature.
-  def self.valid?(body:, signature:, secret:)
-    return false if signature.blank? || secret.blank?
-
-    digest = OpenSSL::Digest.new('sha256')
-    computed = Base64.strict_encode64(
-      OpenSSL::HMAC.digest(digest, secret, body)
-    )
-
-    ActiveSupport::SecurityUtils.secure_compare(computed, signature)
-  end
-end

config/locales/en.yml

@@ -27,10 +27,6 @@ en:
   label_balance_with_jobs: "Balance With Jobs"
   label_bill_time: "Bill Time"
   label_billing_address: "Billing Address"
-  label_billing_error: "Customer could not be billed. Check for Customer or Assignee and try again."
-  label_billing_error_no_customer: "Cannot bill without an assigned customer."
-  label_billing_error_no_employee: "Cannot bill without an assigned employee."
-  label_billing_error_no_qbo: "Cannot bill without a QuickBooks connection. Please connect to QuickBooks and try again."
   label_billing_enqueued: "Billing has been enqueued for issue"
   label_billed_success: "Successfully billed "
   label_client_id: "Intuit QBO OAuth2 Client ID"
@@ -91,11 +87,15 @@ en:
   label_webhook_token: "Intuit QBO Webhook Token"
   label_week: "Week"
   label_year: "Year"
+  notice_billing_error_no_customer: "Cannot bill without an assigned customer."
+  notice_billing_error_no_employee: "Cannot bill without an assigned employee."
+  notice_billing_error_no_qbo: "Cannot bill without a QuickBooks connection. Please connect to QuickBooks and try again."
   notice_customer_created: "Customer created in QuickBooks"
   notice_customer_deleted: "Customer deleted in QuickBooks"
   notice_customer_not_deleted: "Customer could not be deleted in QuickBooks"
   notice_customer_not_found: "Customer not found in QuickBooks"
   notice_customer_updated: "Customer updated in QuickBooks"
+  notice_error_issue_not_found: "The issue could not be found. Please check the issue and try again."
   notice_error_project_nil: "The issue's project is nil. Set project to:"
   notice_error_tracker_nil: "The issue's tracker is nil. Set tracker to:"
   notice_estimate_created: "Estimate created in QuickBooks"