render partial on footer

Branding: Changed "Quickbooks" to QuickBooks (capitalized B) to match official branding.

Grammar:

warn_ru_sure: Changed "You sure?" to "Are you sure?"

label_no_customers: Refined to "There are no customers matching the search term(s)."

label_billing_error: Added punctuation and clarified the phrasing.

Cleanup: Removed unnecessary spaces inside quotes (e.g., " Make" and "Matching ").

app/controllers/qbo_controller.rb

@@ -64,11 +64,16 @@ class QboController < ApplicationController
   def bill
     i = Issue.find_by_id params[:id]
     if i.customer
-      i.bill_time
-      redirect_to i, flash: { notice: I18n.t(:label_billed_success) + i.customer.name }
+      billed = i.bill_time
+
+      if i.bill_time
+        redirect_to i, flash: { notice: I18n.t( :label_billed_success ) + i.customer.name }
       else
         redirect_to i, flash: { error: I18n.t(:label_billing_error) }
       end
+    else
+      redirect_to i, flash: { error: I18n.t(:label_billing_error_no_customer) }
+    end
   end
   
   # Quickbooks Webhook Callback

app/views/customers/_actions.html.erb

@@ -1,9 +1,9 @@
-<%= link_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to t(:customer_details), "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank %>
+<%= link_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to t(:customer_details), "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}%3Cbr/%3E+&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank, id: :appointment_link %>
 
 <br/>
 <br/>
 
-<%= button_to t(:label_create_estimate), "https://qbo.intuit.com/app/estimate?nameId=#{@customer.id}", target: :_blank, method: :get %>
+<%= link_to t(:label_create_estimate), "https://qbo.intuit.com/app/estimate?nameId=#{@customer.id}", target: :_blank %>
 
 <br/>
 <br/>

app/views/estimates/_list.html.erb

@@ -2,6 +2,7 @@
 
   <% estimates.sort.reverse.each do |estimate| %>
     <div class="row">
+      <%= check_box_tag "estimate_ids[]", estimate.id, false,  onchange: "updateLink()",  data: { url: estimate_path(estimate), text: "Estimate ##{estimate.to_s}" }, class: "estimate-checkbox appointment" %>
       <b><%= link_to "##{estimate.doc_number}", estimate_path(estimate), target: :_blank %></b> <%= estimate.txn_date %>
     </div>
   <% end %>

app/views/invoices/_list.html.erb

@@ -12,7 +12,7 @@
 
     <% invoices.sort.reverse.each do |invoice| %>
       <div class="row">
-        <%= check_box_tag "invoice_ids[]", invoice.id, false, class: "invoice-checkbox" if invoices.count > 1 %>
+        <%= check_box_tag "invoice_ids[]", invoice.id, false,  onchange: "updateLink()", data: { url: invoice_path(invoice), text: "Invoice ##{invoice.to_s}" }, class: "invoice-checkbox appointment" if invoices.count > 1 %>
         <b><%= link_to "##{invoice.doc_number}", invoice_path(invoice), target: :_blank %></b> <%= invoice.txn_date %>
       </div>
     <% end %>

app/views/qbo/_footer.html.erb

@@ -1,3 +1,3 @@
-"<div id='footer' align='center'>
-    <b><%=I18n.translate(:label_last_sync)%>: </b> <%=Qbo.last_sync if Qbo.exists?%>
-</div>"
+<div id='footer' align='center'>
+     <%= render partial: 'qbo/last_sync' %>
+</div>

assets/javascripts/application.js

@@ -1,11 +1,20 @@
-$(function() {
-  $("input#issue_customer_id").on("change", function() {
+function updateLink() {
+  console.log("updateLink called");
+  const linkElement = document.getElementById("appointment_link");
+  const regex = /((?:<br\/>|%3Cbr\/?%3E))([\s\S]*?)(&dates)/gi;
+  linkElement.href = linkElement.href.replace(regex, `$1${getSelectedDocs()}$3`);
+}
 
-    $.ajax({
-      url: "/filter_estimates_by_customer",
-      type: "GET",
-      data: { selected_customer: $("input#issue_customer_id").val() }
-    });
-  });
+function getSelectedDocs() {
+  const appointent_extras = document.querySelectorAll('.appointment');
 
-});
+  let output = '';
+  for (const item of appointent_extras) {
+    if (item.checked) {
+      console.log(`Checked item: ${item.dataset.text} with URL: ${item.dataset.url}`);
+      output += `%0A`+ encodeURIComponent(`<a href="${window.location.origin}${item.dataset.url}">${item.dataset.text}</a>`) +`%0A`;
+    }
+  }
+  
+  return output;
+}

config/locales/en.yml

@@ -11,92 +11,95 @@
 # English strings go here for Rails i18n
 # Usage I18n.t(:label)
 en:
-  field_customer: "Customer"
-  field_employee: "Employee"
-  field_invoice: "Invoice"
-  field_estimate: "Estimate" 
-  field_notes: "Notes"
+  button_bulk_pdf: "Bulk PDF"
+  customer_details: "Customer Details"
   field_billed: "Billed"
-  label_week: "Week"
-  label_search_estimates: "Search Estimates"
-  label_search: "Search"
-  label_estimates: "Estimates"
-  warn_ru_sure: "You sure?"
-  label_delete: "Delete"
-  label_edit: "Edit"
-  label_year: "Year"
-  label_make: " Make"
-  label_model: "Model"
-  label_no_customers: "There are no customers containing the term(s)"
-  label_matching: "Matching "
-  label_open_issues: "Open Issues"
-  label_closed_issues: "Closed Issues"
-  label_sync: "Sync"
-  label_new_customer: "New Customer"
-  label_search_customers: "Search Customers"
-  label_customers: "Customers"
-  label_edit_customer: "Edit Customer"
-  label_email: "Email"
-  label_primary_phone: "Primary Phone"
-  label_mobile_phone: "Mobile Phone"
-  label_billing_address: "Billing Address"
-  label_shipping_address: "Shipping Address"
+  field_customer: "Customer"
+  field_customers: "Customers"
+  field_employee: "Employee"
+  field_estimate: "Estimate"
+  field_invoice: "Invoice"
+  field_notes: "Notes"
   label_account_balance: "Account Balance"
-  label_balance_with_jobs: "Balance With Jobs"
-  label_display_name: "Display Name"
-  label_details: "Details"
-  label_customer_link_expires: "This customer link expires in"
+  label_actions: "Actions"
   label_amount: "Amount"
-  label_deposit_into: "Deposit to Account"
-  label_last_sync: "Last Sync"
-  label_redmine_qbo: "Redmine Quickbooks"
-  label_customer_count: "Customer Count"
-  label_invoice_count: "Invoice Count"
-  label_estimate_count: "Estimate Count"
-  label_employee_count: "Employee Count"
+  label_appointment: "Add Appointment"
+  label_balance_with_jobs: "Balance With Jobs"
+  label_bill_time: "Bill Time"
+  label_billing_address: "Billing Address"
+  label_billing_error: "Customer could not be billed. Check for Customer or Assignee and try again."
+  label_billing_error_no_customer: "Cannot bill without an assigned customer."
+  label_billed_success: "Successfully billed "
   label_client_id: "Intuit QBO OAuth2 Client ID"
   label_client_secret: "Intuit QBO OAuth2 Client Secret"
-  label_webhook_token: "Intuit QBO Webhook Token"
-  label_oauth_expires: "OAuth2 Access Token Expires At"
-  label_oauth_note: "Note: You need to authenticate with Quickbooks after saving your key and secret above"
-  field_customers: "Customers"
+  label_closed_issues: "Closed Issues"
+  label_connected: "Successfully connected to QuickBooks"
+  label_create_estimate: "Create Estimate"
+  label_customer_count: "Customer Count"
+  label_customer_link_expires: "This customer link expires in"
+  label_customers: "Customers"
+  label_delete: "Delete"
+  label_deposit_into: "Deposit to Account"
+  label_details: "Details"
+  label_display_name: "Display Name"
+  label_door: "Door"
+  label_edit: "Edit"
+  label_edit_customer: "Edit Customer"
+  label_email: "Email"
+  label_employee_count: "Employee Count"
+  label_error: "Error"
+  label_estimate_404: "Estimate not found"
+  label_estimate_count: "Estimate Count"
+  label_estimates: "Estimates"
+  label_hours: "Hours"
+  label_invoice_404: "Invoice not found"
+  label_invoice_count: "Invoice Count"
+  label_invoices: "Invoices"
+  label_last_sync: "Last Sync"
+  label_load_customer: "Load Customer"
+  label_make: "Make"
+  label_matching: "Matching"
+  label_mobile_phone: "Mobile Phone"
+  label_model: "Model"
+  label_name: "Name"
+  label_new_customer: "New Customer"
+  label_no_customers: "There are no customers matching the search term(s)."
   label_no_estimates: "No Estimates"
   label_no_invoices: "No Invoices"
-  label_invoices: "Invoices"
-  label_load_customer: "Load Customer"
-  label_door: "Door"
-  label_trim: "Trim"
-  label_bill_time: "Bill Time"
-  label_share: "Share"
-  label_sync_now: "Sync Now"
-  label_invoice_404: "Invoice not found"
-  label_estimate_404: "Estimate not found"
-  label_connected: "Successfully connected to Quickbooks"
-  label_error: "Error"
-  label_billed_success: "Successfully Billed "
-  label_billing_error: "Cannot bill without a customer assigned"
-  label_qbo_sync_success: "Successfully synced to Quickbooks"
-  label_hours: "Hours"
   label_oauth2_refresh_token_expires_at: "Refresh Token Expires At"
-  label_name: "Name"
-  label_appointment: "Add Appointment"
-  label_actions: "Actions"
-  label_create_estimate: "Create Estimate"
-  label_syncing: "Syncing Quickbooks"
+  label_oauth_expires: "OAuth2 Access Token Expires At"
+  label_oauth_note: "Note: You need to authenticate with QuickBooks after saving your key and secret above."
+  label_open_issues: "Open Issues"
+  label_primary_phone: "Primary Phone"
+  label_qbo_sync_success: "Successfully synced to QuickBooks"
+  label_redmine_qbo: "Redmine QuickBooks"
   label_sandbox: "Sandbox"
-  button_bulk_pdf: "Bulk PDF"
+  label_search: "Search"
+  label_search_customers: "Search Customers"
+  label_search_estimates: "Search Estimates"
   label_select_all: "Select All"
-  notice_customer_created: "Customer created in Quickbooks"
-  notice_customer_updated: "Customer updated in Quickbooks"
-  notice_customer_not_found: "Customer not found in Quickbooks"
-  notice_customer_not_deleted: "Customer could not be deleted in Quickbooks"
-  notice_customer_deleted: "Customer deleted in Quickbooks"
-  notice_estimate_created: "Estimate created in Quickbooks"
-  notice_estimate_updated: "Estimate updated in Quickbooks"
+  label_share: "Share"
+  label_shipping_address: "Shipping Address"
+  label_sync: "Sync"
+  label_sync_now: "Sync Now"
+  label_syncing: "Syncing QuickBooks"
+  label_trim: "Trim"
+  label_webhook_token: "Intuit QBO Webhook Token"
+  label_week: "Week"
+  label_year: "Year"
+  notice_customer_created: "Customer created in QuickBooks"
+  notice_customer_deleted: "Customer deleted in QuickBooks"
+  notice_customer_not_deleted: "Customer could not be deleted in QuickBooks"
+  notice_customer_not_found: "Customer not found in QuickBooks"
+  notice_customer_updated: "Customer updated in QuickBooks"
+  notice_error_project_nil: "The issue's project is nil. Set project to:"
+  notice_error_tracker_nil: "The issue's tracker is nil. Set tracker to:"
+  notice_estimate_created: "Estimate created in QuickBooks"
   notice_estimate_not_found: "Estimate not found"
-  notice_invoice_created: "Invoice created in Quickbooks"
-  notice_invoice_updated: "Invoice updated in Quickbooks"
+  notice_estimate_updated: "Estimate updated in QuickBooks"
+  notice_forbidden: "You do not have permission to access this resource."
+  notice_invoice_created: "Invoice created in QuickBooks"
   notice_invoice_not_found: "Invoice not found"
-  notice_forbidden: "You do not have permission to access this resource"
+  notice_invoice_updated: "Invoice updated in QuickBooks"
   notice_issue_not_found: "Issue not found"
-  customer_details: "Customer Details"
+  warn_ru_sure: "Are you sure?"

init.rb

@@ -14,7 +14,7 @@ Redmine::Plugin.register :redmine_qbo do
   name 'Redmine QBO plugin'
   author 'Rick Barrette'
   description 'A pluging for Redmine to connect with QuickBooks Online to create Time Activity Entries for billable hours logged when an Issue is closed'
-  version '2026.1.9'
+  version '2026.2.7'
   url 'https://github.com/rickbarrette/redmine_qbo'
   author_url 'https://barrettefabrication.com'
   settings default: {empty: true}, partial: 'qbo/settings'

lib/redmine_qbo/hooks/issues_hook_listener.rb

@@ -10,16 +10,19 @@
 
 module RedmineQbo
   module Hooks
-
-    class IssuesFormHookListener < Redmine::Hook::ViewListener
+    class IssuesHookListener < Redmine::Hook::ViewListener
 
       include IssuesHelper
 
       # Edit Issue Form
       # Here we build the required form components before passing them to a partial view formatting. 
       def view_issues_form_details_bottom(context={})
+        Rails.logger.debug "RedmineQbo::Hooks::IssuesHookListener.view_issues_form_details_bottom: Building form components for quickbooks customer, estimate, and invoice data"
         f = context[:form]
         issue = context[:issue]
+        project = context[:project]
+        Rails.logger.debug issue.inspect
+        Rails.logger.debug project.inspect
 
         # Customer Name Text Box with database backed autocomplete
         # onchange event will update the hidden customer_id field
@@ -31,11 +34,23 @@ module RedmineQbo
             value: '#issue_customer' 
           }
 
+        # We need to handle 3 cases for the onchange event of the customer name field:
+        # 1. New issue Withough project:  /issues/new.js
+        # 2. New issue With project:      /projects/rmt/issues/new.js
+        # 3. Existing issue:              /issues/<ID>/edit.js
+        # The built in helper update_issue_form_path requires a project object to determine the correct path for new vs existing issues, 
+        # but it doesn't work for issue.project when creating new issues not in a project i.e. http://redmine.domain.com/issues/new . 
+        # So we need to figure out how to get a the @project from the controller calling the hook.
+        #
+        # If this is not handled correctly, it leads to a 422 error when creating a new issue and selecting a customer.
+        js_path = "updateIssueFrom('#{escape_javascript update_issue_form_path(project, issue)}', this)"
+        Rails.logger.debug js_path
+
         # This hidden field is used for the customer ID for the issue
         # the onchange event will reload the issue form via ajax to update the available estimates
         customer_id = f.hidden_field :customer_id,
           id: "issue_customer_id",
-          onchange: "updateIssueFrom('#{escape_javascript update_issue_form_path(issue.project, issue)}', this)".html_safe
+          onchange: js_path.html_safe
 
         # Generate the drop down list of quickbooks estimates owned by the selected customer
         select_estimate = f.select :estimate_id, 
@@ -54,7 +69,31 @@ module RedmineQbo
           }
         )
       end
+
+      # View Issue
+      # Displays the quickbooks customer, estimate, & invoices attached to the issue
+      def view_issues_show_details_bottom(context={})
+        issue = context[:issue]
+        
+        # Build a list of invoice links
+        invoice_link = ""
+        if issue.invoices
+          issue.invoices.each do |i|
+            invoice_link += "#{link_to i, i, target: :_blank}<br/>"
+          end
+        end
+        
+        context[:controller].send(:render_to_string, {
+          partial: 'issues/show_details',
+            locals: {
+              customer: issue.customer ? link_to(issue.customer) : nil, 
+              estimate_link: issue.estimate ? link_to(issue.estimate, issue.estimate, target: :_blank) : nil, 
+              invoice_link: invoice_link.html_safe,
+              issue: issue
+            } 
+          })
       end
       
     end
+  end 
 end

lib/redmine_qbo/hooks/issues_show_hook_listener.rb

@@ -1,43 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-module RedmineQbo
-  module Hooks
-
-    class IssuesShowHookListener < Redmine::Hook::ViewListener
-
-      # View Issue
-      # Displays the quickbooks customer, estimate, & invoices attached to the issue
-      def view_issues_show_details_bottom(context={})
-        issue = context[:issue]
-        
-        # Build a list of invoice links
-        invoice_link = ""
-        if issue.invoices
-          issue.invoices.each do |i|
-            invoice_link += "#{link_to i, i, target: :_blank}<br/>"
-          end
-        end
-        
-        context[:controller].send(:render_to_string, {
-          partial: 'issues/show_details',
-            locals: {
-              customer: issue.customer ? link_to(issue.customer) : nil, 
-              estimate_link: issue.estimate ? link_to(issue.estimate, issue.estimate, target: :_blank) : nil, 
-              invoice_link: invoice_link.html_safe,
-              issue: issue
-            } 
-          })
-      end
-      
-    end
-
-  end 
-end

lib/redmine_qbo/hooks/view_hook_listener.rb

@@ -15,10 +15,11 @@ module RedmineQbo
 
       # Load the javascript to support the autocomplete forms
       def view_layouts_base_html_head(context = {})
-        js = javascript_include_tag 'application.js', plugin: :redmine_qbo
-        js += javascript_include_tag 'autocomplete-rails.js', plugin: :redmine_qbo
-        js += javascript_include_tag 'checkbox_controller.js', plugin: :redmine_qbo
-        return js
+        safe_join([
+          javascript_include_tag( 'application.js', plugin: :redmine_qbo),
+          javascript_include_tag( 'autocomplete-rails.js', plugin: :redmine_qbo),
+          javascript_include_tag( 'checkbox_controller.js', plugin: :redmine_qbo)
+        ])
       end
 
       render_on :view_layouts_base_sidebar, partial: "qbo/sidebar"

lib/redmine_qbo/patches/issue_patch.rb

@@ -43,11 +43,10 @@ module RedmineQbo
         
         # Create billable time entries
         def bill_time
-          logger.debug "QBO: Billing time for issue ##{id} - #{subject}"
-          return unless  status.is_closed?
-          return if assigned_to.nil?
-          return unless Qbo.first 
-          return unless customer 
+          logger.debug "QBO: Billing time for issue ##{id}"
+          return false if assigned_to.nil?
+          return false unless Qbo.first 
+          return false unless customer 
 
           Thread.new do
             spent_time = time_entries.where(billed: [false, nil])
@@ -102,6 +101,7 @@ module RedmineQbo
               end
             end
           end
+          return true
         end
       end
       
@@ -110,11 +110,21 @@ module RedmineQbo
         CustomerToken.get_token self
       end
       
-      # Titleize the subject before save
+      # Titleize the subject before save , but keep words containing numbers mixed with letters capitalized
       def titlize_subject
-        self.subject = self.subject.titleize
+        logger.debug "QBO: Titlizing subject for issue ##{self.id}"
+        self.subject = self.subject.split(/\s+/).map do |word|
+          # If word is NOT purely alphanumeric (contains special chars),
+          # or is all upper/lower, we can handle it.
+          # excluding alphanumeric strings with mixed case and numbers (e.g., "ID555ABC") from being altered.
+          if word =~ /[A-Z]/ && word =~ /[0-9]/
+            word
+          else
+            word.downcase
+            word.capitalize
+          end
+        end.join(' ')
       end
-      
     end  
 
     # Add module to Issue

lib/redmine_qbo/patches/issues_controller_patch.rb

@@ -15,21 +15,18 @@ module RedmineQbo
 
       module Helper
         def watcher_link(issue, user)
-          link = +''
-          link << link_to(I18n.t(:label_bill_time), bill_path( issue.id ), method: :get, class: 'icon icon-email-add') if user.admin?
+          link = ''
+          link = link_to(I18n.t(:label_bill_time), bill_path( issue.id ), method: :get, class: 'icon icon-email-add') if user.admin?
           link << link_to(I18n.t(:label_share), share_path( issue.id ), method: :get, target: :_blank, class: 'icon icon-shared') if user.logged?
           link.html_safe + super
         end
       end
 
       def self.included(base)
-
         base.class_eval do
           helper Helper
         end
-
       end 
-
     end
 
     # Add module to IssuessController