2026.3.0

app/models/line_item.rb

@@ -1,7 +0,0 @@
-class LineItem < ApplicationRecord
-  belongs_to :issue
-
-  validates :description, presence: true
-  validates :quantity, numericality: { greater_than: 0 }
-  validates :unit_price, numericality: { greater_than_or_equal_to: 0 }
-end

app/services/sync_service_base.rb

@@ -109,10 +109,10 @@ class SyncServiceBase
     if local.changed?
       local.save!
       log "Updated #{@entity.name} #{remote.id}"
-    end
 
-    # Handle attaching documents if applicable to invoices
+      # Handle attaching documents if applicable to invoices
-    attach_documents(local, remote)
+      attach_documents(local, remote) 
+    end
 
   rescue => e
       log "Failed to sync #{@entity.name} #{remote.id}: #{e.message}"

app/views/issues/_form_hook.html.erb

@@ -7,6 +7,3 @@
 <p>
     <%= select_estimate %>
 </p> 
-
-
-<%= render "line_items/issue_form", f: f %>

app/views/line_items/_issue_form.html.erb

@@ -1,17 +0,0 @@
-<% @issue.line_items.build if @issue.line_items.empty? %>
-
-<div data-nested-form data-wrapper-selector=".line-item">
-  <div data-nested-form-container>
-    <%= f.fields_for :line_items do |item_form| %>
-      <%= render "line_items/line_item_fields", f: item_form %>
-    <% end %>
-  </div>
-
-  <template data-nested-form-template>
-    <%= f.fields_for :line_items, LineItem.new, child_index: "NEW_RECORD" do |item_form| %>
-      <%= render "line_items/line_item_fields", f: item_form %>
-    <% end %>
-  </template>
-
-  <button type="button" data-nested-form-add>Add Line Item</button>
-</div>

app/views/line_items/_line_item_fields.html.erb

@@ -1,13 +0,0 @@
-<div class="line-item">
-  <%= f.hidden_field :id %>
-
-  <%= f.text_field :description, placeholder: "Description" %>
-  <%= f.number_field :quantity, step: 1, placeholder: "Quantity" %>
-  <%= f.number_field :unit_price, step: 0.01, placeholder: "Unit Price" %>
-
-  <%= f.hidden_field :_destroy %>
-
-  <button type="button" data-nested-form-remove>
-    Remove
-  </button>
-</div>

assets/javascripts/nested_form_controller.js

@@ -1,53 +0,0 @@
-(function () {
-  function initNestedForms() {
-    document.querySelectorAll("[data-nested-form]").forEach(function (wrapper) {
-      if (wrapper.dataset.initialized === "true") return;
-      wrapper.dataset.initialized = "true";
-
-      const container = wrapper.querySelector("[data-nested-form-container]");
-      const template = wrapper.querySelector("[data-nested-form-template]");
-
-      if (!container || !template) return;
-
-      wrapper.addEventListener("click", function (event) {
-        const addButton = event.target.closest("[data-nested-form-add]");
-        const removeButton = event.target.closest("[data-nested-form-remove]");
-
-        // ADD
-        if (addButton) {
-          event.preventDefault();
-
-          const content = template.innerHTML.replace(
-            /NEW_RECORD/g,
-            Date.now().toString()
-          );
-
-          container.insertAdjacentHTML("beforeend", content);
-        }
-
-        // REMOVE
-        if (removeButton) {
-          event.preventDefault();
-
-          const lineItem = removeButton.closest(wrapper.dataset.wrapperSelector);
-          if (!lineItem) return;
-
-          const destroyField = lineItem.querySelector("input[name*='_destroy']");
-
-          if (destroyField) {
-            destroyField.value = "1";
-            lineItem.style.display = "none";
-          } else {
-            lineItem.remove();
-          }
-        }
-      });
-    });
-  }
-
-  // Works for full load
-  document.addEventListener("DOMContentLoaded", initNestedForms);
-
-  // Works for Turbo navigation
-  document.addEventListener("turbo:load", initNestedForms);
-})();

db/migrate/026_create_line_items.rb

@@ -0,0 +1,26 @@
+#The License
+#
+#Copyright (c) 2016 - 2026 Rick Barrette - All Rights Reserved
+# 
+#Unauthorized copying of this software and associated documentation files (the "Software"), via any medium is strictly prohibited.
+#
+#Proprietary and confidential
+#
+#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+#
+#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+class CreateLineItems < ActiveRecord::Migration[5.1]
+  def change  
+    create_table :line_items do |t| 
+      t.integer  :item_id
+      t.float    :amount
+      t.string   :description 
+      t.float    :unit_price 
+      t.float    :quantity
+      t.boolean  :billed
+    end
+    
+    add_reference :line_items, :issues, index: true
+  end
+end

db/migrate/034_remove_qbo_items.rb

@@ -12,5 +12,6 @@ class RemoveQboItems < ActiveRecord::Migration[5.1]
   def change
     drop_table :qbo_items
     drop_table :qbo_purchases
+    drop_table :line_items
   end
 end

db/migrate/043_create_line_items.rb

@@ -1,42 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class CreateLineItems < ActiveRecord::Migration[7.0]
-  def change
-    create_table :line_items do |t|
-      t.integer :issue_id, null: false
-
-      t.text    :description, null: false
-
-      t.decimal :quantity,
-                precision: 15,
-                scale: 4,
-                null: false,
-                default: 0
-
-      t.decimal :unit_price,
-                precision: 15,
-                scale: 4,
-                null: false,
-                default: 0
-
-      t.decimal :line_total,
-                precision: 15,
-                scale: 4,
-                null: false,
-                default: 0
-
-      t.timestamps
-    end
-
-    add_index :line_items, :issue_id
-    add_foreign_key :line_items, :issues
-  end
-end

init.rb

@@ -14,7 +14,7 @@ Redmine::Plugin.register :redmine_qbo do
   name 'Redmine QBO plugin'
   author 'Rick Barrette'
   description 'A pluging for Redmine to connect with QuickBooks Online to create Time Activity Entries for billable hours logged when an Issue is closed'
-  version '2026.2.16'
+  version '2026.3.0'
   url 'https://github.com/rickbarrette/redmine_qbo'
   author_url 'https://barrettefabrication.com'
   settings default: {empty: true}, partial: 'qbo/settings'

lib/redmine_qbo/hooks/issues_hook_listener.rb

@@ -64,8 +64,7 @@ module RedmineQbo
             locals: {
               search_customer: search_customer, 
               customer_id: customer_id, 
-              select_estimate: select_estimate,
+              select_estimate: select_estimate
-              f: context[:form]
             } 
           }
         )

lib/redmine_qbo/hooks/view_hook_listener.rb

@@ -18,8 +18,7 @@ module RedmineQbo
         safe_join([
           javascript_include_tag( 'application.js', plugin: :redmine_qbo),
           javascript_include_tag( 'autocomplete-rails.js', plugin: :redmine_qbo),
-          javascript_include_tag( 'checkbox_controller.js', plugin: :redmine_qbo),
+          javascript_include_tag( 'checkbox_controller.js', plugin: :redmine_qbo)
-          javascript_include_tag( 'nested_form_controller.js', plugin: :redmine_qbo)
         ])
       end
 

lib/redmine_qbo/patches/issue_patch.rb

@@ -23,8 +23,6 @@ module RedmineQbo
           belongs_to :customer_token, primary_key: :id
           belongs_to :estimate, primary_key: :id
           has_and_belongs_to_many :invoices
-          has_many :line_items, dependent: :destroy
-          accepts_nested_attributes_for :line_items, allow_destroy: true
 
           before_save :titlize_subject
           after_commit :enqueue_billing, on: :update