2026.1.9

Inverted conditionals in estimates and invoices lists to use 'unless'
Refactor estimates and invoices rendering to use local variables for the abilty for other plugins to display filtered lists
2026-02-13 17:13:59 -05:00 · 2026-01-31 13:02:21 -05:00 · 2026-01-31 12:54:07 -05:00 · 2026-01-31 12:45:47 -05:00 · 2026-01-30 23:05:23 -05:00 · 2026-01-30 21:30:28 -05:00
93 changed files with 327 additions and 1092 deletions
--- a/1
+++ b/1
@@ -3,7 +3,6 @@ source 'https://rubygems.org'
 gem 'quickbooks-ruby'
 gem 'oauth2'
 gem 'roxml'
-gem 'nhtsa_vin'
 gem 'will_paginate'
 gem 'rails-jquery-autocomplete'
 gem 'jquery-ui-rails'
--- a/README.md
+++ b/README.md
@@ -35,6 +35,7 @@ The goal of this project is to allow Redmine to connect with QuickBooks Online t
    * **Invoices:** Automatically attached to an Issue if a line item contains a hashtag number (e.g., `#123`).
    * **Custom Fields:** Invoice Custom Fields are matched to Issue Custom Fields and are automatically updated in QuickBooks. (Useful for extracting Mileage In/Out from the Issue to update the Invoice).
    * **Sync:** Customers are automatically updated in the local database.
+* **Plugin View Hooks** Allows intergration of other features supported by companion plugins, for example [redmine_qbo_vehicles](https://github.com/rickbarrette/redmine_qbo_vehicles) adds customer vehicle interation

 ## Prerequisites

@@ -90,12 +91,11 @@ To enable automatic Time Activity entries for an Issue, you simply need to assig

 **Note:** After the initial synchronization, this plugin will receive push notifications via Intuit's webhook service.   

-## TODO
-    
-*   Separate Vehicles into a separate plugin (I use Redmine for my automotive shop management 😉)
-    
-*   MORE Stuff as I make it up...
-    
+## Companion Plugin Hooks
+* :pdf_left, { issue: issue }
+* :pdf_right, { issue: issue }
+* :process_invoice_custom_fields, { issue: issue, invoice: invoice } 
+* :show_customer_view_right, {customer: @customer}

 ## License

--- a/app/controllers/customers_controller.rb
+++ b/app/controllers/customers_controller.rb
@@ -26,24 +26,18 @@ class CustomersController < ApplicationController
  include SortHelper
  helper :timelog

-  before_action :add_customer, :only => :new
-  before_action :view_customer, :except => [:new, :view]
-  skip_before_action :verify_authenticity_token, :check_if_login_required, :only => [:view]
+  before_action :add_customer, only: :new
+  before_action :view_customer, except: [:new, :view]
+  skip_before_action :verify_authenticity_token, :check_if_login_required, only: [:view]

  default_search_scope :names

-  autocomplete :customer, :name, :full => true, :extra_data => [:id]
+  autocomplete :customer, :name, full: true, extra_data: [:id]

  def allowed_params
    params.require(:customer).permit(:name, :email, :primary_phone, :mobile_phone, :phone_number, :notes)
  end

-  # getter method for a customer's vehicles
-  # used for customer autocomplete field / issue form
-  def filter_vehicles_by_customer
-    @filtered_vehicles = Vehicle.all.where(customer_id: params[:selected_customer])
-  end
-
  # getter method for a customer's invoices
  # used for customer autocomplete field / issue form
  def filter_invoices_by_customer
@@ -59,7 +53,7 @@ class CustomersController < ApplicationController
  # display a list of all customers
  def index
    if params[:search]
-      @customers = Customer.search(params[:search]).paginate(:page => params[:page])
+      @customers = Customer.search(params[:search]).paginate(page: params[:page])
      if only_one_non_zero?(@customers)
        redirect_to @customers.first
      end
@@ -75,7 +69,7 @@ class CustomersController < ApplicationController
  def create
    @customer = Customer.new(allowed_params)
    if @customer.save
-      flash[:notice] = "New Customer Created"
+      flash[:notice] = t :notice_customer_created
      redirect_to @customer
    else
      flash[:error] = @customer.errors.full_messages.to_sentence
@@ -87,7 +81,6 @@ class CustomersController < ApplicationController
  def show
    begin
      @customer = Customer.find_by_id(params[:id])
-      @vehicles = @customer.vehicles.paginate(:page => params[:page])
      @issues = @customer.issues.order(id: :desc)
      @billing_address = address_to_s(@customer.billing_address)
      @shipping_address = address_to_s(@customer.shipping_address)
@@ -97,6 +90,7 @@ class CustomersController < ApplicationController
      @issues.open.each { |i| @hours+= i.total_spent_hours }
      @closed_issues.each { |i| @closed_hours+= i.total_spent_hours }
    rescue 
+      flash[:error] = t :notice_customer_not_found
      render_404
    end
  end
@@ -106,6 +100,7 @@ class CustomersController < ApplicationController
    begin
      @customer = Customer.find_by_id(params[:id])
    rescue 
+      flash[:error] = t :notice_customer_not_found
      render_404
    end
  end
@@ -115,13 +110,14 @@ class CustomersController < ApplicationController
    begin
      @customer = Customer.find_by_id(params[:id])
      if @customer.update(allowed_params)
-        flash[:notice] = "Customer updated"
+        flash[:notice] = t :notice_customer_updated
        redirect_to @customer
      else
        redirect_to edit_customer_path
        flash[:error] = @customer.errors.full_messages.to_sentence if @customer.errors
      end
    rescue 
+      flash[:error] = t :notice_customer_not_found
      render_404
    end
  end
@@ -130,9 +126,10 @@ class CustomersController < ApplicationController
  def destroy
    begin
      Customer.find_by_id(params[:id]).destroy
-      flash[:notice] = "Customer deleted successfully"
+      flash[:notice] = t :notice_customer_deleted
      redirect_to action: :index
    rescue 
+      flash[:error] = t :notice_customer_not_deleted
      render_404
    end
  end
@@ -150,6 +147,7 @@ class CustomersController < ApplicationController
      issue = Issue.find_by_id(params[:id])
      redirect_to view_path issue.share_token.token
    rescue
+      flash[:error] = t :notice_issue_not_found
      render_404
    end
  end
@@ -168,7 +166,7 @@ class CustomersController < ApplicationController
      @issue = Issue.find @token.issue_id
      @journals = @issue.journals.
        preload(:details).
-        preload(:user => :email_address).
+        preload(user: :email_address).
        reorder(:created_on, :id).to_a
      @journals.each_with_index {|j,i| j.indice = i+1}
      @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
@@ -182,9 +180,10 @@ class CustomersController < ApplicationController
      @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
      @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
      @priorities = IssuePriority.active
-      @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
+      @time_entry = TimeEntry.new(issue: @issue, project: @issue.project)
      @relation = IssueRelation.new
    rescue
+      flash[:error] = t :notice_forbidden
      render_403
    end
  end
--- a/app/controllers/estimate_controller.rb
+++ b/app/controllers/estimate_controller.rb
@@ -11,8 +11,8 @@ class EstimateController < ApplicationController
  
  include AuthHelper
  
-  before_action :require_user, :unless => proc {|c| session[:token].nil? }
-  skip_before_action :verify_authenticity_token, :check_if_login_required, :unless => proc {|c| session[:token].nil? }
+  before_action :require_user, unless: proc {|c| session[:token].nil? }
+  skip_before_action :verify_authenticity_token, :check_if_login_required, unless: proc {|c| session[:token].nil? }

  def get_estimate
    # Force sync for estimate by doc number if not found
@@ -36,9 +36,9 @@ class EstimateController < ApplicationController
    estimate = get_estimate

    begin
-      send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", :disposition => 'inline', :type => "application/pdf"
+      send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", disposition: :inline, type: "application/pdf"
    rescue
-      redirect_to :back, :flash => { :error => "Estimate not found" }
+      redirect_to :back, flash: { error: I18n.t(:notice_estimate_not_found) }
    end
  end

@@ -49,9 +49,9 @@ class EstimateController < ApplicationController
    estimate = get_estimate
    
    begin
-      send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", :disposition => 'inline', :type => "application/pdf"
+      send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", disposition: :inline, type: "application/pdf"
    rescue
-      redirect_to :back, :flash => { :error => "Estimate not found" }
+      redirect_to :back, flash: { error: I18n.t(:notice_estimate_not_found) }
    end
  end

--- a/app/controllers/invoice_controller.rb
+++ b/app/controllers/invoice_controller.rb
@@ -12,8 +12,8 @@ class InvoiceController < ApplicationController
  include AuthHelper
  require 'combine_pdf'

-  before_action :require_user, :unless => proc {|c| session[:token].nil? }
-  skip_before_action :verify_authenticity_token, :check_if_login_required, :unless => proc {|c| session[:token].nil? }
+  before_action :require_user, unless: proc {|c| session[:token].nil? }
+  skip_before_action :verify_authenticity_token, :check_if_login_required, unless: proc {|c| session[:token].nil? }
  
  #
  # Downloads and forwards the invoice pdf
@@ -23,7 +23,7 @@ class InvoiceController < ApplicationController
    begin
      qbo = Qbo.first
        qbo.perform_authenticated_request do |access_token|
-        service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
+        service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
        
        # If multiple id's then pull each pdf & combine them
        if params[:invoice_ids]
@@ -45,10 +45,10 @@ class InvoiceController < ApplicationController
          ref = invoice.doc_number
        end

-        send_data @pdf, filename: "invoice #{ref}.pdf", :disposition => 'inline', :type => "application/pdf"
+        send_data @pdf, filename: "invoice #{ref}.pdf", disposition: :inline, type: "application/pdf"
      end
    rescue
-      redirect_to :back, :flash => { :error => "Invoice not found" }
+      redirect_to :back, flash: { error: I18n.t(:notice_invoice_not_found) }
    end
  end
 end
--- a/app/controllers/qbo_controller.rb
+++ b/app/controllers/qbo_controller.rb
@@ -14,8 +14,8 @@ class QboController < ApplicationController
  
  include AuthHelper
  
-  before_action :require_user, :except => :webhook
-  skip_before_action :verify_authenticity_token, :check_if_login_required, :only => [:webhook]
+  before_action :require_user, except: :webhook
+  skip_before_action :verify_authenticity_token, :check_if_login_required, only: [:webhook]

  def allowed_params
    params.permit(:code, :state, :realmId, :id)
@@ -51,9 +51,9 @@ class QboController < ApplicationController
        qbo.refresh_token!
        
        if qbo.save!
-          redirect_to qbo_sync_path, :flash => { :notice => I18n.t(:label_connected) }
+          redirect_to qbo_sync_path, flash: { notice: I18n.t(:label_connected) }
        else
-          redirect_to plugin_settings_path(:redmine_qbo), :flash => { :error => I18n.t(:label_error) }
+          redirect_to plugin_settings_path(:redmine_qbo), flash: { error: I18n.t(:label_error) }
        end
        
      end
@@ -65,9 +65,9 @@ class QboController < ApplicationController
    i = Issue.find_by_id params[:id]
    if i.customer
      i.bill_time
-      redirect_to i, :flash => { :notice => I18n.t(:label_billed_success) + i.customer.name }
+      redirect_to i, flash: { notice: I18n.t(:label_billed_success) + i.customer.name }
    else
-      redirect_to i, :flash => { :error => I18n.t(:label_billing_error) }
+      redirect_to i, flash: { error: I18n.t(:label_billing_error) }
    end
  end
  
@@ -125,7 +125,7 @@ class QboController < ApplicationController
        ActiveRecord::Base.connection.close
      end
      # The webhook doesn't require a response but let's make sure we don't send anything
-      render :nothing => true, status: 200
+      render nothing: true, status: 200
    else
      render nothing: true, status: 400
    end
@@ -152,6 +152,6 @@ class QboController < ApplicationController
      ActiveRecord::Base.connection.close
    end

-    redirect_to :home, :flash => { :notice => I18n.t(:label_syncing) }
+    redirect_to :home, flash: { notice: I18n.t(:label_syncing) }
  end
 end
--- a/app/controllers/vehicles_controller.rb
+++ b/app/controllers/vehicles_controller.rb
@@ -1,125 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-# This controller class will handle map management
-class VehiclesController < ApplicationController
-
-  include AuthHelper
-
-  before_action :require_user
-
-  def allowed_params
-    params.require(:vehicle).permit(:year, :make, :model, :customer_id, :notes, :vin)
-  end
-
-  # display a list of all vehicles
-  def index
-    if params[:customer_id]
-      begin
-        @vehicles = Customer.find_by_id(params[:customer_id]).vehicles.paginate(:page => params[:page])
-      rescue ActiveRecord::RecordNotFound
-        render_404
-      end
-    end
-
-    # search for a vehicle by vin
-    if params[:search]
-      @vehicles = Vehicle.search(params[:search]).paginate(:page => params[:page])
-      if only_one_non_zero?(@vehicles)
-        redirect_to @vehicles.first
-      end
-    end
-  end
-
-  # return an HTML form for creating a new vehicle
-  def new
-    @vehicle = Vehicle.new
-    @customer = Customer.find_by_id(params[:customer_id]) if params[:customer_id]
-  end
-
-  # create a new vehicle
-  def create
-    @vehicle = Vehicle.new(allowed_params)
-    if @vehicle.save
-      flash[:notice] = "New Vehicle Created"
-      redirect_to @vehicle
-    else
-      flash[:error] = @vehicle.errors.full_messages.to_sentence
-      redirect_to Vehicle.find_by_vin @vehicle.vin
-    end
-  end
-
-  # display a specific vehicle
-  def show
-    begin
-      @vehicle = Vehicle.find_by_id(params[:id])
-      @vin = @vehicle.vin.scan(/.{1,9}/) if @vehicle.vin
-      @issues = @vehicle.issues.order(id: :desc)
-      @closed_issues = (@issues - @issues.open)
-    rescue 
-      render_404
-    end
-  end
-
-  # return an HTML form for editing a vehicle
-  def edit
-    begin
-      @vehicle = Vehicle.find_by_id(params[:id])
-      @customer = @vehicle.customer
-    rescue 
-      render_404
-    end
-  end
-
-  # update a specific vehicle
-  def update
-    @customer = params[:customer]
-    begin
-      @vehicle = Vehicle.find_by_id(params[:id])
-      if @vehicle.update(allowed_params)
-        flash[:notice] = "Vehicle updated"
-        redirect_to @vehicle
-      else
-        redirect_to edit_vehicle_path
-      end
-      #show any errors anyways
-      flash[:error] = @vehicle.errors.full_messages.to_sentence unless @vehicle.errors.empty?
-    rescue 
-      render_404
-    end
-  end
-
-  # delete a specific vehicle
-  def destroy
-    begin
-      Vehicle.find_by_id(params[:id]).destroy
-      flash[:notice] = "Vehicle deleted successfully"
-      redirect_to action: :index
-    rescue 
-      render_404
-    end
-  end
-
-  private
-
-  # checks to see if there is only one item in an array
-  # @return true if array only has one item
-  def only_one_non_zero?( array )
-    found_non_zero = false
-    array.each do |val|
-      if val!=0
-        return false if found_non_zero
-        found_non_zero = true
-      end
-    end
-    found_non_zero
-  end
-
-end
--- a/app/helpers/auth_helper.rb
+++ b/app/helpers/auth_helper.rb
@@ -13,6 +13,7 @@ module AuthHelper
  def require_user
    return unless session[:token].nil?
    if !User.current.logged?
+      flash[:error] = t :notice_forbidden
      render_403
    end
  end
@@ -27,6 +28,7 @@ module AuthHelper
  
  def check_permission(permission)
    if !allowed_to?(permission)
+      flash[:error] = t :notice_forbidden
      render_403
    end
  end
@@ -34,6 +36,7 @@ module AuthHelper
  
  def global_check_permission(permission)
    if !globaly_allowed_to?(permission)
+      flash[:error] = t :notice_forbidden
      render_403
    end
  end
--- a/app/models/concerns/quickbooks_oauth.rb
+++ b/app/models/concerns/quickbooks_oauth.rb
@@ -73,7 +73,7 @@ module QuickbooksOauth
      oauth_consumer_secret = Setting.plugin_redmine_qbo['settingsOAuthConsumerSecret']

      # Are we are playing in the sandbox?
-      Quickbooks.sandbox_mode = Setting.plugin_redmine_qbo['sandbox'] ? true : false
+      Quickbooks.sandbox_mode = Setting.plugin_redmine_qbo[:sandbox] ? true : false
      logger.info "Sandbox mode: #{Quickbooks.sandbox_mode}"

      options = {
--- a/app/models/customer.rb
+++ b/app/models/customer.rb
@@ -13,7 +13,6 @@ class Customer < ActiveRecord::Base
  has_many :issues
  has_many :invoices
  has_many :estimates
-  has_many :vehicles
 
  validates_presence_of :id, :name
  
@@ -143,7 +142,7 @@ class Customer < ActiveRecord::Base
    # Sync ALL customers if the database is empty
    qbo = Qbo.first
    customers = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Customer.new(company_id: qbo.realm_id, access_token: access_token)
      service.all
    end
    
@@ -179,7 +178,7 @@ class Customer < ActiveRecord::Base
  def self.sync_by_id(id) 
    qbo = Qbo.first
    c = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Customer.new(company_id: qbo.realm_id, access_token: access_token)
      service.fetch_by_id(id)
    end

@@ -206,7 +205,7 @@ class Customer < ActiveRecord::Base
    begin
      qbo = Qbo.first
      @details = qbo.perform_authenticated_request do |access_token|
-        service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
+        service = Quickbooks::Service::Customer.new(company_id: qbo.realm_id, access_token: access_token)
        service.update(@details)
      end
      #raise "QBO Fault" if @details.fault?
@@ -228,7 +227,7 @@ class Customer < ActiveRecord::Base
      raise Exception unless self.id
      qbo = Qbo.first
      @details = qbo.perform_authenticated_request do |access_token|
-        service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
+        service = Quickbooks::Service::Customer.new(company_id: qbo.realm_id, access_token: access_token)
        service.fetch_by_id(self.id)
      end
    rescue Exception => e
--- a/app/models/customer_token.rb
+++ b/app/models/customer_token.rb
@@ -55,7 +55,7 @@ class CustomerToken < ActiveRecord::Base
    end

    # only create new token if we have an issue to attach it to
-    return create(:issue_id => issue.id) if User.current.logged?
+    return create(issue_id: issue.id) if User.current.logged?
  end

 end
--- a/app/models/employee.rb
+++ b/app/models/employee.rb
@@ -16,14 +16,13 @@ class Employee < ActiveRecord::Base
  def self.sync 
    qbo = Qbo.first
    employees = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Employee.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Employee.new(company_id: qbo.realm_id, access_token: access_token)
      service.all
    end

    return unless employees
    
    transaction do
-      # Update the item table
      employees.each { |e|
        logger.info "Processing employee #{e.id}"
        employee = 	find_or_create_by(id: e.id)
@@ -37,7 +36,7 @@ class Employee < ActiveRecord::Base
  def self.sync_by_id(id)
    qbo = Qbo.first
    employee = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Employee.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Employee.new(company_id: qbo.realm_id, access_token: access_token)
      service.fetch_by_id(id)
    end

--- a/app/models/estimate.rb
+++ b/app/models/estimate.rb
@@ -15,12 +15,17 @@ class Estimate < ActiveRecord::Base
  validates_presence_of :doc_number, :id
  self.primary_key = :id

+  # returns a human readable string
+  def to_s
+    return self[:doc_number]
+  end
+  
  # sync all estimates
  def self.sync
    logger.info "Syncing ALL estimates"
    qbo = Qbo.first
    estimates = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
      service.all
    end

@@ -39,7 +44,7 @@ class Estimate < ActiveRecord::Base
    logger.info "Syncing estimate #{id}"
    qbo = Qbo.first
    qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
      process_estimate(service.fetch_by_id(id))
    end
  end
@@ -49,17 +54,16 @@ class Estimate < ActiveRecord::Base
    logger.info "Syncing estimate by doc number #{number}"
    qbo = Qbo.first
    qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
      process_estimate(service.find_by( :doc_number, number).first)
    end
  end
  
  # update an estimate
  def self.update(id)
-    # Update the item table
    qbo = Qbo.first
    estimate = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
      service.fetch_by_id(id)
    end

@@ -86,7 +90,7 @@ class Estimate < ActiveRecord::Base
  def pdf
    qbo = Qbo.first
    qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
      estimate = service.fetch_by_id(id)
      service.pdf(estimate)
    end
@@ -118,7 +122,7 @@ class Estimate < ActiveRecord::Base
      raise Exception unless self.id
      qbo = Qbo.first
      @details = qbo.perform_authenticated_request do |access_token|
-        service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
+        service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
        service(:estimate).fetch_by_id(self.id)
      end
    rescue Exception => e
--- a/app/models/invoice.rb
+++ b/app/models/invoice.rb
@@ -15,6 +15,11 @@ class Invoice < ActiveRecord::Base
  validates_presence_of :doc_number, :id, :customer_id, :txn_date
  self.primary_key = :id

+   # returns a human readable string
+  def to_s
+    return self[:doc_number]
+  end
+  
  # sync ALL the invoices
  def self.sync
    logger.info "Syncing all invoices"
@@ -27,7 +32,7 @@ class Invoice < ActiveRecord::Base
    # .all() is never called since count is never initialized
    qbo = Qbo.first
    invoices = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
      service.all 
    end

@@ -43,7 +48,7 @@ class Invoice < ActiveRecord::Base
    logger.info "Syncing invoice #{id}"
    qbo = Qbo.first
    qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
      invoice = service.fetch_by_id(id) 
      process_invoice invoice
    end
@@ -109,33 +114,18 @@ class Invoice < ActiveRecord::Base
    # TODO break if Invoice.find(invoice.id).cf_sync_confict
    is_changed = false

-    # update the invoive custom fields with infomation from the issue if available
-    invoice.custom_fields.each { |cf|
+    logger.debug "Calling :process_invoice_custom_fields hook"
+    context = Redmine::Hook.call_hook :process_invoice_custom_fields, { issue: issue, invoice: invoice } 

-      # VIN from the attached vehicle
-      # TODO move this into seperate plugin
-      # TODO create hook for seperate plugin 
-      begin
-        if cf.name.eql? "VIN"
-          # Only update if blank to prevent infite loops
-          # TODO check cf_sync_confict flag once implemented
-          if cf.string_value.to_s.blank?
-            logger.info " VIN was blank, updating the invoice vin in quickbooks"
-            vin = Vehicle.find(issue.vehicles_id).vin
-            break if vin.nil?
-            if not cf.string_value.to_s.eql? vin
-              cf.string_value = vin.to_s
-              logger.info "VIN has changed"
-              is_changed = true
+    # Process updates from the hooks
+    context.each do |c|
+      unless c.nil?
+        logger.debug "Invoice.compare_custom_fields: We have a responce from a hook"
+        push_updates  c[:invoice] if c[:is_changed]
+      end
    end
      
-          end
-        end
-      rescue
-        #do nothing
-      end
-      
-      # Custom Values
+    # Process Issue Custom Values
    begin
      value = issue.custom_values.find_by(custom_field_id: CustomField.find_by_name(cf.name).id)
      
@@ -151,15 +141,18 @@ class Invoice < ActiveRecord::Base
    rescue
      # Nothing to do here, there is no match
    end
-    }

-    # Push updates
+    push_updates invoice if is_changed
+  end
+
+  # pushes invoice updates
+  def self.push_updates(invoice)
    begin
-      logger.info "Trying to update invoice"
+      logger.info "Invoice.push_updates"
      qbo = Qbo.first
      qbo.perform_authenticated_request do |access_token|
-        service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
-        service.update(invoice) if is_changed
+        service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
+        service.update invoice
      end
    rescue
      # Do nothing, probaly custome field sync confict on the invoice. 
@@ -174,7 +167,7 @@ class Invoice < ActiveRecord::Base
  def pdf
    qbo = Qbo.first
    qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
+      service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
      invoice = service.fetch_by_id(id)
      return service.pdf(invoice)
    end
@@ -204,7 +197,7 @@ class Invoice < ActiveRecord::Base
      raise Exception unless self.id
      qbo = Qbo.first
      @details = qbo.perform_authenticated_request do |access_token|
-        service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
+        service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
        service.fetch_by_id(self.id)
      end
    rescue Exception => e
--- a/app/models/vehicle.rb
+++ b/app/models/vehicle.rb
@@ -1,98 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class Vehicle < ActiveRecord::Base
-  
-  belongs_to :customer
-  has_many :issues, :foreign_key => 'vehicles_id'
-  
-  validates_presence_of :customer
-  validates :vin, uniqueness: true
-  before_save :decode_vin
-  
-  self.primary_key = :id
-  
-  # returns a human readable string
-  def to_s
-    if year.nil? or make.nil? or model.nil?
-      return "#{vin}"
-    else
-      split_vin = vin.scan(/.{1,9}/)
-      return "#{year} #{make} #{model} - #{split_vin[1]}"
-    end
-  end
-  
-  # returns the raw JSON details from NHTSA
-  def details
-    get_details if @details.nil?
-    return @details
-  end
-  
-  # Force Upper Case for make numbers
-  def make=(val)
-    # The to_s is in case you get nil/non-string
-    write_attribute(:make, val.to_s.titleize)
-  end
-  
-  # Force Upper Case for model numbers
-  def model=(val)
-    # The to_s is in case you get nil/non-string
-    write_attribute(:model, val.to_s.titleize)
-  end
-  
-  # Force Upper Case & strip VIN of all illegal chars (for barcode scanner)
-  def vin=(val)
-    val = val.to_s.upcase.gsub(/[^A-HJ-NPR-Za-hj-npr-z\d]+/,"")
-    write_attribute(:vin, val)
-  end
-  
-  # search for a vin
-  def self.search(search)
-    where("vin LIKE ?", "%#{search}%")
-  end
-	
-  # decodes a vin and updates self
-  def decode_vin
-    get_details
-    if @details
-      begin
-        self.year = @details.year unless @details.year.nil?
-        self.make = @details.make unless @details.make.nil?
-        self.model = @details.model unless @details.model.nil?
-        self.doors = @details.doors unless @details.doors.nil?
-        self.trim = @details.trim unless @details.trim.nil?
-      rescue Exception => e
-        errors.add(:vin, e.message)
-      end
-    end
-    self.name = to_s
-  end
-  
-  private
-  
-  # init method to pull JSON details from NHTSA
-  def get_details
-    if self.vin?
-      #validate the vin before calling a remote server
-      validation = NhtsaVin.validate(self.vin)
-      begin
-        #if the vin validation failed, raise an exception and exit
-        raise RuntimeError, validation.error unless validation.valid?
-        # query NHTSA for details on the vin
-        query = NhtsaVin.get(self.vin)
-        raise RuntimeError, query.error unless query.valid?
-        @details = query.response
-      rescue Exception => e
-        errors.add(:vin, e.message)
-      end
-    end
-  end
-  
-end
--- a/app/views/customers/_actions.html.erb
+++ b/app/views/customers/_actions.html.erb
@@ -1,4 +1,4 @@
-<%= link_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to "Customer Details", "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank %>
+<%= link_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to t(:customer_details), "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank %>

 <br/>
 <br/>
--- a/app/views/customers/_details.html.erb
+++ b/app/views/customers/_details.html.erb
@@ -37,8 +37,11 @@
    </tr>
    
    <tr>
-      <th><%=t(:field_notes)%></th>
-      <td>
+      <th colspan="2"><h4><%=t(:field_notes)%></hr></th>
+    </tr>
+
+    <tr>
+      <td colspan="2">
       <pre id="note-display" style="text-align: left; white-space: pre-wrap; font-family: inherit;">
          <%= customer.notes %>
        </pre>
--- a/app/views/customers/_form.html.erb
+++ b/app/views/customers/_form.html.erb
@@ -7,28 +7,28 @@
        <div class="clearfix">
          <%=t(:label_display_name)%> 
          <div class="input">
-            <%= f.text_field :name, :required => true, :autocomplete => "off" %>
+            <%= f.text_field :name, required: true, autocomplete: "off" %>
          </div>
        </div>
        
        <div class="clearfix">
          <%=t(:label_primary_phone)%>
          <div class="input">
-            <%= f.telephone_field :primary_phone, :autocomplete => "off" %>
+            <%= f.telephone_field :primary_phone, autocomplete: "off" %>
          </div>
        </div>
        
       <div class="clearfix">
          <%=t(:label_mobile_phone)%>:
          <div class="input">
-            <%= f.telephone_field :mobile_phone, :autocomplete => "off" %>
+            <%= f.telephone_field :mobile_phone, autocomplete: "off" %>
          </div>
        </div>
        
        <div class="clearfix">
          <%=t(:label_email)%>:
          <div class="input">
-            <%= f.email_field :email, :autocomplete => "off" %>
+            <%= f.email_field :email, autocomplete: "off" %>
          </div>
        </div>
        
@@ -36,16 +36,16 @@
          <%=t(:field_notes)%>: 
          <div class="input">
            <p>  
-              <%= content_tag 'span', :id => "issue_description_and_toolbar" do %>
+              <%= content_tag :span, id: "issue_description_and_toolbar" do %>
              <%= f.text_area :notes,
-                    :cols => 60,
-                    :rows => 10,
-                    :accesskey => accesskey(:edit),
-                    :class => 'wiki-edit',
-                    :no_label => true %>
+                    cols: 60,
+                    rows: 10,
+                    accesskey: accesskey(:edit),
+                    class: 'wiki-edit',
+                    no_label: true %>
              <% end %>
            </p>
-            <%= wikitoolbar_for 'issue_description' %>
+            <%= wikitoolbar_for :issue_description %>
          </div>
        </div>
        
--- a/app/views/customers/_search.html.erb
+++ b/app/views/customers/_search.html.erb
@@ -1,5 +1,5 @@
-<%= form_tag(customers_path, :method => "get", id: "search-form") do %>
-    <%= text_field_tag :search, params[:search], placeholder: t(:label_search_customers), :autocomplete => "off" %>
+<%= form_tag(customers_path, method: "get", id: "search-form") do %>
+    <%= text_field_tag :search, params[:search], placeholder: t(:label_search_customers), autocomplete: "off" %>
    <%= submit_tag t(:label_search) %>
 <% end %>
 <%= button_to t(:label_new_customer), new_customer_path, method: :get%>
--- a/app/views/customers/_sidebar.html.erb
+++ b/app/views/customers/_sidebar.html.erb
@@ -1,2 +1,2 @@
 <h3><%=t(:label_customers)%></h3>
-<%= render :partial => 'customers/search' %>
+<%= render partial: 'customers/search' %>
--- a/app/views/customers/edit.html.erb
+++ b/app/views/customers/edit.html.erb
@@ -1,3 +1,3 @@
 <h1><%=t(:label_edit_customer)%></h1> 
 <br/> 
-<%= render :partial => 'customers/form' %>
+<%= render partial: 'customers/form' %>
--- a/app/views/customers/filter_estimates_by_customer.js.erb
+++ b/app/views/customers/filter_estimates_by_customer.js.erb
@@ -1 +1 @@
-$('select#issue_estimate_id').html('<%= j content_tag(:option,'',:value=>"")+options_from_collection_for_select(@filtered_estimates, :id, :doc_number) %>');
+$('select#issue_estimate_id').html('<%= j content_tag(:option,'',value:"")+options_from_collection_for_select(@filtered_estimates, :id, :doc_number) %>');
--- a/app/views/customers/filter_vehicles_by_customer.js.erb
+++ b/app/views/customers/filter_vehicles_by_customer.js.erb
@@ -1 +0,0 @@
-$('select#issue_vehicles_id').html('<%= j content_tag(:option,'',:value=>"")+options_from_collection_for_select(@filtered_vehicles, :id, :to_s) %>');
--- a/app/views/customers/index.html.erb
+++ b/app/views/customers/index.html.erb
@@ -1,4 +1,4 @@
-<h2><%=t(:field_customers)%> <span style="float:right"> <%= render :partial => 'customers/search' %> </span> </h2>
+<h2><%=t(:field_customers)%> <span style="float:right"> <%= render partial: 'customers/search' %> </span> </h2>
 <% if @customers.present? %>
  <br/>
  <% @customers.each do |c| %>
@@ -20,5 +20,5 @@
 <% end %>

 <div>
-  <%= render :partial => 'qbo/stats' %>
+  <%= render partial: 'qbo/stats' %>
 </div>
--- a/app/views/customers/new.html.erb
+++ b/app/views/customers/new.html.erb
@@ -1,3 +1,3 @@
 <h2><%=t(:label_new_customer)%></h2> 
 <br/>
-<%= render :partial => 'customers/form' %>
+<%= render partial: 'customers/form' %>
--- a/app/views/customers/show.html.erb
+++ b/app/views/customers/show.html.erb
@@ -1,4 +1,4 @@
-<h2><%=t(:field_customer)%> #<%= @customer.id %> - <%= link_to @customer.to_s, "https://app.qbo.intuit.com/app/customerdetail?nameId=#{@customer.id}", target: :_blank %> </h2>
+<h2><%=t(:field_customer)%> #<%= @customer.id %> - <%= link_to @customer.to_s, "https://#{Setting.plugin_redmine_qbo[:sandbox] ? "sandbox" : "app"}.qbo.intuit.com/app/customerdetail?nameId=#{@customer.id}", target: :_blank %> </h2>
  <div class="issue">

    <div class="splitcontent">
@@ -11,13 +11,13 @@

        <div class="splitcontent">
          <div class="splitcontentleft">
-            <h4><%=t(:label_customer)%>:</h4>
-            <%= render :partial => 'customers/details', locals: {customer: @customer} %>
+            <h4><%=t(:field_customer)%>:</h4>
+            <%= render partial: 'customers/details', locals: {customer: @customer} %>
          </div>

          <div class="splitcontentleft">
            <h4><%=t(:label_actions)%>:</h4>
-            <%= render :partial => 'customers/actions', locals: {customer: @customer} %>
+            <%= render partial: 'customers/actions', locals: {customer: @customer} %>
          </div>
        </div>

@@ -27,23 +27,19 @@
        <div class="splitcontent">
          <div class="splitcontentleft">
            <h4><%=t(:estimates)%>:</h4>
-            <%= render :partial => 'estimates/list', locals: {customer: @customer} %>
+            <%= render partial: 'estimates/list', locals: {estimates: @customer.estimates} %>
          </div>

          <div class="splitcontentleft">
            <h4><%=t(:label_invoices)%>:</h4>
-            <%= render :partial => 'invoices/list', locals: {customer: @customer} %>
+            <%= render partial: 'invoices/list', locals: {invoices: @customer.invoices} %>
          </div>
        </div>

      </div>
        
      <div class="splitcontentleft">
-        <h4><%=t(:field_vehicles)%>:</h4>
-        <%= render :partial => 'vehicles/list' %>
-        <div style="float: right;">
-          <%= button_to "New Vehicle", new_customer_vehicle_path(@customer), method: :get %>
-        </div>
+        <%= call_hook :show_customer_view_right, {customer: @customer} %>
      </div>
    </div>

@@ -51,7 +47,7 @@

 <br/>
 <h3><%=@issues.open.count%> <%=t(:label_open_issues)%> - <%=@hours.round(1)%> <%=t(:label_hours)%></h3>
-<%= render :partial => 'issues/list_simple', locals: {issues: @issues.open} %>
+<%= render partial: 'issues/list_simple', locals: {issues: @issues.open} %>

 <h3><%=@closed_issues.count%> <%=t(:label_closed_issues)%> - <%= @closed_hours.round(1)%> <%=t(:label_hours)%></h3>
-<%= render :partial => 'issues/list_simple', locals: {issues: @closed_issues} %>
+<%= render partial: 'issues/list_simple', locals: {issues: @closed_issues} %>
--- a/app/views/customers/view.html.erb
+++ b/app/views/customers/view.html.erb
@@ -4,7 +4,7 @@

 <div class="<%= @issue.css_classes %> details">

-<%= avatar(@issue.author, :size => "50") %>
+<%= avatar(@issue.author, size: "50") %>

 <div class="subject">
 <%= render_issue_subject_with_tree(@issue) %>
@@ -19,39 +19,39 @@

 <div class="attributes">
 <%= issue_fields_rows do |rows|
-  rows.left l(:field_status), @issue.status.name, :class => 'status'
-  rows.left l(:field_priority), @issue.priority.name, :class => 'priority'
-  unless @issue.disabled_core_fields.include?('assigned_to_id')
-    rows.left l(:field_assigned_to), avatar(@issue.assigned_to, :size => "14").to_s.html_safe + (@issue.assigned_to ? @issue.assigned_to : "-"), :class => 'assigned-to'
+  rows.left l(:field_status), @issue.status.name, class: :status
+  rows.left l(:field_priority), @issue.priority.name, class: :priority
+  # unless @issue.disabled_core_fields.include?(:assigned_to_id)
+  #   rows.left l(:field_assigned_to), avatar(@issue.assigned_to, size: "14").to_s.html_safe + (@issue.assigned_to ? @issue.assigned_to : "-"), class: 'assigned-to'
+  # end
+  unless @issue.disabled_core_fields.include?(:category_id) || (@issue.category.nil? && @issue.project.issue_categories.none?)
+    rows.left l(:field_category), (@issue.category ? @issue.category.name : "-"), class: :category
  end
-  unless @issue.disabled_core_fields.include?('category_id') || (@issue.category.nil? && @issue.project.issue_categories.none?)
-    rows.left l(:field_category), (@issue.category ? @issue.category.name : "-"), :class => 'category'
+  unless @issue.disabled_core_fields.include?(:fixed_version_id) || (@issue.fixed_version.nil? && @issue.assignable_versions.none?)
+    rows.left l(:field_fixed_version), (@issue.fixed_version ? @issue.fixed_version : "-"), class: 'fixed-version'
  end
-  unless @issue.disabled_core_fields.include?('fixed_version_id') || (@issue.fixed_version.nil? && @issue.assignable_versions.none?)
-    rows.left l(:field_fixed_version), (@issue.fixed_version ? @issue.fixed_version : "-"), :class => 'fixed-version'
+  unless @issue.disabled_core_fields.include?(:start_date)
+    rows.right l(:field_start_date), format_date(@issue.start_date), class: 'start-date'
  end
-  unless @issue.disabled_core_fields.include?('start_date')
-    rows.right l(:field_start_date), format_date(@issue.start_date), :class => 'start-date'
+  unless @issue.disabled_core_fields.include?(:due_date)
+    rows.right l(:field_due_date), format_date(@issue.due_date), class: 'due-date'
  end
-  unless @issue.disabled_core_fields.include?('due_date')
-    rows.right l(:field_due_date), format_date(@issue.due_date), :class => 'due-date'
+  unless @issue.disabled_core_fields.include?(:done_ratio)
+    rows.right l(:field_done_ratio), progress_bar(@issue.done_ratio, legend: "#{@issue.done_ratio}%"), class: :progress
  end
-  unless @issue.disabled_core_fields.include?('done_ratio')
-    rows.right l(:field_done_ratio), progress_bar(@issue.done_ratio, :legend => "#{@issue.done_ratio}%"), :class => 'progress'
-  end
-  unless @issue.disabled_core_fields.include?('estimated_hours')
+  unless @issue.disabled_core_fields.include?(:estimated_hours)
    if @issue.estimated_hours.present? || @issue.total_estimated_hours.to_f > 0
-      rows.right l(:field_estimated_hours), issue_estimated_hours_details(@issue), :class => 'estimated-hours'
+      rows.right l(:field_estimated_hours), issue_estimated_hours_details(@issue), class: 'estimated-hours'
    end
  end
  #if User.current.allowed_to_view_all_time_entries?(@project)
    if @issue.total_spent_hours > 0
-      rows.right l(:label_spent_time), issue_spent_hours_details(@issue), :class => 'spent-time'
+      rows.right l(:label_spent_time), issue_spent_hours_details(@issue), class: 'spent-time'
    end
  #end
 end %>
 <%= render_full_width_custom_fields_rows(@issue) %>
-<%= call_hook(:view_issues_show_details_bottom, :issue => @issue) %>
+<%= call_hook(:view_issues_show_details_bottom, issue: @issue) %>
 </div>

 <% if @issue.description? || @issue.attachments.any? -%>
@@ -59,19 +59,19 @@ end %>
 <% if @issue.description? %>
 <div class="description">
  <div class="contextual">
-  <%= link_to l(:button_quote), quoted_issue_path(@issue), :remote => true, :method => 'post', :class => 'icon icon-comment' if @issue.notes_addable? %>
+  <%= link_to l(:button_quote), quoted_issue_path(@issue), remote: true, method: :post, class: 'icon icon-comment' if @issue.notes_addable? %>
  </div>

  <p><strong><%=l(:field_description)%></strong></p>
  <div class="wiki">
-  <%= textilizable @issue, :description, :attachments => @issue.attachments %>
+  <%= textilizable @issue, :description, attachments: @issue.attachments %>
  </div>
 </div>
 <% end %>
-<%= link_to_attachments @issue, :thumbnails => true %>
+<%= link_to_attachments @issue, thumbnails: true %>
 <% end -%>

-<%= call_hook(:view_issues_show_description_bottom, :issue => @issue) %>
+<%= call_hook(:view_issues_show_description_bottom, issue: @issue) %>

 <% if !@issue.leaf? || User.current.allowed_to?(:manage_subtasks, @project) %>
 <hr />
@@ -87,7 +87,7 @@ end %>
 <% if @relations.present? || User.current.allowed_to?(:manage_issue_relations, @project) %>
 <hr />
 <div id="relations">
-<%= render :partial => 'issues/relations' %>
+<%= render partial: 'issues/relations' %>
 </div>
 <% end %>

@@ -96,14 +96,14 @@ end %>
 <% if @changesets.present? %>
 <div id="issue-changesets">
 <h3><%=l(:label_associated_revisions)%></h3>
-<%= render :partial => 'issues/changesets', :locals => { :changesets => @changesets} %>
+<%= render partial: 'issues/changesets', locals: { changesets: @changesets} %>
 </div>
 <% end %>

 <% if @journals.present? %>
 <div id="history">
 <h3><%=l(:label_history)%></h3>
-<%= render :partial => 'issues/history', :locals => { :issue => @issue, :journals => @journals } %>
+<%= render partial: 'issues/history', locals: { issue: @issue, journals: @journals } %>
 </div>
 <% end %>

--- a/app/views/estimates/_list.html.erb
+++ b/app/views/estimates/_list.html.erb
@@ -1,6 +1,6 @@
-<% if @customer.present? %>
+<% unless estimates.empty? %>

-  <% @customer.estimates.order(id: :desc).each do |estimate| %>
+  <% estimates.sort.reverse.each do |estimate| %>
    <div class="row">
      <b><%= link_to "##{estimate.doc_number}", estimate_path(estimate), target: :_blank %></b> <%= estimate.txn_date %>
    </div>
--- a/app/views/estimates/_search.html.erb
+++ b/app/views/estimates/_search.html.erb
@@ -1,4 +1,4 @@
-<%= form_tag(estimate_doc_path, :method => "get") do %>
-    <%= text_field_tag :search, params[:search], placeholder: t(:label_search_estimates), :autocomplete => "off" %>
-    <%= submit_tag t(:label_search), :formtarget => "_blank" %>
+<%= form_tag(estimate_doc_path, method: "get") do %>
+    <%= text_field_tag :search, params[:search], placeholder: t(:label_search_estimates), autocomplete: "off" %>
+    <%= submit_tag t(:label_search), formtarget: "_blank" %>
 <% end %>
--- a/app/views/estimates/_sidebar.html.erb
+++ b/app/views/estimates/_sidebar.html.erb
@@ -1,2 +1,2 @@
 <h3><%=t(:label_estimates) %></h3>
-<%= render :partial => 'estimates/search' %>
+<%= render partial: 'estimates/search' %>
--- a/app/views/invoices/_list.html.erb
+++ b/app/views/invoices/_list.html.erb
@@ -1,23 +1,26 @@
-<% if @customer.present? %>
+<% unless invoices.empty? %>

  <%= form_with(url: invoice_path, method: :get) do |form| %>

+    <% if invoices.count > 1 %>
      <div class="form-check">
        <%= check_box_tag "select-all-invoices", "1", false, id: "select-all-invoices" %>
        <%= label_tag "select-all-invoices", t(:label_select_all) %>
      </div>
-
      <hr>
+    <% end %>

-    <% @customer.invoices.order(id: :desc).each do |invoice| %>
+    <% invoices.sort.reverse.each do |invoice| %>
      <div class="row">
        <%= check_box_tag "invoice_ids[]", invoice.id, false, class: "invoice-checkbox"  %>
        <b><%= link_to "##{invoice.doc_number}", invoice_path(invoice), target: :_blank %></b> <%= invoice.txn_date %>
      </div>
    <% end %>

+    <% if invoices.count > 1 %>
      <%= form.submit t(:button_bulk_pdf) %>
    <% end %>
+  <% end %>

 <% else %>
  <p><%=t(:label_no_invoices)%>.</p>
--- a/app/views/issues/_form_hook.html.erb
+++ b/app/views/issues/_form_hook.html.erb
@@ -2,13 +2,8 @@
    <label for="issue_customer"><%= t(:customer) %></label>
    <%= search_customer %> 
    <%= customer_id %> 
-    <%= link_to t(:label_load_customer), '#', onclick: "#{js_link}; return false;" %>
 </p> 

 <p>
    <%= select_estimate %>
 </p> 
-
-<p>
-    <%= vehicle %>
-</p>
--- a/app/views/issues/_history.html.erb
+++ b/app/views/issues/_history.html.erb
@@ -3,12 +3,12 @@
  <div id="change-<%= journal.id %>" class="<%= journal.css_classes %>">
    <div id="note-<%= journal.indice %>">
    <div class="contextual">
-      <span class="journal-actions"><%= render_journal_actions(issue, journal, :reply_links => reply_links) %></span>
+      <span class="journal-actions"><%= render_journal_actions(issue, journal, reply_links: reply_links) %></span>
      <a href="#note-<%= journal.indice %>" class="journal-link">#<%= journal.indice %></a>
    </div>
    <h4>
-      <%= avatar(journal.user, :size => "24") %>
-      <%= authoring journal.created_on, journal.user, :label => :label_updated_time_by %>
+      <%= avatar(journal.user, size: "24") %>
+      <%= authoring journal.created_on, journal.user, label: :label_updated_time_by %>
      <%= render_private_notes_indicator(journal) %>
    </h4>

@@ -26,10 +26,10 @@
      </div>
    <% end %>
    <% end %>
-    <%= render_notes(issue, journal, :reply_links => reply_links) unless journal.notes.blank? %>
+    <%= render_notes(issue, journal, reply_links: reply_links) unless journal.notes.blank? %>
    </div>
  </div>
-  <%= call_hook(:view_issues_history_journal_bottom, { :journal => journal }) %>
+  <%= call_hook(:view_issues_history_journal_bottom, { journal: journal }) %>
 <% end %>

 <% heads_for_wiki_formatter if User.current.allowed_to?(:edit_issue_notes, issue.project) || User.current.allowed_to?(:edit_own_issue_notes, issue.project) %>
--- a/app/views/issues/_list_simple.html.erb
+++ b/app/views/issues/_list_simple.html.erb
@@ -9,9 +9,9 @@
    </tr></thead>
    <tbody>
    <% for issue in issues %>
-    <tr id="issue-<%= h(issue.id) %>" class="hascontextmenu <%= cycle('odd', 'even') %> <%= issue.css_classes %>">
+    <tr id="issue-<%= h(issue.id) %>" class="hascontextmenu <%= cycle(:odd, :even) %> <%= issue.css_classes %>">
      <td class="id">
-        <%= check_box_tag("ids[]", issue.id, false, :style => 'display:none;', :id => nil) %>
+        <%= check_box_tag("ids[]", issue.id, false, style: 'display:none;', id: nil) %>
        <%= link_to(issue.id, issue_path(issue)) %>
      </td>
      <td class="project"><%= link_to_project(issue.project) %></td>
--- a/app/views/issues/_show_details.html.erb
+++ b/app/views/issues/_show_details.html.erb
@@ -17,23 +17,6 @@
   </div>
      
  <div class="splitcontentleft">
-    <div class="vehicle attribute">
-      <div class="label"><span><%=t(:field_vehicle)%></span>:</div>
-      <div class="value"><%= vehicle %></div>
-    </div>
-       
-    <div class="vehicle_vin attribute">
-      <div class="label"><span><%=t(:field_vin)%></span>:</div>
-      <div class="value"><%=split_vin[0] if split_vin%><b><%=split_vin[1] if split_vin%></b></div>
-    </div>
-       
-    <div class="vehicle_notes attribute">
-      <div class="label"><span><%=t(:field_notes)%></span>:</div>
-      <div class="value">
-        <pre id="note-display" style="text-align: left; white-space: pre-wrap; font-family: inherit; ">
-          <%=notes%>
-        </pre>
-      </div>
-    </div>
+    <%= call_hook :show_issue_view_right, {issue: issue} %>
  </div>
 </div>
--- a/app/views/qbo/_settings.html.erb
+++ b/app/views/qbo/_settings.html.erb
@@ -60,7 +60,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
    <tr>
      <th><%=t(:label_sandbox)%></th>
      <td>
-        <%= check_box_tag 'settings[sandbox]', @settings['sandbox'], @settings['sandbox'] %>
+        <%= check_box_tag 'settings[sandbox]', @settings[:sandbox], @settings[:sandbox] %>
      </td>
    </tr>

--- a/app/views/qbo/_sidebar.html.erb
+++ b/app/views/qbo/_sidebar.html.erb
@@ -1,6 +1,6 @@
 <% if User.current.logged? %>

-    <%= render :partial => 'customers/sidebar' %>
-    <%= render :partial => 'estimates/sidebar' %>
+    <%= render partial: 'customers/sidebar' %>
+    <%= render partial: 'estimates/sidebar' %>

 <% end %>
--- a/app/views/qbo/_stats.html.erb
+++ b/app/views/qbo/_stats.html.erb
@@ -1 +1 @@
-<%= Customer.count %> <%=t(:field_customers)%> - <%= render :partial => 'qbo/last_sync' %>
+<%= Customer.count %> <%=t(:field_customers)%> - <%= render partial: 'qbo/last_sync' %>
--- a/app/views/vehicles/_details.html.erb
+++ b/app/views/vehicles/_details.html.erb
@@ -1,53 +0,0 @@
-<div class="issue">
-  <div class="splitcontent">
-    <div class="splitcontentleft">
-      <h4><%=t(:label_details)%>:</h4>
-      
-      <table>
-        <tbody>
-
-          <tr>
-            <th><%= t(:field_customer)%></th>
-            <td><%= link_to vehicle.customer.name, customer_path(vehicle.customer) %></td>
-          </tr>
-        
-          <tr>
-            <th><%= t(:field_vehicle) %></th>
-            <td><%= vehicle.to_s %></td>
-          </tr>
-          
-          <tr>
-            <th><%= t(:field_vin) %></th>
-            <td><%= @vin[0] if @vin %><b><%=@vin[1] if @vin%></b></td>
-          </tr>
-          
-          <th><%= t(:label_trim) %></th>
-            <td><%= vehicle.doors %> <%=t(:label_door) if vehicle.doors? %> <%= vehicle.trim %></td>
-          </tr>
-        </tbody>
-      </table>
-      
-    </div>
-
-    <div class="splitcontentleft">
-
-      <h4><%=t(:field_notes)%>:</h4>
-        <pre id="note-display" style="text-align: left; white-space: pre-wrap; font-family: inherit; ">
-          <td><%= vehicle.notes %></td>
-        </pre>
-      </tr>
-
-      <script>
-        const preElement = document.getElementById('note-display');
-        // This takes the text, trims the edges, and puts it back
-        preElement.textContent = preElement.textContent.trim();
-      </script>
-
-    </div>
-  </div>
-</div>
-
-<div style="float: right;">
-  <%= button_to t(:label_edit), edit_vehicle_path(vehicle), method: :get%> 
-  <%= button_to t(:label_delete), vehicle, method: :delete, data: {confirm: t(:warn_ru_sure)} %> 
-</div>
--- a/app/views/vehicles/_form.html.erb
+++ b/app/views/vehicles/_form.html.erb
@@ -1,56 +0,0 @@
-<div class="row">
-  <div class="span6 columns">
-    <fieldset>
-
-      <%= form_for @vehicle do |f| %> 
-        <div class="clearfix">
-          <%=t(:field_customer)%>:
-          <div class="input">
-            <%= f.autocomplete_field :customer, autocomplete_customer_name_customers_path, :value => @customer.name, :update_elements => {:id => '#customer_id', :value => '#issue_customer'}, :required => true %>
-            <%= f.hidden_field :customer_id, :id => "customer_id", :value => @customer.id %>
-          </div>
-        </div>
-        
-        <div class="clearfix">
-          <%=t(:label_year)%>: 
-          <div class="input">
-            <%= f.number_field :year, :autocomplete => "off"  %>
-          </div>
-        </div>
-        
-        <div class="clearfix">
-          <%=t(:label_make)%>:
-          <div class="input">
-            <%= f.text_field :make, :autocomplete => "off"  %>
-          </div>
-        </div>
-        
-        <div class="clearfix">
-          <%=t(:label_model)%>:
-          <div class="input">
-            <%= f.text_field :model, :autocomplete => "off"  %>
-          </div>
-        </div>
-        
-        <div class="clearfix">
-          <%=t(:field_vin)%>:
-          <div class="input">
-            <%= f.text_field :vin , :autofocus => true %>
-          </div>
-        </div>
-        
-        <div class="clearfix">
-          <%=t(:field_notes)%>: 
-          <div class="input">
-            <%= f.text_area :notes, :cols => 60, :rows => 10, :no_label => true %>
-          </div>
-        </div>
-        
-       <div class="actions">
-        <%= f.submit %>
-       </div>
-      <% end %>
-
-    </fieldset>
-  </div>
-</div>
--- a/app/views/vehicles/_list.html.erb
+++ b/app/views/vehicles/_list.html.erb
@@ -1,28 +0,0 @@
-<% if @vehicles.present? %>
-
-  <% @vehicles.each do |vehicle| %>
-    <div class="row">
-      <div>
-        <b><%= link_to "##{vehicle.id}", vehicle_path(vehicle) %> </b>
-      </div>
-      
-      <div>
-        <%= vehicle.to_s %>
-        <br/>
-        <%= vehicle.customer %>
-        <br/>
-        <%= vehicle.vin.scan(/.{1,9}/)[0] if vehicle.vin %><b><%=vehicle.vin.scan(/.{1,9}/)[1] if vehicle.vin%></b>
-      </div>
-    </div>
-    <br/>
-  <% end %>
-
-  <div class="actions">
-    <%= will_paginate @vehicles %>
-  </div>
-
-<p><%=t(:label_matching)%> <%=@vehicles.count%> <%=t(:field_vehicles) %> </p>
-
-<% else %>
-  <p><%=t(:label_no_vehicles)%> <%= params[:search] %>.</p>
-<% end %>
--- a/app/views/vehicles/_search.html.erb
+++ b/app/views/vehicles/_search.html.erb
@@ -1,4 +0,0 @@
-<%= form_tag(vehicles_path, :method => "get", id: "search-form") do %>
-  <%= text_field_tag :search, params[:search], placeholder: t(:label_search_vin), :autocomplete => "off" %>
-  <%= submit_tag t(:label_search) %>
-<% end %>
--- a/app/views/vehicles/_vehicle.html.erb
+++ b/app/views/vehicles/_vehicle.html.erb
@@ -1 +0,0 @@
-<option value="<%= vehicle.id %>"><%= vehicle.to_s.titleize %></option>
--- a/app/views/vehicles/edit.html.erb
+++ b/app/views/vehicles/edit.html.erb
@@ -1,3 +0,0 @@
-<h1><%=t(:label_edit_customer_vehicle)%></h1> 
-<br/> 
-<%= render :partial => 'vehicles/form' %>
--- a/app/views/vehicles/index.html.erb
+++ b/app/views/vehicles/index.html.erb
@@ -1,4 +0,0 @@
-<h2><%=t(:label_cusomer_vehicles)%> <span style="float:right"> <%= render :partial => 'vehicles/search' %> </span> </h2> 
-<br/> 
-
-<%= render :partial => 'vehicles/list' %>
--- a/app/views/vehicles/new.html.erb
+++ b/app/views/vehicles/new.html.erb
@@ -1,3 +0,0 @@
-<h2><%=t(:label_new_vehicle)%></h2> 
-<br/> 
-<%= render :partial => 'vehicles/form' %>
--- a/app/views/vehicles/show.html.erb
+++ b/app/views/vehicles/show.html.erb
@@ -1,11 +0,0 @@
-<h2><%=t(:field_vehicle)%> #<%=@vehicle.id%></h2>
-
-<%= render :partial => 'vehicles/details', locals: {vehicle: @vehicle} %>
-
-<h3><%=@issues.open.count%> <%=t(:label_open_issues)%></h3>
-
-<%= render :partial => 'issues/list_simple', locals: {issues: @issues.open} %>
-
-<h3><%=@closed_issues.count%> <%=t(:label_closed_issues)%></h3>
-
-<%= render :partial => 'issues/list_simple', locals: {issues: (@closed_issues)} %>
--- a/assets/images/.gitkeep
+++ b/assets/images/.gitkeep
--- a/assets/javascripts/.gitkeep
+++ b/assets/javascripts/.gitkeep
--- a/assets/javascripts/application.js
+++ b/assets/javascripts/application.js
@@ -1,10 +1,5 @@
 $(function() {
  $("input#issue_customer_id").on("change", function() {
-    $.ajax({
-      url: "/filter_vehicles_by_customer",
-      type: "GET",
-      data: { selected_customer: $("input#issue_customer_id").val() }
-    });
    
    $.ajax({
      url: "/filter_estimates_by_customer",
@@ -13,11 +8,4 @@ $(function() {
    });
  });
    
-  $("input#project_customer_id").on("change", function() {
-    $.ajax({
-      url: "/filter_vehicles_by_customer",
-      type: "GET",
-      data: { selected_customer: $("input#project_customer_id").val() }
-    });
-  });
 });
--- a/assets/stylesheets/.gitkeep
+++ b/assets/stylesheets/.gitkeep
--- a/config/initializers/.gitkeep
+++ b/config/initializers/.gitkeep
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -12,13 +12,9 @@
 # Usage I18n.t(:label)
 en:
  field_customer: "Customer"
-  field_item: "Item"
  field_employee: "Employee"
  field_invoice: "Invoice"
  field_estimate: "Estimate" 
-  field_vehicles: "Vehicles"
-  field_vehicle: "Vehicle"
-  field_vin: "VIN"
  field_notes: "Notes"
  field_billed: "Billed"
  label_week: "Week"
@@ -31,13 +27,8 @@ en:
  label_year: "Year"
  label_make: " Make"
  label_model: "Model"
-  label_no_vehicles: "There are no vehicles containing the term(s)"
  label_no_customers: "There are no customers containing the term(s)"
  label_matching: "Matching "
-  label_search_vin: "Search Vehicles by VIN"
-  label_edit_customer_vehicle: "Edit Customer Vehicle"
-  label_cusomer_vehicles: "Customer Vehicles"
-  label_new_vehicle: "New Customer Vehicle"
  label_open_issues: "Open Issues"
  label_closed_issues: "Closed Issues"
  label_sync: "Sync"
@@ -62,7 +53,6 @@ en:
  label_customer_count: "Customer Count"
  label_invoice_count: "Invoice Count"
  label_estimate_count: "Estimate Count"
-  label_item_count: "Item Count"
  label_employee_count: "Employee Count"
  label_client_id: "Intuit QBO OAuth2 Client ID"
  label_client_secret: "Intuit QBO OAuth2 Client Secret"
@@ -96,3 +86,17 @@ en:
  label_sandbox: "Sandbox"
  button_bulk_pdf: "Bulk PDF"
  label_select_all: "Select All"
+  notice_customer_created: "Customer created in Quickbooks"
+  notice_customer_updated: "Customer updated in Quickbooks"
+  notice_customer_not_found: "Customer not found in Quickbooks"
+  notice_customer_not_deleted: "Customer could not be deleted in Quickbooks"
+  notice_customer_deleted: "Customer deleted in Quickbooks"
+  notice_estimate_created: "Estimate created in Quickbooks"
+  notice_estimate_updated: "Estimate updated in Quickbooks"
+  notice_estimate_not_found: "Estimate not found"
+  notice_invoice_created: "Invoice created in Quickbooks"
+  notice_invoice_updated: "Invoice updated in Quickbooks"
+  notice_invoice_not_found: "Invoice not found"
+  notice_forbidden: "You do not have permission to access this resource"
+  notice_issue_not_found: "Issue not found"
+  customer_details: "Customer Details"
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -9,37 +9,31 @@
 #THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

 #authentication
-get 'qbo/authenticate', :to => 'qbo#authenticate'
-get 'qbo/oauth_callback', :to => 'qbo#oauth_callback'
+get 'qbo/authenticate', to: 'qbo#authenticate'
+get 'qbo/oauth_callback', to: 'qbo#oauth_callback'

 #manual sync
-get 'qbo/sync', :to => 'qbo#sync'
+get 'qbo/sync', to: 'qbo#sync'

 #webhook
-post 'qbo/webhook', :to => 'qbo#webhook'
+post 'qbo/webhook', to: 'qbo#webhook'

 # Estimate & Invoice PDF
-get 'estimates/:id', :to => 'estimate#show', as: :estimate
-get 'estimates/doc/', :to => 'estimate#doc', as: :estimate_doc
-get 'invoices/:id', :to => 'invoice#show', as: :invoice
+get 'estimates/:id', to: 'estimate#show', as: :estimate
+get 'estimates/doc/', to: 'estimate#doc', as: :estimate_doc
+get 'invoices/:id', to: 'invoice#show', as: :invoice

 #manual billing
-get 'bill/:id', :to => 'qbo#bill', as: :bill
+get 'bill/:id', to: 'qbo#bill', as: :bill

 #customer issue view
-get 'customers/view/:token', :to => 'customers#view', as: :view
-get 'customers/share/:id', :to => 'customers#share', as: :share
+get 'customers/view/:token', to: 'customers#view', as: :view
+get 'customers/share/:id', to: 'customers#share', as: :share

 #java script routes
-get 'filter_vehicles_by_customer' => 'customers#filter_vehicles_by_customer'
 get 'filter_estimates_by_customer' => 'customers#filter_estimates_by_customer'
 get 'filter_invoices_by_customer' => 'customers#filter_invoices_by_customer'

-# Nest Vehicles under customers
 resources :customers do
-  resources :vehicles
-  get :autocomplete_customer_name, :on => :collection
+  get :autocomplete_customer_name, on: :collection
 end
-
-#allow for just vehicles too
-resources :vehicles
--- a/db/migrate/002_create_qbo_customers.rb
+++ b/db/migrate/002_create_qbo_customers.rb
@@ -11,7 +11,7 @@
 class CreateQboCustomers < ActiveRecord::Migration[5.1]
  def change
    create_table :qbo_customers, id: false do |t|
-      t.integer :id, :options => 'PRIMARY KEY'
+      t.integer :id, options: 'PRIMARY KEY'
      t.string :name
    end
  end
--- a/db/migrate/004_create_qbo_items.rb
+++ b/db/migrate/004_create_qbo_items.rb
@@ -11,7 +11,7 @@
 class CreateQboItems < ActiveRecord::Migration[5.1]
  def change
    create_table :qbo_items, id: false do |t|
-      t.integer :id, :options => 'PRIMARY KEY'
+      t.integer :id, options: 'PRIMARY KEY'
      t.string :name
    end
  end
--- a/db/migrate/005_create_qbo_employees.rb
+++ b/db/migrate/005_create_qbo_employees.rb
@@ -11,7 +11,7 @@
 class CreateQboEmployees < ActiveRecord::Migration[5.1]
  def change
    create_table :qbo_employees, id: false do |t|
-      t.integer :id, :options => 'PRIMARY KEY'
+      t.integer :id, options: 'PRIMARY KEY'
      t.string :name
    end
  end
--- a/db/migrate/007_update_time_entries.rb
+++ b/db/migrate/007_update_time_entries.rb
@@ -10,6 +10,6 @@

 class UpdateTimeEntries < ActiveRecord::Migration[5.1]
  def change
-    add_column :time_entries, :qbo_billed, :boolean, :default => false
+    add_column :time_entries, :qbo_billed, :boolean, default: false
  end
 end
--- a/db/migrate/008_create_qbo_estimates.rb
+++ b/db/migrate/008_create_qbo_estimates.rb
@@ -11,7 +11,7 @@
 class CreateQboEstimates < ActiveRecord::Migration[5.1]
  def change
    create_table :qbo_estimates, id: false do |t|
-      t.integer :id, :options => 'PRIMARY KEY'
+      t.integer :id, options: 'PRIMARY KEY'
      t.string :doc_number
    end
  end
--- a/db/migrate/011_create_qbo_invoices.rb
+++ b/db/migrate/011_create_qbo_invoices.rb
@@ -11,7 +11,7 @@
 class CreateQboInvoices < ActiveRecord::Migration[5.1]
  def change
    create_table :qbo_invoices, id: false do |t|
-      t.integer :id, :options => 'PRIMARY KEY'
+      t.integer :id, options: 'PRIMARY KEY'
      t.string :doc_number
    end
  end
--- a/db/migrate/013_create_qbo_purchases.rb
+++ b/db/migrate/013_create_qbo_purchases.rb
@@ -11,7 +11,7 @@
 class CreateQboPurchases< ActiveRecord::Migration[5.1]
  def change
    create_table :qbo_purchases, id: false do |t| 
-      t.integer :id, :options => 'PRIMARY KEY' 
+      t.integer :id, options: 'PRIMARY KEY' 
      t.integer :line_id
      t.string :description
      t.integer :customer_id
--- a/db/migrate/016_create_vehicles.rb
+++ b/db/migrate/016_create_vehicles.rb
@@ -1,24 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class CreateVehicles < ActiveRecord::Migration[5.1]
-  
-  def change  
-    create_table :vehicles do |t| 
-      t.integer :year
-      t.string  :make
-      t.string  :model
-      t.string  :vin
-      t.text    :notes
-    end
-    
-    add_reference :vehicles, :qbo_customer, index: true
-  end
-end
--- a/db/migrate/017_update_issues_with_vehicles.rb
+++ b/db/migrate/017_update_issues_with_vehicles.rb
@@ -1,15 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class UpdateIssuesWithVehicles < ActiveRecord::Migration[5.1]
-  def change
-    add_reference :issues, :vehicles, index: true
-  end
-end
--- a/db/migrate/018_update_vehicles.rb
+++ b/db/migrate/018_update_vehicles.rb
@@ -1,15 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class UpdateVehicles < ActiveRecord::Migration[5.1]
-  def change
-    add_column :vehicles, :name, :text
-  end
-end
--- a/db/migrate/019_qbocustomers_to_customers.rb
+++ b/db/migrate/019_qbocustomers_to_customers.rb
@@ -12,6 +12,5 @@ class QbocustomersToCustomers< ActiveRecord::Migration[5.1]
  def change
    rename_table :qbo_customers, :customers
    rename_column :issues, :qbo_customer_id, :customer_id
-    rename_column :vehicles, :qbo_customer_id, :customer_id
  end 
 end
--- a/db/migrate/021_add_issues_qbo_invoices.rb
+++ b/db/migrate/021_add_issues_qbo_invoices.rb
@@ -10,12 +10,12 @@

 class AddIssuesQboInvoices < ActiveRecord::Migration[5.1]
  def self.up
-    create_table :issues_qbo_invoices, :id => false do |t|
+    create_table :issues_qbo_invoices, id: false do |t|
      t.references :issue
      t.references :qbo_invoice
    end
    
-    add_index :issues_qbo_invoices, [:issue_id, :qbo_invoice_id], :unique => true
+    add_index :issues_qbo_invoices, [:issue_id, :qbo_invoice_id], unique: true
    
    # Now populate it with a SQL one-liner!
    execute "insert into issues_qbo_invoices(issue_id, qbo_invoice_id) select id, qbo_invoice_id from issues"
--- a/db/migrate/025_update_projects.rb
+++ b/db/migrate/025_update_projects.rb
@@ -1,16 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class UpdateProjects < ActiveRecord::Migration[5.1]
-  def change
-    add_reference :projects, :customer, index: true
-    add_reference :projects, :vehicle, index: true
-  end
-end
--- a/db/migrate/032_add_txn_dates.rb
+++ b/db/migrate/032_add_txn_dates.rb
@@ -30,7 +30,7 @@ class AddTxnDates < ActiveRecord::Migration[5.1]

          qbo = Qbo.first
          invoices = qbo.perform_authenticated_request do |access_token|
-            service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
+            service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
            service.all
          end

--- a/db/migrate/033_update_vehicles_trim.rb
+++ b/db/migrate/033_update_vehicles_trim.rb
@@ -1,33 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-class UpdateVehiclesTrim < ActiveRecord::Migration[5.1]
-  def change
-    begin
-      add_column :vehicles, :doors, :text
-      add_column :vehicles, :trim, :text
-
-      reversible do |direction|
-        direction.up {
-
-          # Update local vehicle database by forcing a save, look at before_save
-          vehicles = Vehicle.all
-          vehicles.each { |vehicle|
-              vehicle.save!
-          }
-      }
-      end
-    rescue
-      logger.error "Failed to update vehicles"
-    end
-
-  end
-
-end
--- a/init.rb
+++ b/init.rb
@@ -11,37 +11,31 @@
 Redmine::Plugin.register :redmine_qbo do
  
  # About
-  name 'Redmine Quickbooks Online plugin'
+  name 'Redmine QBO plugin'
  author 'Rick Barrette'
  description 'This is a plugin for Redmine to intergrate with Quickbooks Online to allow for seamless intergration CRM and invoicing of completed issues'
-  version '2026.1.0'
+  version '2026.1.9'
  url 'https://github.com/rickbarrette/redmine_qbo'
  author_url 'https://barrettefabrication.com'
-  settings :default => {'empty' => true}, :partial => 'qbo/settings'
-  requires_redmine :version_or_higher => '6.1.0'
+  settings default: {empty: true}, partial: 'qbo/settings'
+  requires_redmine version_or_higher: '6.1.0'
  
  # Add safe attributes for core models
-  Issue.safe_attributes 'customer_id'
-  Issue.safe_attributes 'item_id'
-  Issue.safe_attributes 'estimate_id'
-  Issue.safe_attributes 'invoice_id'
-  Issue.safe_attributes 'vehicles_id'
-  User.safe_attributes 'employee_id'
-  TimeEntry.safe_attributes 'billed'
-  Project.safe_attributes 'customer_id'
-  Project.safe_attributes 'vehicle_id'
+  Issue.safe_attributes :customer_id
+  Issue.safe_attributes :estimate_id
+  Issue.safe_attributes :invoice_id
+  User.safe_attributes :employee_id
+  TimeEntry.safe_attributes :billed
  
  # set per_page globally
  WillPaginate.per_page = 20

  # Permissions for security
-  permission :view_customers, :customers => :index, :public => false
-  permission :add_customers, :customers => :new, :public => false
-  permission :view_vehicles, :vehicles => :new, :public => false
+  permission :view_customers, customers: :index, public: false
+  permission :add_customers, customers: :new, public: false
  
  # Register top menu items
-  menu :top_menu, :customers, { :controller => :customers, :action => :index }, :caption => 'Customers', :if => Proc.new {User.current.logged?}
-  menu :top_menu, :vehicles, { :controller => :vehicles, :action => :index }, :caption => 'Vehicles', :if => Proc.new { User.current.logged? }
+  menu :top_menu, :customers, { controller: :customers, action: :index }, caption: :label_customers, if: Proc.new {User.current.logged?}
    
 end

--- a/lib/hooks/issues_form_hook_listener.rb
+++ b/lib/hooks/issues_form_hook_listener.rb
@@ -12,71 +12,43 @@ module Hooks

  class IssuesFormHookListener < Redmine::Hook::ViewListener

+   include IssuesHelper
+
    # Edit Issue Form
    # Here we build the required form components before passing them to a partial view formatting. 
    def view_issues_form_details_bottom(context={})
      f = context[:form]
      issue = context[:issue]

-      # check project level customer ownership first
-      # This is done to preload customer information if the entire project is dedicated to a customer
-      if context[:project]
-        selected_customer = context[:project].customer ? context[:project].customer.id : nil
-        selected_vehicle = context[:project].vehicle ? context[:project].vehicle.id : nil
-      end
-
-      # Check to see if the issue already belongs to a customer
-      selected_customer = issue.customer ? issue.customer.id  : nil
-      selected_estimate = issue.estimate ? issue.estimate.id  : nil
-      selected_vehicle = issue.vehicles_id ? issue.vehicles_id : nil
-
-      # Gernerate edit.js link
-      js_link = issue.new_record? ? "updateIssueFrom('/projects/rmt/issues/new.js', this)" : "updateIssueFrom('/issues/#{issue.id}/edit.js', this)"
-
-      # Load customer information
-      customer = Customer.find_by_id(selected_customer) if selected_customer
-
      # Customer Name Text Box with database backed autocomplete
+      # onchange event will update the hidden customer_id field
      search_customer = f.autocomplete_field :customer,
        autocomplete_customer_name_customers_path,
-        :selected => selected_customer,
-        :onchange => js_link,
-        :update_elements => { 
-          :id => '#issue_customer_id', 
-          :value => '#issue_customer' 
+        selected: issue.customer,
+        update_elements: { 
+          id: '#issue_customer_id', 
+          value: '#issue_customer' 
        }

-      # Customer ID - Hidden Field
+      # This hidden field is used for the customer ID for the issue
+      # the onchange event will reload the issue form via ajax to update the available estimates
      customer_id = f.hidden_field :customer_id,
-        :id => "issue_customer_id",
-        :onchange => js_link
+        id: "issue_customer_id",
+        onchange: "updateIssueFrom('#{escape_javascript update_issue_form_path(issue.project, issue)}', this)".html_safe

-      # Load estimates & vehicles
-      if issue.customer
-        if customer.vehicles
-          vehicles = customer.vehicles.pluck(:name, :id)
-        else
-          vehicles = [nil].compact
-        end
-        estimates = customer.estimates.pluck(:doc_number, :id).sort! {|x, y| y <=> x}
-      else
-        vehicles = [nil].compact
-        estimates = [nil].compact
-      end
-
-      # Generate the drop down list of quickbooks estimates & vehicles
-      select_estimate = f.select :estimate_id, estimates, :selected => selected_estimate, include_blank: true
-      vehicle = f.select :vehicles_id, vehicles, :selected => selected_vehicle, include_blank: true
+      # Generate the drop down list of quickbooks estimates owned by the selected customer
+      select_estimate = f.select :estimate_id, 
+        issue.customer ? issue.customer.estimates.pluck(:doc_number, :id).sort! {|x, y| y <=> x} : [], 
+        selected: issue.estimate ? issue.estimate.id : nil, 
+        include_blank: true
      
      # Pass all prebuilt form components to our partial
      context[:controller].send(:render_to_string, {
-        :partial => 'issues/form_hook',
+        partial: 'issues/form_hook',
          locals: {
            search_customer: search_customer, 
            customer_id: customer_id, 
-            js_link: js_link, 
-            select_estimate: select_estimate,
-            vehicle: vehicle
+            select_estimate: select_estimate
          } 
        }
      )
--- a/lib/hooks/issues_save_hook_listener.rb
+++ b/lib/hooks/issues_save_hook_listener.rb
@@ -14,8 +14,11 @@ module Hooks

    # Called Before Issue Saved
    def controller_issues_edit_before_save(context={})
-      issue = context[:issue]
-      issue.subject = issue.subject.titleize
+      return context[:issue].subject = context[:issue].subject.titleize
+    end
+
+    def controller_issues_new_before_save(context={})
+      return context[:issue].subject = context[:issue].subject.titleize
    end

    # Called After Issue Saved
--- a/lib/hooks/issues_show_hook_listener.rb
+++ b/lib/hooks/issues_show_hook_listener.rb
@@ -13,51 +13,25 @@ module Hooks
  class IssuesShowHookListener < Redmine::Hook::ViewListener

    # View Issue
-    # Display the quickbooks contact in the issue
+    # Displays the quickbooks customer, estimate, & invoices attached to the issue
    def view_issues_show_details_bottom(context={})
      issue = context[:issue]
      
-      # Check to see if there is a quickbooks user attached to the issue
-      if issue.customer
-        customer = link_to issue.customer.name, customer_path( issue.customer.id )
-      end
-      
-      # Estimate Number
-      if issue.estimate
-        estimate = issue.estimate.doc_number
-        estimate_link = link_to estimate, estimate_path( issue.estimate.id ), :target => "_blank"
-      end
-      
-      # Invoice Number
+      # Build a list of invoice links
      invoice_link = ""
-      if issue.invoice_ids
-        issue.invoice_ids.each do |i|
-          invoice = Invoice.find i
-          invoice_link = invoice_link + link_to( invoice.doc_number, invoice_path( i ), :target => "_blank").to_s + " "
-          invoice_link = invoice_link.html_safe
+      if issue.invoices
+        issue.invoices.each do |i|
+          invoice_link += "#{link_to i, i, target: :_blank}<br/>"
        end
      end
      
-      begin
-        v = Vehicle.find(issue.vehicles_id)
-        vehicle = link_to v.to_s, vehicle_path( v.id )
-        vin = v.vin 
-        notes = v.notes
-      rescue
-        #do nothing
-      end
-      
-      split_vin = vin.scan(/.{1,9}/) if vin
-
      context[:controller].send(:render_to_string, {
-        :partial => 'issues/show_details',
+        partial: 'issues/show_details',
          locals: {
-            customer: customer, 
-            estimate_link: estimate_link, 
-            invoice_link: invoice_link, 
-            vehicle: vehicle, 
-            split_vin: split_vin,
-            notes: notes
+            customer: issue.customer ? link_to(issue.customer) : nil, 
+            estimate_link: issue.estimate ? link_to(issue.estimate, issue.estimate, target: :_blank) : nil, 
+            invoice_link: invoice_link.html_safe,
+            issue: issue
          } 
        })
    end
--- a/lib/hooks/projects_form_hook_listener.rb
+++ b/lib/hooks/projects_form_hook_listener.rb
@@ -1,40 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-module Hooks
-
-  class ProjectsFormHookListener < Redmine::Hook::ViewListener
-    
-    # Edit Project Form
-    def view_projects_form(context={})
-      f = context[:form]
-  
-      # Check to see if there is a quickbooks user attached to the issue
-      selected_customer = context[:project].customer ? context[:project].customer : nil
-      selected_vehicle = context[:project].vehicle_id ? context[:project].vehicle_id : nil
-      
-      # Load customer information
-      customer = Customer.find_by_id(selected_customer) if selected_customer
-      search_customer = f.autocomplete_field :customer, autocomplete_customer_name_customers_path, :selected => selected_customer, :update_elements => {:id => '#project_customer_id', :value => '#project_customer'}
-      customer_id = f.hidden_field :customer_id, :id => "project_customer_id"
-      
-      if context[:project].customer
-        vehicles = customer.vehicles.pluck(:name, :id).sort!
-      else
-        vehicles = [nil].compact
-      end
-      
-      vehicle = f.select :vehicle_id, vehicles, :selected => selected_vehicle, include_blank: true
-      
-      return "<p><label for=\"project_customer\">Customer</label>#{search_customer} #{customer_id}</p> <p>#{vehicle}</p>"
-    end
-  end
-
-end
--- a/lib/hooks/users_show_hook_listener.rb
+++ b/lib/hooks/users_show_hook_listener.rb
@@ -22,7 +22,7 @@ module Hooks
      @selected = context[:user].employee.id if context[:user].employee

      # Generate the drop down list of quickbooks contacts
-      return "<p>#{context[:form].select :employee_id, Employee.all.pluck(:name, :id), :selected => @selected, include_blank: true}</p>"
+      return "<p>#{context[:form].select :employee_id, Employee.all.pluck(:name, :id), selected: @selected, include_blank: true}</p>"
    end
  end

--- a/lib/hooks/view_hook_listener.rb
+++ b/lib/hooks/view_hook_listener.rb
@@ -12,7 +12,7 @@ module Hooks

  class ViewHookListener < Redmine::Hook::ViewListener

-    render_on :view_layouts_base_sidebar, :partial => "qbo/sidebar"
+    render_on :view_layouts_base_sidebar, partial: "qbo/sidebar"
    
  end

--- a/lib/hooks/view_layouts_hook_listener.rb
+++ b/lib/hooks/view_layouts_hook_listener.rb
@@ -14,9 +14,9 @@ module Hooks

    # Load the javascript to support the autocomplete forms
    def view_layouts_base_html_head(context = {})
-      js = javascript_include_tag 'application.js', :plugin => 'redmine_qbo'
-      js += javascript_include_tag 'autocomplete-rails.js', :plugin => 'redmine_qbo'
-      js += javascript_include_tag 'checkbox_controller.js', :plugin => 'redmine_qbo'
+      js = javascript_include_tag 'application.js', plugin: :redmine_qbo
+      js += javascript_include_tag 'autocomplete-rails.js', plugin: :redmine_qbo
+      js += javascript_include_tag 'checkbox_controller.js', plugin: :redmine_qbo
      return js
    end

--- a/lib/patches/issue_patch.rb
+++ b/lib/patches/issue_patch.rb
@@ -28,7 +28,6 @@ module Patches
        belongs_to :customer_token, primary_key: :id
        belongs_to :estimate, primary_key: :id
        has_and_belongs_to_many :invoices
-        belongs_to :vehicle, primary_key: :id
      end
      
    end
@@ -56,8 +55,8 @@ module Patches
          # Prepare to create a new Time Activity
          qbo = Qbo.first
          qbo.perform_authenticated_request do |access_token|
-            time_service = Quickbooks::Service::TimeActivity.new(:company_id => qbo.realm_id, :access_token => access_token)
-            item_service = Quickbooks::Service::Item.new(:company_id => qbo.realm_id, :access_token => access_token)
+            time_service = Quickbooks::Service::TimeActivity.new(company_id: qbo.realm_id, access_token: access_token)
+            item_service = Quickbooks::Service::Item.new(company_id: qbo.realm_id, access_token: access_token)
            time_entry = Quickbooks::Model::TimeActivity.new
    
            # Lets total up each activity before billing.
--- a/lib/patches/pdf_patch.rb
+++ b/lib/patches/pdf_patch.rb
@@ -54,25 +54,32 @@ module Patches
        left << [l(:field_status), issue.status]
        left << [l(:field_priority), issue.priority]
        left << [l(:field_customer), customer]
-        left << [l(:field_assigned_to), issue.assigned_to] unless issue.disabled_core_fields.include?('assigned_to_id')
-        #left << [l(:field_category), issue.category] unless issue.disabled_core_fields.include?('category_id')
-        #left << [l(:field_fixed_version), issue.fixed_version] unless issue.disabled_core_fields.include?('fixed_version_id')
+        left << [l(:field_assigned_to), issue.assigned_to] unless issue.disabled_core_fields.include?(:assigned_to_id)
+        #left << [l(:field_category), issue.category] unless issue.disabled_core_fields.include?(:category_id)
+        #left << [l(:field_fixed_version), issue.fixed_version] unless issue.disabled_core_fields.include?(:fixed_version_id)
        
-        v = Vehicle.find_by_id(issue.vehicles_id)
-        vehicle = v ? v.to_s : nil
-        vin = v ? v.vin : nil
-        notes = v ? v.notes : nil
-        left << [l(:field_vehicles), vehicle]
-        left << [l(:field_vin), vin ? vin.gsub(/(.{9})/, '\1 ') : nil]
-        #left << [l(:field_notes), notes]
+        logger.debug "Calling :pdf_left hook"
+        left_hook_output = Redmine::Hook.call_hook :pdf_left, { issue: issue }
+        unless left_hook_output.nil?
+          left_hook_output.each do |l|
+            left.concat l unless l.nil?
+          end
+        end

        right = []
-        right << [l(:field_start_date), format_date(issue.start_date)] unless issue.disabled_core_fields.include?('start_date')
-        right << [l(:field_due_date), format_date(issue.due_date)] unless issue.disabled_core_fields.include?('due_date')
-        right << [l(:field_done_ratio), "#{issue.done_ratio}%"] unless issue.disabled_core_fields.include?('done_ratio')
-        right << [l(:field_estimated_hours), l_hours(issue.estimated_hours)] unless issue.disabled_core_fields.include?('estimated_hours')
+        right << [l(:field_start_date), format_date(issue.start_date)] unless issue.disabled_core_fields.include?(:start_date)
+        right << [l(:field_due_date), format_date(issue.due_date)] unless issue.disabled_core_fields.include?(:due_date)
+        right << [l(:field_done_ratio), "#{issue.done_ratio}%"] unless issue.disabled_core_fields.include?(:done_ratio)
+        right << [l(:field_estimated_hours), l_hours(issue.estimated_hours)] unless issue.disabled_core_fields.include?(:estimated_hours)
        right << [l(:label_spent_time), l_hours(issue.total_spent_hours)] if User.current.allowed_to?(:view_time_entries, issue.project)
-        right << [l(:field_notes), notes]
+        
+        logger.debug "Calling :pdf_right hook"
+        right_hook_output = Redmine::Hook.call_hook :pdf_right, { issue: issue }
+        unless right_hook_output.nil?
+          right_hook_output.each do |r|
+            right.concat r unless r.nil?
+          end
+        end

        rows = left.size > right.size ? left.size : right.size
        while left.size < rows
@@ -136,10 +143,10 @@ module Patches
        # Set resize image scale
        pdf.set_image_scale(1.6)
        text = textilizable(issue, :description,
-                            :only_path => false,
-                            :edit_section_links => false,
-                            :headings => false,
-                            :inline_attachments => false
+                            only_path: false,
+                            edit_section_links: false,
+                            headings: false,
+                            inline_attachments: false
        )
        pdf.RDMwriteFormattedCell(35+155, 5, '', '', text, issue.attachments, "LRB")

@@ -226,10 +233,10 @@ module Patches
              pdf.ln unless journal.details.empty?
              pdf.SetFontStyle('',8)
              text = textilizable(journal, :notes,
-                                  :only_path => false,
-                                  :edit_section_links => false,
-                                  :headings => false,
-                                  :inline_attachments => false
+                                  only_path: false,
+                                  edit_section_links: false,
+                                  headings: false,
+                                  inline_attachments: false
              )
              pdf.RDMwriteFormattedCell(190,5,'','', text, issue.attachments, "")
            end
--- a/lib/patches/project_patch.rb
+++ b/lib/patches/project_patch.rb
@@ -1,44 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-require_dependency 'project'
-
-module Patches
-
-  # Patches Redmine's Projects dynamically.
-  # Adds a relationships
-  module ProjectPatch
-
-    def self.included(base) # :nodoc:
-      base.extend(ClassMethods)
-
-      base.send(:include, InstanceMethods)
-
-      # Same as typing in the class 
-      base.class_eval do
-        belongs_to :customer, primary_key: :id
-        belongs_to :vehicle, primary_key: :id
-      end
-    end
-    
-  end
-      
-  module ClassMethods
-      
-  end
-    
-  module InstanceMethods
-  
-  end
-    
-  # Add module to Project
-  Project.send(:include, ProjectPatch)
-
-end
--- a/lib/patches/query_patch.rb
+++ b/lib/patches/query_patch.rb
@@ -18,15 +18,15 @@ module Patches
    def available_columns
      unless @available_columns
        @available_columns = self.class.available_columns.dup
-        @available_columns << QueryColumn.new(:customer, :sortable => "#{Issue.table_name}.customer_id", :groupable => true, :caption => :field_customer)
-        @available_columns << QueryColumn.new(:billed, :sortable => "#{TimeEntry.table_name}.billed", :groupable => true, :caption => :field_billed)
+        @available_columns << QueryColumn.new(:customer, sortable: "#{Issue.table_name}.customer_id", groupable: true, caption: :field_customer)
+        @available_columns << QueryColumn.new(:billed, sortable: "#{TimeEntry.table_name}.billed", groupable: true, caption: :field_billed)
      end
      super
    end
    
    # Add customers to filters
    def initialize_available_filters
-      #add_available_filter "customer", :type => :text
+      #add_available_filter "customer", type: :text
      super
    end

--- a/lib/patches/time_entry_query_patch.rb
+++ b/lib/patches/time_entry_query_patch.rb
@@ -18,14 +18,14 @@ module Patches
    def available_columns
      unless @available_columns
        @available_columns = self.class.available_columns.dup
-        @available_columns << QueryColumn.new(:billed, :sortable => "#{TimeEntry.table_name}.name", :groupable => true, :caption => :field_billed)
+        @available_columns << QueryColumn.new(:billed, sortable: "#{TimeEntry.table_name}.name", groupable: true, caption: :field_billed)
      end
      super
    end
    
    # Add QBO options to the filter
    def initialize_available_filters
-      add_available_filter "billed", :type => :boolean
+      add_available_filter "billed", type: :boolean
      super
    end

--- a/lib/tasks/.gitkeep
+++ b/lib/tasks/.gitkeep
--- a/test/functional/estimate_controller_test.rb
+++ b/test/functional/estimate_controller_test.rb
@@ -1,8 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class EstimateControllerTest < ActionController::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
--- a/test/functional/invoice_controller_test.rb
+++ b/test/functional/invoice_controller_test.rb
@@ -1,8 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class InvoiceControllerTest < ActionController::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
--- a/test/functional/qbo_controller_test.rb
+++ b/test/functional/qbo_controller_test.rb
@@ -1,18 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-require File.expand_path('../../test_helper', __FILE__)
-
-class QboControllerTest < ActionController::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
--- a/test/integration/.gitkeep
+++ b/test/integration/.gitkeep
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -1,2 +0,0 @@
-# Load the Redmine helper
-require File.expand_path(File.dirname(__FILE__) + '/../../../test/test_helper')
--- a/test/unit/customer_token_test.rb
+++ b/test/unit/customer_token_test.rb
@@ -1,9 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class CustomerTokenTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
--- a/test/unit/qbo_customers_test.rb
+++ b/test/unit/qbo_customers_test.rb
@@ -1,19 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-require File.expand_path('../../test_helper', __FILE__)
-
-class QboCustomersTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
--- a/test/unit/qbo_employee_test.rb
+++ b/test/unit/qbo_employee_test.rb
@@ -1,9 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class EmployeeTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
--- a/test/unit/qbo_item_test.rb
+++ b/test/unit/qbo_item_test.rb
@@ -1,9 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class QboItemTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
--- a/test/unit/qbo_test.rb
+++ b/test/unit/qbo_test.rb
@@ -1,19 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-require File.expand_path('../../test_helper', __FILE__)
-
-class QboTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end
Author	SHA1	Message	Date
Rick Barrette	45bfce87d8	2026.1.9	2026-01-31 13:02:21 -05:00
Rick Barrette	6f33e9d23d	Inverted conditionals in estimates and invoices lists to use 'unless'	2026-01-31 12:54:07 -05:00
Rick Barrette	92460392b9	Refactor estimates and invoices rendering to use local variables for the abilty for other plugins to display filtered lists	2026-01-31 12:45:47 -05:00
Rick Barrette	f1bdf59697	Add customer details translation and fix link in appointment action	2026-01-30 23:05:23 -05:00
Rick Barrette	60e2f1d2b0	2026.1.8	2026-01-30 21:30:28 -05:00
Rick Barrette	6c9ae82f81	fixed typo	2026-01-30 21:22:08 -05:00
Rick Barrette	42e4494f6e	fixed entity, they need strings	2026-01-30 21:17:17 -05:00
Rick Barrette	7e0b2c9d09	Removed unused folders	2026-01-30 20:51:09 -05:00
Rick Barrette	5ca68b01b6	removed unsued tests	2026-01-30 20:46:04 -05:00
Rick Barrette	ebd4fa7363	Add flash error messages for forbidden access in permission checks	2026-01-30 20:40:57 -05:00
Rick Barrette	e6818958ae	Add I18n support for flash messages and update locale file with new notices	2026-01-30 20:19:12 -05:00
Rick Barrette	5b31459629	use a symbol for empty	2026-01-30 19:28:33 -05:00
Rick Barrette	92de2928f6	Merge branch 'master' into symbols	2026-01-30 17:12:11 -05:00
Rick Barrette	a8af180de2	2026.1.7	2026-01-30 17:09:34 -05:00
Rick Barrette	e621dc9e3a	nil not nill	2026-01-30 17:00:29 -05:00
Rick Barrette	c3d7c1c867	Use symbols	2026-01-30 16:58:14 -05:00
Rick Barrette	defeec7f8e	2026.1.6	2026-01-30 07:53:51 -05:00
Rick Barrette	37c302e274	use symbol keys	2026-01-30 07:53:29 -05:00
Rick Barrette	006e907b35	need to supply selected id	2026-01-30 07:53:14 -05:00
Rick Barrette	f1f77a8022	use locale	2026-01-30 07:42:09 -05:00
Rick Barrette	ff358d806e	2026.1.5	2026-01-30 07:22:11 -05:00
Rick Barrette	b80e1d4e28	loose the hash rocket, use symbol keys	2026-01-29 22:30:59 -05:00
Rick Barrette	f24128ef75	Cleaned up Issue Show Hook	2026-01-29 21:53:18 -05:00
Rick Barrette	d3a8c05f50	Added missing to_s method	2026-01-29 21:36:50 -05:00
Rick Barrette	f023cd246d	Titlize new issue subjects	2026-01-29 21:18:15 -05:00
Rick Barrette	b7e18a3c3f	Cleaned up Issue Form Hook	2026-01-29 21:12:32 -05:00
Rick Barrette	67f2dbf4d8	Removed reduntant onchange js call to update issue	2026-01-28 17:35:12 -05:00
Rick Barrette	924aa7657b	Fixed typo	2026-01-28 10:11:28 -05:00
Rick Barrette	16fe07f177	Fixed typo	2026-01-28 08:50:37 -05:00
Rick Barrette	9257b2f938	2026.1.4	2026-01-28 08:42:33 -05:00
Rick Barrette	0227681e92	Added hook list to README	2026-01-28 08:41:55 -05:00
Rick Barrette	c034696810	Disabled showing assinee to customer	2026-01-28 08:38:02 -05:00
Rick Barrette	ffdabccd84	Updated README with information about plugin hooks	2026-01-28 08:18:29 -05:00
Rick Barrette	1f03908040	Refactor employee and estimate models by removing redundant comments; update locale file to remove item references; delete unused QboItemTest file.	2026-01-28 07:45:20 -05:00
Rick Barrette	43a5317b4e	Removed DEVELOPMENT from plugin name	2026-01-28 07:03:08 -05:00
Rick Barrette	4c49ec6890	2026.1.3	2026-01-27 21:17:17 -05:00
Rick Barrette	ef7faee685	Process updates from the hooks	2026-01-27 20:50:54 -05:00
Rick Barrette	02b48d2de4	Dont add reference for customers to projects	2026-01-27 18:07:37 -05:00
Rick Barrette	e670d99766	Removed project level intergration	2026-01-27 18:01:42 -05:00
Rick Barrette	241dd594d0	Fixed pdf hooks	2026-01-26 23:22:23 -05:00
Rick Barrette	b603cb634a	Version Bump 2026.1.2	2026-01-26 22:59:48 -05:00
Rick Barrette	1308a05011	Removed Load Customer Link	2026-01-26 21:00:16 -05:00
Rick Barrette	334ed60bf7	removed extra comma	2026-01-26 20:14:01 -05:00
Rick Barrette	d63bf809f2	Merge branch 'redmine-6' into dev-6	2026-01-26 10:16:40 -05:00
Rick Barrette	31406af681	Version bump 2026.1.1	2026-01-26 10:09:24 -05:00
Rick Barrette	479be461a6	Dynamically load updateIssueFrom javascript path	2026-01-26 10:08:53 -05:00
Rick Barrette	c1af031d22	Link to sandbox if enabled	2026-01-23 21:40:08 -05:00
Rick Barrette	a741cd0217	update readme	2026-01-22 21:54:03 -05:00
Rick Barrette	4ae9374401	Merge branch 'redmine-6' into dev-6	2026-01-22 21:50:40 -05:00
Rick Barrette	b096244454	Better display of customer note	2026-01-22 21:50:17 -05:00
Rick Barrette	4983cd661c	Fixed missing locale	2026-01-22 21:49:33 -05:00
Rick Barrette	5f6fb4af27	Only show select all when more than one invoice	2026-01-22 21:29:08 -05:00
Rick Barrette	2f2c74403f	Bug fixes	2026-01-22 21:20:47 -05:00
Rick Barrette	43579d73e5	Merge remote-tracking branch 'origin/hooks' into dev-6	2026-01-22 20:58:06 -05:00
Rick Barrette	a90d6b839f	Updated readme	2026-01-22 20:57:09 -05:00
Rick Barrette	e76f977ca8	Removed Vehicles	2026-01-22 20:54:06 -05:00
Rick Barrette	7f821d241c	Removed typo	2026-01-22 20:47:31 -05:00
Rick Barrette	1bc9227c7f	finish redmine-6 merge into dev	2026-01-22 20:43:06 -05:00
Rick Barrette	3c2f1d0edd	Merge branch 'redmine-6' into HEAD	2026-01-22 20:39:20 -05:00
Rick Barrette	f0a3b0193c	Development mode Use the QBO sandbox & Display DEVEOMPENT in the plugin name	2025-06-18 08:30:21 -04:00
Ricky Barrette	b531076c18	Merge branch 'dev' into hooks	2023-12-30 23:43:10 -05:00
Ricky Barrette	9e342ced28	Merge branch 'master' into hooks	2023-12-30 23:40:08 -05:00
Ricky Barrette	0537d9bd86	Merge branch 'master' into hooks	2023-12-30 23:18:55 -05:00
Ricky Barrette	a531ef4f87	Added hour totals to customer job history	2023-01-14 06:20:41 -05:00
Ricky Barrette	1fae647381	Merge branch 'master' into dev	2022-03-19 05:49:54 -04:00
Ricky Barrette	d1764e2203	Removed Comment	2022-03-19 05:49:18 -04:00
Ricky Barrette	f830881883	Don't need to pass customer, only issue	2022-03-17 06:52:46 -04:00
Ricky Barrette	fb87e8a33a	Added hook :show_issue_view_right	2022-03-17 06:45:57 -04:00
Ricky Barrette	8bdec410c4	Fixed render of hook :show_customer_view_right	2022-03-17 06:12:35 -04:00
Ricky Barrette	dec9eee90b	Merge branch 'master' into dev	2022-03-15 12:29:11 -04:00
Ricky Barrette	2745ecf242	Added call_hook :show_customer_view_right	2022-03-14 07:52:33 -04:00
Ricky Barrette	13472c3b3a	Remove nhtsa_vin gem	2022-03-14 07:26:07 -04:00
Ricky Barrette	b686110145	Initial Vehicle Delete	2022-03-14 07:22:43 -04:00
Ricky Barrette	d91e7892c3	Added PDF hooks	2022-03-13 22:36:34 -04:00
Ricky Barrette	f26224de56	Created hook process_invoice_custom_fields	2022-03-13 20:06:13 -04:00
				`@@ -1 +0,0 @@`
				`$('select#issue_vehicles_id').html('<%= j content_tag(:option,'',:value=>"")+options_from_collection_for_select(@filtered_vehicles, :id, :to_s) %>');`
				`@@ -1 +0,0 @@`
				`<option value="<%= vehicle.id %>"><%= vehicle.to_s.titleize %></option>`