2026.2.4

This is an effort to figure out why I get 422 Unprocessable Entity errors sometimes when creating new issues.

app/views/customers/_actions.html.erb

@@ -1,9 +1,9 @@
-<%= link_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to t(:customer_details), "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank %>
+<%= link_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to t(:customer_details), "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}%3Cbr/%3E+&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank, id: :appointment_link %>
 
 <br/>
 <br/>
 
-<%= button_to t(:label_create_estimate), "https://qbo.intuit.com/app/estimate?nameId=#{@customer.id}", target: :_blank, method: :get %>
+<%= link_to t(:label_create_estimate), "https://qbo.intuit.com/app/estimate?nameId=#{@customer.id}", target: :_blank %>
 
 <br/>
 <br/>

app/views/estimates/_list.html.erb

@@ -2,6 +2,7 @@
 
   <% estimates.sort.reverse.each do |estimate| %>
     <div class="row">
+      <%= check_box_tag "estimate_ids[]", estimate.id, false,  onchange: "updateLink()", class: "estimate-checkbox" %>
       <b><%= link_to "##{estimate.doc_number}", estimate_path(estimate), target: :_blank %></b> <%= estimate.txn_date %>
     </div>
   <% end %>

app/views/invoices/_list.html.erb

@@ -12,7 +12,7 @@
 
     <% invoices.sort.reverse.each do |invoice| %>
       <div class="row">
-        <%= check_box_tag "invoice_ids[]", invoice.id, false, class: "invoice-checkbox" if invoices.count > 1 %>
+        <%= check_box_tag "invoice_ids[]", invoice.id, false,  onchange: "updateLink()", class: "invoice-checkbox" if invoices.count > 1 %>
         <b><%= link_to "##{invoice.doc_number}", invoice_path(invoice), target: :_blank %></b> <%= invoice.txn_date %>
       </div>
     <% end %>

assets/javascripts/application.js

@@ -0,0 +1,31 @@
+function updateLink() {
+  const linkElement = document.getElementById("appointment_link");
+  const regex = /((?:<br\/>|%3Cbr\/?%3E))([\s\S]*?)(&dates)/gi;
+  linkElement.href = linkElement.href.replace(regex, `$1${getSelectedDocs()}$3`);
+}
+
+function getSelectedDocs() {
+  const invoices = document.querySelectorAll('.invoice-checkbox');
+  const estimates = document.querySelectorAll('.estimate-checkbox');
+  
+  const invoiceIds = Array.from(invoices)
+      .filter(checkbox => checkbox.checked)
+      .map(checkbox => checkbox.value);
+
+  const estimateIds = Array.from(estimates)
+      .filter(checkbox => checkbox.checked)
+      .map(checkbox => checkbox.value);
+
+  let output = '';
+
+  for (const value of invoiceIds) {
+    output += `%0A<a href="${window.location.origin}/invoices/${value}">Invoice:%20${value}</a>%0A`;
+  }
+
+  for (const value of estimateIds) {
+    output += `%0A<a href="${window.location.origin}/estimates/${value}">Estimate:%20${value}</a>%0A`;
+  }
+  
+  // You can return the array or use it as needed
+  return output;
+}

config/locales/en.yml

@@ -99,4 +99,6 @@ en:
   notice_invoice_not_found: "Invoice not found"
   notice_forbidden: "You do not have permission to access this resource"
   notice_issue_not_found: "Issue not found"
-  customer_details: "Customer Details"
+  customer_details: "Customer Details"
+  notice_error_project_nil: "The issue's project is nil, set project to: "
+  notice_error_tracker_nil: "The issue's tracker is nil, set tracker to: "

init.rb

@@ -14,7 +14,7 @@ Redmine::Plugin.register :redmine_qbo do
   name 'Redmine QBO plugin'
   author 'Rick Barrette'
   description 'A pluging for Redmine to connect with QuickBooks Online to create Time Activity Entries for billable hours logged when an Issue is closed'
-  version '2026.2.0'
+  version '2026.2.4'
   url 'https://github.com/rickbarrette/redmine_qbo'
   author_url 'https://barrettefabrication.com'
   settings default: {empty: true}, partial: 'qbo/settings'

lib/redmine_qbo/hooks/issues_hook_listener.rb

@@ -10,10 +10,28 @@
 
 module RedmineQbo
   module Hooks
+    class IssuesHookListener < Redmine::Hook::ViewListener
 
-    class IssuesFormHookListener < Redmine::Hook::ViewListener
+      include IssuesHelper
 
-    include IssuesHelper
+      # Check the new issue form for a valid project.
+        # This is added to help prevent 422 unprocessable entity errors when creating an issue 
+        # See https://github.com/redmine/redmine/blob/84483d63828d0cb2efbf5bd786a2f0d22e34c93d/app/controllers/issues_controller.rb#L179
+        def controller_issues_new_before_save(context={})
+          if context[:issue].project.nil?
+            context[:issue].project = projects_for_select(context[:issue]).first
+            Rails.logger.error I18n.t(:notice_error_project_nil) + context[:issue].project.to_s
+            context[:controller].flash[:error] = I18n.t(:notice_error_project_nil) + context[:issue].project.to_s
+          end
+
+          if context[:issue].tracker.nil?
+            context[:issue].tracker = trackers_for_select(context[:issue]).first
+            Rails.logger.error I18n.t(:notice_error_tracker_nil) + context[:issue].tracker.to_s
+            context[:controller].flash[:error] = I18n.t(:notice_error_tracker_nil) + context[:issue].tracker.to_s
+          end
+
+          return context
+        end
 
       # Edit Issue Form
       # Here we build the required form components before passing them to a partial view formatting. 
@@ -54,7 +72,31 @@ module RedmineQbo
           }
         )
       end
-    end
 
-  end
+      # View Issue
+      # Displays the quickbooks customer, estimate, & invoices attached to the issue
+      def view_issues_show_details_bottom(context={})
+        issue = context[:issue]
+        
+        # Build a list of invoice links
+        invoice_link = ""
+        if issue.invoices
+          issue.invoices.each do |i|
+            invoice_link += "#{link_to i, i, target: :_blank}<br/>"
+          end
+        end
+        
+        context[:controller].send(:render_to_string, {
+          partial: 'issues/show_details',
+            locals: {
+              customer: issue.customer ? link_to(issue.customer) : nil, 
+              estimate_link: issue.estimate ? link_to(issue.estimate, issue.estimate, target: :_blank) : nil, 
+              invoice_link: invoice_link.html_safe,
+              issue: issue
+            } 
+          })
+      end
+      
+    end
+  end 
 end

lib/redmine_qbo/hooks/issues_show_hook_listener.rb

@@ -1,43 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-module RedmineQbo
-  module Hooks
-
-    class IssuesShowHookListener < Redmine::Hook::ViewListener
-
-      # View Issue
-      # Displays the quickbooks customer, estimate, & invoices attached to the issue
-      def view_issues_show_details_bottom(context={})
-        issue = context[:issue]
-        
-        # Build a list of invoice links
-        invoice_link = ""
-        if issue.invoices
-          issue.invoices.each do |i|
-            invoice_link += "#{link_to i, i, target: :_blank}<br/>"
-          end
-        end
-        
-        context[:controller].send(:render_to_string, {
-          partial: 'issues/show_details',
-            locals: {
-              customer: issue.customer ? link_to(issue.customer) : nil, 
-              estimate_link: issue.estimate ? link_to(issue.estimate, issue.estimate, target: :_blank) : nil, 
-              invoice_link: invoice_link.html_safe,
-              issue: issue
-            } 
-          })
-      end
-      
-    end
-
-  end 
-end

lib/redmine_qbo/patches/issues_controller_patch.rb

@@ -15,22 +15,19 @@ module RedmineQbo
 
       module Helper
         def watcher_link(issue, user)
-          link = +''
+          link = ''
-          link << link_to(I18n.t(:label_bill_time), bill_path( issue.id ), method: :get, class: 'icon icon-email-add') if user.admin?
+          link = link_to(I18n.t(:label_bill_time), bill_path( issue.id ), method: :get, class: 'icon icon-email-add') if user.admin?
           link << link_to(I18n.t(:label_share), share_path( issue.id ), method: :get, target: :_blank, class: 'icon icon-shared') if user.logged?
           link.html_safe + super
         end
       end
 
       def self.included(base)
-
         base.class_eval do
           helper Helper
         end
-
+      end 
-      end
+    end
-
-    end   
 
     # Add module to IssuessController
     IssuesController.send(:include, IssuesControllerPatch)