The customers, employees, estimates and invoices tables were created with
t.integer :id, options: 'PRIMARY KEY', which Rails ignores, so the QuickBooks id was never unique. Two
syncs of the same record at once (saving an estimate in Redmine, then QuickBooks' webhook) inserted it
twice, so it showed twice on the customer page and counted twice on the business report.
- Migration 050 keeps one row per id (the most recently updated) and adds a unique index on id.
- A sync that collides with another one's insert retries once as an update.
- Estimates, customers and employees validate a unique id, like invoices already did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
- Estimates now keep their total; estimates and invoices keep their man-hours: the quantities of the
products/services set as "Replaced by imported time" (bundles included; the estimate item codes
while that setting is blank). Filled in by the webhook and the sync.
- Payment model (QboBaseModel) caching each payment's customer, date, amount and unapplied amount,
kept current by the webhook, the sync and the Receive payment page.
- Business report (View business reports permission, top menu): estimates written vs. invoices written
vs. payments received, and estimated hours on estimates and issues vs. invoiced and spent hours, for
a period, with a month-by-month breakdown.
- Fix two keyword arguments that defaulted to themselves (QboSyncDispatcher.enque_jobs, PdfService),
which newer Ruby refuses to parse.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
Security
- Connecting to QuickBooks (authenticate/oauth_callback) and all syncs
are admin-only; the OAuth state is stored and verified on callback
- New "Bill issue time to QuickBooks" project permission; billing is now
a POST and checks the permission and issue visibility
- Estimate/invoice PDFs require a logged-in user, or a customer share
link limited to the estimate and invoices attached to that issue
(the old require_user check never ran)
- Attachments patch keeps the share token per request instead of in
Thread.current, so it can't leak into other requests
Permissions and share links
- customers#autocomplete and the filter_* actions are part of View
customers, so non-admins can pick customers on forms
- customers#view no longer goes through authorize_global; share needs
the new "Share issues with customers" permission and a visible issue
- Removed a check in customers#view that compared a value to itself
Bugs
- Subjects and customer names capitalize each word without lowercasing
the rest (LED, JL, 4x4 stay as typed); subjects only when changed
- Settings page shows Invoice/Estimate sync times (Item/Account models
no longer exist)
- customers#update shows validation errors instead of reporting success
- Billing marks each activity billed once sent to QBO, so retries and
token refreshes don't create duplicate TimeActivities
Search
- New CustomerSearchService for autocomplete and the customer search
page: nicknames (Bill/William), typos, word order, partial words,
accents, and phone digits in any format; ranked, with the candidate
list cached until a customer changes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM