Claude
0523e8dd24
Security, permission and search fixes
...
Security
- Connecting to QuickBooks (authenticate/oauth_callback) and all syncs
are admin-only; the OAuth state is stored and verified on callback
- New "Bill issue time to QuickBooks" project permission; billing is now
a POST and checks the permission and issue visibility
- Estimate/invoice PDFs require a logged-in user, or a customer share
link limited to the estimate and invoices attached to that issue
(the old require_user check never ran)
- Attachments patch keeps the share token per request instead of in
Thread.current, so it can't leak into other requests
Permissions and share links
- customers#autocomplete and the filter_* actions are part of View
customers, so non-admins can pick customers on forms
- customers#view no longer goes through authorize_global; share needs
the new "Share issues with customers" permission and a visible issue
- Removed a check in customers#view that compared a value to itself
Bugs
- Subjects and customer names capitalize each word without lowercasing
the rest (LED, JL, 4x4 stay as typed); subjects only when changed
- Settings page shows Invoice/Estimate sync times (Item/Account models
no longer exist)
- customers#update shows validation errors instead of reporting success
- Billing marks each activity billed once sent to QBO, so retries and
token refreshes don't create duplicate TimeActivities
Search
- New CustomerSearchService for autocomplete and the customer search
page: nicknames (Bill/William), typos, word order, partial words,
accents, and phone digits in any format; ranked, with the candidate
list cached until a customer changes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com >
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 22:08:36 -04:00
ricky
bab019a152
Implement global permissions for customer actions and update views to check permissions before rendering buttons
2026-09-08 22:35:52 -04:00
ricky
ba40496421
Enhance autocomplete functionality to support name and phone queries with fuzzy matching
2026-08-25 16:05:51 -04:00
ricky
9dc4b79355
Refactor customer controller and form to enhance error handling and conditional rendering
2026-08-24 20:17:21 -04:00
ricky
b367687113
Implmented custom autocomplete for customer field
2026-03-18 21:55:55 -04:00
ricky
020ea01d36
renamed controllers and updated routes
2026-03-18 00:08:56 -04:00
ricky
7d3908ec41
fixed estimate#sync
2026-03-17 23:31:42 -04:00
ricky
f60e507029
Updated settings page
2026-03-17 21:23:29 -04:00
ricky
3e81d2840a
fixed typo
2026-03-15 17:59:53 -04:00
ricky
c9a5dc20f9
Added manual sync links
2026-03-15 08:01:04 -04:00
ricky
eb1174cf7c
Updated manual sync to to allow full or partial sync
2026-03-14 15:36:39 -04:00
ricky
164252cb97
Refactored PDF services
2026-03-13 23:40:52 -04:00
ricky
8ba99b7db2
Fixed eager loading issues
2026-03-04 19:18:06 -05:00
ricky
be400c2b2a
Added logging for errors when editing
2026-03-03 19:22:15 -05:00
ricky
899237c5ab
Reduced blanket rescues, added respond_to_missing?, and extracted push into CustomerPushService
2026-03-02 22:41:22 -05:00
ricky
b95a3b6623
Refactor: Update billing error messages in locale for consistency and clarity
2026-03-01 12:35:54 -05:00
ricky
ef3f00c445
Refactor: Replace BillingValidator with inline validations in bill method and update error messages in locale
2026-03-01 12:29:20 -05:00
ricky
3728ec2a12
Refactor: Improve address formatting in CustomersController and enhance HTML rendering for billing and shipping addresses
2026-03-01 00:40:11 -05:00
ricky
cefa36c880
Removed unsued Customer destroy method
2026-03-01 00:28:57 -05:00
ricky
ed111fefe7
Refactor: Update QBO connection handling to use QboConnectionService for consistency across services and controllers
2026-03-01 00:27:06 -05:00
ricky
f921f227e2
Refactor: Introduce PdfServiceBase for shared PDF fetching functionality and update Invoice/Estimate controllers to utilize new services
2026-02-28 21:59:01 -05:00
ricky
a34ae46358
Refactor: Simplify invoice PDF fetching and introduce InvoicePdfService for better organization
2026-02-28 21:36:16 -05:00
ricky
e4cfb0674e
Refactor: Enhance estimate loading and syncing logic in EstimateController
2026-02-28 21:20:35 -05:00
ricky
7a50df24d9
Add logging to get_estimate method for better debugging
2026-02-28 08:53:38 -05:00
ricky
6f8af9bba8
Implement Employee synchronization; add EmployeeSyncJob and EmployeeSyncService for improved background processing and logging
2026-02-27 23:07:12 -05:00
ricky
03109d5775
Refactor invoice processing and synchronization; implement InvoiceSyncJob and related services for improved background processing and logging
2026-02-27 22:33:04 -05:00
ricky
9c0f153518
Refactor logging across controllers and jobs to use a centralized log method; improve consistency and readability of log messages
2026-02-27 22:32:07 -05:00
ricky
f32b48296d
Refactor estimate synchronization to use EstimateSyncJob; remove direct sync logic from Estimate model for improved background processing
2026-02-27 08:29:52 -05:00
ricky
889e9bf31f
Refactor customer synchronization to use CustomerSyncJob; remove direct sync logic from Customer model for improved background processing
2026-02-27 08:00:38 -05:00
ricky
208e839e6a
Refactor CustomerToken model for improved token management; streamline token generation and expiration handling, and enhance association with issues
2026-02-26 21:05:02 -05:00
ricky
4f55751500
Refactor QuickBooks webhook handling to use ActiveJob for processing; improve security with signature verification and streamline entity processing
2026-02-26 20:30:20 -05:00
ricky
a64016eb95
Refactor QBO billing to use ActiveJob; remove threaded billing and add manual job enqueue support
2026-02-26 19:48:29 -05:00
ricky
5d858ae186
Enhance customer search functionality by ordering results and refining search method
2026-02-25 22:05:52 -05:00
ricky
a54de28db5
Extending customers to Redmine's built in search
2026-02-21 11:20:20 -05:00
ricky
e7dfc3f2ad
added sync estimates by id
2026-02-14 08:25:02 -05:00
ricky
359c582e22
Fixed partial billing and added flash messages
2026-02-13 18:25:07 -05:00
ricky
e6c4e81df2
Remove unused add_appointment method from CustomersController
2026-02-08 19:48:01 -05:00
ricky
5d7d9a81bb
inital start of using javascript to update the appointment link with selected document links
2026-02-06 17:58:02 -05:00
ricky
6c9ae82f81
fixed typo
2026-01-30 21:22:08 -05:00
ricky
42e4494f6e
fixed entity, they need strings
2026-01-30 21:17:17 -05:00
ricky
e6818958ae
Add I18n support for flash messages and update locale file with new notices
2026-01-30 20:19:12 -05:00
ricky
c3d7c1c867
Use symbols
2026-01-30 16:58:14 -05:00
ricky
b80e1d4e28
loose the hash rocket, use symbol keys
2026-01-29 22:30:59 -05:00
ricky
3c2f1d0edd
Merge branch 'redmine-6' into HEAD
2026-01-22 20:39:20 -05:00
ricky
2aeb3fa028
Updated copyright dates
2026-01-21 20:40:06 -05:00
ricky
f74f3ad72e
Select All Invoices For Bulk PDF
2026-01-20 20:49:03 -05:00
ricky
704dff2a72
Multiple Invoices to PDF
2026-01-19 19:33:29 -05:00
ricky
f22795ac90
Moved strings for notices to en.yml
2025-06-16 22:56:54 -04:00
ricky
4d85c24872
generate redirect_uri protocol based one site settings
2025-06-16 22:30:30 -04:00
ricky
60857e9dca
generate redirect_uri protocol based one site settings
2025-06-16 22:15:42 -04:00