Commit Graph
144 Commits
Author SHA1 Message Date
Claude 616ee13725 Tidy the plugin settings page
- Three sections: QuickBooks connection, Synchronization and Billing.
- Synchronization is one table of every synced type (customers, employees, estimates, invoices,
  payments, items, accounts) with its count, last sync and a Sync link, plus Sync changes and Full sync.
  The separate billing stats and management boxes are folded into it.
- New payments sync (admin only).
- Sync links return to the page they were clicked on instead of the home page.
- Remove locale strings nothing uses any more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-31 08:11:27 -04:00
Claude 0523e8dd24 Security, permission and search fixes
Security
- Connecting to QuickBooks (authenticate/oauth_callback) and all syncs
  are admin-only; the OAuth state is stored and verified on callback
- New "Bill issue time to QuickBooks" project permission; billing is now
  a POST and checks the permission and issue visibility
- Estimate/invoice PDFs require a logged-in user, or a customer share
  link limited to the estimate and invoices attached to that issue
  (the old require_user check never ran)
- Attachments patch keeps the share token per request instead of in
  Thread.current, so it can't leak into other requests

Permissions and share links
- customers#autocomplete and the filter_* actions are part of View
  customers, so non-admins can pick customers on forms
- customers#view no longer goes through authorize_global; share needs
  the new "Share issues with customers" permission and a visible issue
- Removed a check in customers#view that compared a value to itself

Bugs
- Subjects and customer names capitalize each word without lowercasing
  the rest (LED, JL, 4x4 stay as typed); subjects only when changed
- Settings page shows Invoice/Estimate sync times (Item/Account models
  no longer exist)
- customers#update shows validation errors instead of reporting success
- Billing marks each activity billed once sent to QBO, so retries and
  token refreshes don't create duplicate TimeActivities

Search
- New CustomerSearchService for autocomplete and the customer search
  page: nicknames (Bill/William), typos, word order, partial words,
  accents, and phone digits in any format; ranked, with the candidate
  list cached until a customer changes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 22:08:36 -04:00
ricky eb1174cf7c Updated manual sync to to allow full or partial sync 2026-03-14 15:36:39 -04:00
ricky b95a3b6623 Refactor: Update billing error messages in locale for consistency and clarity 2026-03-01 12:35:54 -05:00
ricky ef3f00c445 Refactor: Replace BillingValidator with inline validations in bill method and update error messages in locale 2026-03-01 12:29:20 -05:00
ricky ed111fefe7 Refactor: Update QBO connection handling to use QboConnectionService for consistency across services and controllers 2026-03-01 00:27:06 -05:00
ricky 6f8af9bba8 Implement Employee synchronization; add EmployeeSyncJob and EmployeeSyncService for improved background processing and logging 2026-02-27 23:07:12 -05:00
ricky 03109d5775 Refactor invoice processing and synchronization; implement InvoiceSyncJob and related services for improved background processing and logging 2026-02-27 22:33:04 -05:00
ricky f32b48296d Refactor estimate synchronization to use EstimateSyncJob; remove direct sync logic from Estimate model for improved background processing 2026-02-27 08:29:52 -05:00
ricky 889e9bf31f Refactor customer synchronization to use CustomerSyncJob; remove direct sync logic from Customer model for improved background processing 2026-02-27 08:00:38 -05:00
ricky 4f55751500 Refactor QuickBooks webhook handling to use ActiveJob for processing; improve security with signature verification and streamline entity processing 2026-02-26 20:30:20 -05:00
ricky a64016eb95 Refactor QBO billing to use ActiveJob; remove threaded billing and add manual job enqueue support 2026-02-26 19:48:29 -05:00
ricky 359c582e22 Fixed partial billing and added flash messages 2026-02-13 18:25:07 -05:00
ricky 42e4494f6e fixed entity, they need strings 2026-01-30 21:17:17 -05:00
ricky c3d7c1c867 Use symbols 2026-01-30 16:58:14 -05:00
ricky b80e1d4e28 loose the hash rocket, use symbol keys 2026-01-29 22:30:59 -05:00
ricky 2aeb3fa028 Updated copyright dates 2026-01-21 20:40:06 -05:00
ricky f22795ac90 Moved strings for notices to en.yml 2025-06-16 22:56:54 -04:00
ricky 4d85c24872 generate redirect_uri protocol based one site settings 2025-06-16 22:30:30 -04:00
ricky 60857e9dca generate redirect_uri protocol based one site settings 2025-06-16 22:15:42 -04:00
ricky dac9a7c756 Started Support for Redmine 6 2024-12-12 06:00:36 -05:00
ricky 63218e7f42 Fixed formating 2024-08-19 23:28:54 -04:00
ricky 7f0bb3cae7 Removed extra end 2024-08-19 23:26:43 -04:00
ricky ad7417c233 Moved work into thread to repsond quickly 2024-08-19 23:21:56 -04:00
ricky 039d1ca993 Use Logger.info 2024-08-19 22:31:41 -04:00
ricky 80fc858a35 send back status 200 if request succeeded 2024-08-19 20:14:02 -04:00
ricky 5782cbc166 Added https 2024-08-19 20:04:09 -04:00
ricky 0729d2ac41 added https to redirect_uri 2024-08-19 20:02:22 -04:00
ricky 6c6de0ba86 Added log 2024-08-19 19:59:26 -04:00
ricky 11dbcaf80c Use Setting.host_name & path 2024-08-19 19:53:51 -04:00
ricky 95592e542f Use qbo_oauth_callback_path 2024-08-19 19:30:51 -04:00
ricky 81f322b616 Call refresh_token to set token time stamps 2023-12-30 20:26:30 -05:00
ricky 84dfdd707a fixed token names 2023-12-30 12:46:52 -05:00
ricky 517a239485 Started reworking Oauth token sorage 2023-12-30 12:39:51 -05:00
ricky 5b89d73c20 Remove QboItem.sync 2023-12-29 18:56:20 -05:00
ricky 3ea2cd14d1 Fixed accidental removal of qbo prefix 2022-03-14 19:33:20 -04:00
ricky 47a19a7e77 Removed Qbo index & sync html, methods, & routes
This stuff isn't really used for anything
2022-03-09 23:06:54 -05:00
ricky 8d8201822b No longer need to prepend("Qbo") 2022-03-09 21:45:07 -05:00
ricky 24f8be6e80 Drop the Qbo prefix 2022-03-09 21:31:56 -05:00
ricky 19acfbc76f Added logging 2022-02-21 08:51:01 -05:00
ricky 7234a70265 Added allowed params for qbo controller 2022-02-19 21:47:12 -05:00
ricky 41d49ccce5 Setting.host_name for hooks not a hardcoded URL 2022-02-12 09:24:21 -05:00
ricky c85f450742 Merge branch 'master' into redmine-4 2022-02-12 09:19:36 -05:00
ricky e314dae10d Logging & exception handler for updating invoices 2022-02-12 09:12:11 -05:00
ricky 7cc8a946fd Inital update for redmine 4.0+ compatibility 2022-02-01 20:53:20 -05:00
ricky 5573e941c6 Cleaning up uneeded code 2020-01-05 11:58:27 -05:00
ricky 0364989fe1 Update qbo_controller.rb 2020-01-04 22:46:20 -05:00
ricky 5dbf486b50 Update qbo_controller.rb 2020-01-04 15:21:14 -05:00
ricky b734125d6b Update qbo_controller.rb 2020-01-04 15:19:31 -05:00
ricky 5af7d73768 Update qbo_controller.rb 2020-01-04 14:18:42 -05:00