* customers#filter_estimates_by_customer and #filter_invoices_by_customer,
their routes, permission entries and template: they filled an estimate
dropdown on the old issue form, which is gone.
* Routes with no action: accounts new/create/show/edit/update/destroy
(only index, Set default and Sync exist) and customers#destroy.
* Unused methods: AuthHelper#require_user, #allowed_to?, #check_permission;
CustomersController#address_to_s; CustomerToken#expired? and
.remove_expired_tokens; QboBaseModel#skip_qbo_push?;
QboDraft.writable_document?; SyncServiceBase#extract_value.
* CustomersController's before_action helpers are private.
* The unused .autocomplete-meta style and 28 unused translation keys.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Security
- Connecting to QuickBooks (authenticate/oauth_callback) and all syncs
are admin-only; the OAuth state is stored and verified on callback
- New "Bill issue time to QuickBooks" project permission; billing is now
a POST and checks the permission and issue visibility
- Estimate/invoice PDFs require a logged-in user, or a customer share
link limited to the estimate and invoices attached to that issue
(the old require_user check never ran)
- Attachments patch keeps the share token per request instead of in
Thread.current, so it can't leak into other requests
Permissions and share links
- customers#autocomplete and the filter_* actions are part of View
customers, so non-admins can pick customers on forms
- customers#view no longer goes through authorize_global; share needs
the new "Share issues with customers" permission and a visible issue
- Removed a check in customers#view that compared a value to itself
Bugs
- Subjects and customer names capitalize each word without lowercasing
the rest (LED, JL, 4x4 stay as typed); subjects only when changed
- Settings page shows Invoice/Estimate sync times (Item/Account models
no longer exist)
- customers#update shows validation errors instead of reporting success
- Billing marks each activity billed once sent to QBO, so retries and
token refreshes don't create duplicate TimeActivities
Search
- New CustomerSearchService for autocomplete and the customer search
page: nicknames (Bill/William), typos, word order, partial words,
accents, and phone digits in any format; ranked, with the candidate
list cached until a customer changes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM