Made decode_vin not private

This commit is contained in:
2019-11-12 12:08:04 -05:00
committed by GitHub
parent aa45338e36
commit f78c0338b4

View File

@@ -20,7 +20,7 @@ class Vehicle < ActiveRecord::Base
validates_presence_of :customer
validates :vin, uniqueness: true
before_save :decode_vin
after_initialize :get_details
#after_find :get_details
self.primary_key = :id
@@ -84,21 +84,6 @@ class Vehicle < ActiveRecord::Base
where("vin LIKE ?", "%#{search}%")
end
private
# init method to pull JSON details from Edmunds
def get_details
if self.vin?
begin
query = NhtsaVin.get(self.vin)
raise RuntimeError, query.error unless query.valid?
@details = query.response
rescue Exception => e
errors.add(:vin, e.message)
end
end
end
# decodes a vin and updates self
def decode_vin
get_details
@@ -114,4 +99,19 @@ private
self.name = to_s
end
private
# init method to pull JSON details from Edmunds
def get_details
if self.vin?
begin
query = NhtsaVin.get(self.vin)
raise RuntimeError, query.error unless query.valid?
@details = query.response
rescue Exception => e
errors.add(:vin, e.message)
end
end
end
end