Refactor estimate synchronization to use EstimateSyncJob; remove direct sync logic from Estimate model for improved background processing

app/controllers/qbo_controller.rb

@@ -94,13 +94,13 @@ class QboController < ApplicationController
     logger.info "Syncing EVERYTHING"
 
     CustomerSyncJob.perform_later(full_sync: true)
+    EstimateSyncJob.perform_later(full_sync: true)
 
     # Update info in background
     Thread.new do
       if Qbo.exists?
         Invoice.sync
         Employee.sync
-        Estimate.sync
         
         # Record the last sync time
         Qbo.update_time_stamp

app/jobs/estimate_sync_job.rb

@@ -0,0 +1,90 @@
+#The MIT License (MIT)
+#
+#Copyright (c) 2016 - 2026 rick barrette
+#
+#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+#
+#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+#
+#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+class EstimateSyncJob < ApplicationJob
+  queue_as :default
+  retry_on StandardError, wait: 5.minutes, attempts: 5
+
+  def perform(full_sync: false)
+    qbo = Qbo.first
+    return unless qbo
+
+    logger.info "[EstimateSyncJob] Starting #{full_sync ? 'full' : 'incremental'} sync..."
+
+    qbo = Qbo.first
+    qbo.perform_authenticated_request do |access_token|
+            
+        service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
+
+        page = 1
+        loop do
+          collection = fetch_estimates(service, page, full_sync)
+          entries = Array(collection&.entries)
+
+          break if entries.empty?
+
+          entries.each { |c| sync_estimates(c) }
+
+          page += 1
+          break if entries.size < 1000
+        end
+
+        logger.info "[EstimateSyncJob] Completed sync."
+    end
+  rescue => e
+    logger.error "[EstimateSyncJob] Fatal error: #{e.message}"
+    logger.error e.backtrace.join("\n")
+    raise # allows retry
+  end
+
+  private
+
+  # Fetch either all or incremental estimates
+  def fetch_estimates(service, page, full_sync)
+    start_position = (page - 1) * 1000 + 1
+
+    if full_sync
+      service.query("SELECT * FROM Estimate STARTPOSITION #{start_position} MAXRESULTS 1000")
+    else
+      last_update = Estimate.maximum(:updated_at) || 1.year.ago
+      service.query(<<~SQL.squish)
+        SELECT * FROM Estimate
+        WHERE MetaData.LastUpdatedTime > '#{last_update.utc.iso8601}'
+        STARTPOSITION #{start_position}
+        MAXRESULTS 1000
+      SQL
+    end
+  rescue => e
+    logger.error "[EstimateSyncJob] Failed to fetch page #{page}: #{e.message}"
+    nil
+  end
+
+  # Sync a single estimate record
+  def sync_estimates(e)
+    logger.info "[EstimateSyncJob] Processing estimate #{e.id} doc=#{e.doc_number} status=#{e.txn_status}"
+
+    estimate = Estimate.find_or_initialize_by(id: e.id)
+
+    estimate.doc_number = e.doc_number
+    estimate.estimate_id = e.estimate_ref.value
+    estimate.txn_date = e.txn_date
+
+    if estimate.changed?
+      estimate.save
+      logger.info "[EstimateSyncJob] Updated estimate #{e.id}"
+    end
+  end
+
+  # TODO remove deleted estimates
+  
+  rescue => error
+    logger.error "[EstimateSyncJob] Failed to sync estimate #{e.id}: #{error.message}"
+  end
+end

app/models/estimate.rb

@@ -22,21 +22,7 @@ class Estimate < ActiveRecord::Base
   
   # sync all estimates
   def self.sync
-    logger.info "Syncing ALL estimates"
-    qbo = Qbo.first
-    estimates = qbo.perform_authenticated_request do |access_token|
-      service = Quickbooks::Service::Estimate.new(company_id: qbo.realm_id, access_token: access_token)
-      service.all
-    end
-
-    return unless estimates
-
-    estimates.each { |estimate|
-      process_estimate(estimate)
-    }
-
-    #remove deleted estimates
-    where.not(estimates.map(&:id)).destroy_all
+    EstimateSyncJob.perform_later(full_sync: false)
   end
   
   # sync only one estimate