Created hook process_invoice_custom_fields

app/models/invoice.rb

@@ -104,34 +104,20 @@ class Invoice < ActiveRecord::Base
   # this condions causes an infinite loop as the webhook is called when an invoice is updated
   # TODO maybe add a cf_sync_confict flag to invoices
   def self.compare_custom_fields(issue, invoice)
+
     logger.debug "Comparing custom fields"
     # TODO break if Invoice.find(invoice.id).cf_sync_confict
     is_changed = false
 
-    # update the invoive custom fields with infomation from the issue if available
+    logger.debug "Calling :process_invoice_custom_fields hook"
-    invoice.custom_fields.each { |cf|
+    context = Redmine::Hook.call_hook :process_invoice_custom_fields, { issue: issue, invoice: invoice } 
 
-      # VIN from the attached vehicle
+    unless context.nil?
-      # TODO move this into seperate plugin
+      logger.debug "We have a context!"
-      # TODO create hook for seperate plugin 
+      context= context.first
-      begin
+      issue = context[:issue]
-        if cf.name.eql? "VIN"
+      invoice = context[:invoice]
-          # Only update if blank to prevent infite loops
+      is_changed = context[:is_changed]
-          # TODO check cf_sync_confict flag once implemented
-          if cf.string_value.to_s.blank?
-            logger.debug " VIN was blank, updating the invoice vin in quickbooks"
-            vin = Vehicle.find(issue.vehicles_id).vin
-            break if vin.nil?
-            if not cf.string_value.to_s.eql? vin
-              cf.string_value = vin.to_s
-              logger.debug "VIN has changed"
-              is_changed = true
-            end
-
-          end
-        end
-      rescue
-        #do nothing
     end
       
     # Custom Values
@@ -150,7 +136,6 @@ class Invoice < ActiveRecord::Base
     rescue
       # Nothing to do here, there is no match
     end
-    }
 
     # Push updates
     begin

lib/qbo_hook_listener.rb

@@ -0,0 +1,49 @@
+#The MIT License (MIT)
+#
+#Copyright (c) 2022 rick barrette
+#
+#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+#
+#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+#
+#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+# TODO move this into seperate plugin
+class QboHookListener < Redmine::Hook::Listener
+
+  # Load the javascript to support the autocomplete forms
+  def process_invoice_custom_fields(context = {})
+    Rails.logger.debug "QboHookListener.process_invoice_custom_fields"
+    issue = context[:issue]
+    invoice = context[:invoice]
+    is_changed = false
+
+    # update the invoive custom fields with infomation from the issue if available
+    invoice.custom_fields.each { |cf|
+
+      # VIN from the attached vehicle
+      begin
+        if cf.name.eql? "VIN"
+          # Only update if blank to prevent infite loops
+          # TODO check cf_sync_confict flag once implemented
+          if cf.string_value.to_s.blank?
+            logger.debug " VIN was blank, updating the invoice vin in quickbooks"
+            vin = Vehicle.find(issue.vehicles_id).vin
+            break if vin.nil?
+            if not cf.string_value.to_s.eql? vin
+              cf.string_value = vin.to_s
+              logger.debug "VIN has changed"
+              is_changed = true
+            end
+
+          end
+        end
+      rescue
+        #do nothing
+      end
+    }
+
+    return { issue: issue, invoice: invoice, is_changed: is_changed } 
+  end
+
+end