Simplified & Removed the unnecessary nested loops

app/models/qbo_invoice.rb

@@ -60,34 +60,37 @@ class QboInvoice < ActiveRecord::Base
           i = Issue.find_by_id(issue.to_i)
           i.qbo_invoice = QboInvoice.find_by_id(invoice.id.to_i)
           i.save!
+        }
+      end
+    }
     
     is_changed = false
           
-          # Update QBO with Milage & VIN
+    # update the invoive custom fields with infomation from the work ticket if available
     invoice.custom_fields.each { |cf|
       # VIN
       if cf.name.eql? "VIN"
-              cf.string_value = Vehicle.find(i.vehicles_id).vin if i.vehicles_id
+        vin = Vehicle.find(i.vehicles_id).vin
+        cf.string_value = vin if i.vehicles_id if not cf.string_value.to_s.eql? vin
         break
       end
       
-            # Update Matching Fields
+      # Custom Values
-            i.custom_field_values.each { |value|
+      begin
-              if cf.name.eql? CustomField.find_by_id(value.custom_field_id).name
+        value = i.custom_values.find_by(custom_field_id: CustomField.find_by_name(cf.name).id)
+        if value
           if not cf.string_value.to_s.eql? value.value.to_s
             cf.string_value = value.value.to_s
             is_changed = true
           end
-                break
         end
-            }
+      rescue
-          }
+        # Nothing to do here, there is no match
-        }
+      end
+      
       # Push updates
       Qbo.get_base(:invoice).service.update(invoice) if is_changed
   end
-    }
-  end
   
   def self.update(id)
     # Update the item table