Add controller and job tests

Integration tests for every controller: permissions, the estimate and
invoice editors (drafts, save and send, conflicts, the linked-estimate
and paid-invoice unlocks), payments, drafts, customers and share
links, estimate/invoice PDFs for share-link customers, items, accounts,
the business report, and QboController (OAuth state check, webhook
signature, manual billing). Unit tests for the webhook job, the sync
dispatcher and QboSyncJob.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-20 16:36:02 -05:00
1 parent 9ed3ef23fb
commit da82f7e12c
11 files changed
+1310

No files matched your search

+118
View File
@@ -0,0 +1,118 @@
#The MIT License (MIT)
#
#Copyright (c) 2026 rick barrette
#
#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
#
#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
#
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
require File.expand_path('../test_helper', __dir__)
# Estimate and invoice PDFs: logged-in users, or a share-link customer for their own issue's documents only
class DocumentPdfsTest < Redmine::IntegrationTest
include QboFakeServiceHelper
fixtures :projects, :users, :email_addresses, :members, :member_roles, :roles, :issues, :trackers,
:projects_trackers, :issue_statuses, :enabled_modules, :enumerations
def setup
local_customer
Estimate.where(id: [598, 599]).delete_all
Invoice.where(id: [601, 602]).delete_all
Estimate.create!(id: 598, doc_number: '1068', customer_id: 9101)
Estimate.create!(id: 599, doc_number: '1069', customer_id: 9101)
@invoice = Invoice.create!(id: 601, doc_number: '1234', customer_id: 9101, txn_date: Date.new(2026, 11, 12))
Invoice.create!(id: 602, doc_number: '1235', customer_id: 9101, txn_date: Date.new(2026, 11, 12))
issue = Issue.find(1)
issue.update_column(:estimate_id, 598)
issue.invoices = [@invoice]
CustomerToken.delete_all
@token = CustomerToken.create!(issue_id: 1, expires_at: 1.week.from_now)
@fake = install_fake_quickbooks
[qbo_estimate(id: 598, doc_number: '1068'), qbo_estimate(id: 599, doc_number: '1069'),
qbo_invoice(id: 601, doc_number: '1234'), qbo_invoice(id: 602, doc_number: '1235')].each { |d| @fake.add(d) }
@fake.pdf_body = '%PDF-1.4 test'
end
def open_share_link
get "/customers/view/#{@token.token}"
assert_response :success
end
def test_logged_in_user_gets_the_estimate_pdf
log_user('jsmith', 'jsmith')
get '/estimates/598'
assert_response :success
assert_equal 'application/pdf', response.media_type
assert_match 'estimate 1068.pdf', response.headers['Content-Disposition']
get '/estimates/doc', params: { search: '1069' }
assert_response :success
end
def test_estimate_missing_locally_is_synced_first
log_user('jsmith', 'jsmith')
Estimate.expects(:sync_by_id).with('777')
get '/estimates/777'
assert_response :redirect
assert_equal I18n.t(:notice_estimate_not_found), flash[:error]
end
def test_anonymous_visitors_must_log_in
get '/estimates/598'
assert_redirected_to %r{/login}
get '/invoices/601'
assert_redirected_to %r{/login}
end
def test_share_link_customer_sees_only_their_estimate
open_share_link
get '/estimates/598'
assert_response :success
get '/estimates/doc', params: { search: '1068' }
assert_response :success
get '/estimates/599'
assert_response :forbidden
get '/estimates/doc', params: { search: '1069' }
assert_response :forbidden
end
def test_share_link_customer_sees_only_their_invoices
open_share_link
get '/invoices/601'
assert_response :success
assert_match 'invoice 1234.pdf', response.headers['Content-Disposition']
get '/invoices/602'
assert_response :forbidden
get '/invoices/601', params: { invoice_ids: %w[601 602] }
assert_response :forbidden
end
def test_expired_share_link_stops_working
open_share_link
@token.update_column(:expires_at, 1.minute.ago)
get '/invoices/601'
assert_redirected_to %r{/login}
end
def test_invoice_pdf_failure_redirects
log_user('jsmith', 'jsmith')
get '/invoices/999'
assert_response :redirect
assert_equal I18n.t(:notice_invoice_not_found), flash[:error]
end
def test_syncs_are_admin_only
log_user('jsmith', 'jsmith')
get '/estimates/sync'
assert_response :forbidden
get '/invoices/sync'
assert_response :forbidden
reset!
log_user('admin', 'admin')
Estimate.expects(:sync)
Invoice.expects(:sync)
get '/estimates/sync'
get '/invoices/sync'
end
end