ricky/redmine_qbo
1
1
Fork 0
mirror of https://github.com/rickbarrette/redmine_qbo.git synced 2026-04-02 08:21:57 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor persist method in EmployeeSyncService to use 'local' variable for clarity

Browse Source
This commit is contained in:
Ricky Barrette
2026-02-28 07:41:05 -05:00
parent 9a688c4841
commit d1ba93d61a
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/services/employee_sync_service.rb
View File

@@ -68,18 +68,18 @@ class EmployeeSyncService
# Create or update a local Employee record based on the QBO remote data # Create or update a local Employee record based on the QBO remote data
def persist(remote) def persist(remote)
employee = Employee.find_or_initialize_by(id: remote.id) local = Employee.find_or_initialize_by(id: remote.id)
if remote.active? if remote.active?
employee.name = remote.display_name local.name = remote.display_name
if employee.changed? if local.changed?
employee.save local.save
log "Updated employee #{remote.id}" log "Updated employee #{remote.id}"
end end
else else
if employee.persisted? if local.persisted?
employee.destroy local.destroy
log "Deleted employee #{remote.id}" log "Deleted employee #{remote.id}"
end end
end end