From cc9af5dc3680b59e67eaad3aa4587dd2c16eb248 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Thu, 10 Mar 2016 21:00:54 -0500 Subject: [PATCH] Added more garbage collection & removed automatic sync from show hook --- lib/issues_form_hook_listener.rb | 8 ++++---- lib/issues_show_hook_listener.rb | 2 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/issues_form_hook_listener.rb b/lib/issues_form_hook_listener.rb index 600e9e3..51ef934 100644 --- a/lib/issues_form_hook_listener.rb +++ b/lib/issues_form_hook_listener.rb @@ -16,12 +16,12 @@ class IssuesFormHookListener < Redmine::Hook::ViewListener # Update the customer and item database QboCustomer.update_all #QboItem.update_all - QboInvoice.update_all - QboEstimate.update_all + #QboInvoice.update_all + #QboEstimate.update_all # Check to see if there is a quickbooks user attached to the issue - @selected_customer = context[:issue].qbo_customer.id if context[:issue].qbo_customer - @selected_item = context[:issue].qbo_item.id if context[:issue].qbo_item + @selected_customer = context[:issue].qbo_customer ? context[:issue].qbo_customer.id : nil + @selected_item = context[:issue].qbo_item ? context[:issue].qbo_item.id : nil @selected_invoice = context[:issue].qbo_invoice ? context[:issue].qbo_invoice.id : nil @selected_estimate = context[:issue].qbo_estimate ? context[:issue].qbo_estimate.id : nil diff --git a/lib/issues_show_hook_listener.rb b/lib/issues_show_hook_listener.rb index 1a45245..bdba610 100644 --- a/lib/issues_show_hook_listener.rb +++ b/lib/issues_show_hook_listener.rb @@ -30,7 +30,6 @@ class IssuesShowHookListener < Redmine::Hook::ViewListener @estimate_link = nil # Estimate Number if issue.qbo_estimate - QboEstimate.update(issue.qbo_estimate.id) @estimate = issue.qbo_estimate.doc_number @estimate_link = link_to @estimate, "#{Redmine::Utils::relative_url_root }/qbo/estimate/#{issue.qbo_estimate.id}", :target => "_blank" end @@ -39,7 +38,6 @@ class IssuesShowHookListener < Redmine::Hook::ViewListener @invo = nil # Invoice Number if issue.qbo_invoice - QboInvoice.update(issue.qbo_invoice.id) @invoice = issue.qbo_invoice.doc_number @invoice_link = link_to @invoice, "#{Redmine::Utils::relative_url_root }/qbo/invoice/#{issue.qbo_invoice.id}", :target => "_blank" end