Limit estimate and invoice PDFs by permission; clean up

Any logged-in user could open any estimate or invoice PDF by id. Now:
- estimates: View customers or Write estimates, or an estimate attached
  to an issue the user can see (the issue page links to it); users
  without the permission don't trigger a sync of uncached estimates
- invoices: View customers, Write invoices, View/Receive payments or
  Issue refunds, or invoices attached to issues the user can see
- share-link customers are unchanged (their own issue's documents)
- the sidebar's estimate search only shows to those who can use it

The issue PDF merges an estimate PDF with optional content, as it
already did for the issue's own PDF, instead of failing.

Removed dead code: the JSON branches of CustomersController#create
(Redmine refuses JSON there) and the scaffold views for
qbo#authenticate, #oauth_callback and #webhook, which those actions
never render. An invalid customer now shows the form with a 422.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-20 17:36:20 -05:00
1 parent 17f24f9641
commit b829593bc2
14 files changed
+174 -99

No files matched your search

+10
View File
@@ -35,6 +35,16 @@ class RedmineQboBillingTest < ActiveSupport::TestCase
assert_not Billing.payment_viewer?(user)
end
def test_document_viewers
assert RedmineQboBilling.estimate_viewer?(user(:view_customers))
assert RedmineQboBilling.estimate_viewer?(user(:write_estimates))
assert_not RedmineQboBilling.estimate_viewer?(user(:write_invoices))
%i[view_customers write_invoices view_payments receive_payments issue_refunds].each do |permission|
assert RedmineQboBilling.invoice_viewer?(user(permission)), permission
end
assert_not RedmineQboBilling.invoice_viewer?(user(:write_estimates))
end
def test_paid_invoice_editor
assert Billing.paid_invoice_editor?(true, user(:write_invoices, :edit_paid_invoices))
assert_not Billing.paid_invoice_editor?(false, user(:write_invoices, :edit_paid_invoices))