ricky/redmine_qbo
1
1
Fork 0
mirror of https://github.com/rickbarrette/redmine_qbo.git synced 2026-02-13 09:13:58 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

loose the hash rocket, use symbol keys

Browse Source
This commit is contained in:
Ricky Barrette
2026-01-29 22:30:59 -05:00
parent f24128ef75
commit b80e1d4e28
44 changed files with 155 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/controllers/customers_controller.rb
View File

@@ -26,13 +26,13 @@ class CustomersController < ApplicationController
include SortHelper
helper :timelog
before_action :add_customer, :only => :new
before_action :view_customer, :except => [:new, :view]
skip_before_action :verify_authenticity_token, :check_if_login_required, :only => [:view]
before_action :add_customer, only: :new
before_action :view_customer, except: [:new, :view]
skip_before_action :verify_authenticity_token, :check_if_login_required, only: [:view]
default_search_scope :names
autocomplete :customer, :name, :full => true, :extra_data => [:id]
autocomplete :customer, :name, full: true, extra_data: [:id]
def allowed_params
params.require(:customer).permit(:name, :email, :primary_phone, :mobile_phone, :phone_number, :notes)
@@ -53,7 +53,7 @@ class CustomersController < ApplicationController
# display a list of all customers
def index
if params[:search]
@customers = Customer.search(params[:search]).paginate(:page => params[:page])
@customers = Customer.search(params[:search]).paginate(page: params[:page])
if only_one_non_zero?(@customers)
redirect_to @customers.first
end
@@ -161,7 +161,7 @@ class CustomersController < ApplicationController
@issue = Issue.find @token.issue_id
@journals = @issue.journals.
preload(:details).
preload(:user => :email_address).
preload(user: :email_address).
reorder(:created_on, :id).to_a
@journals.each_with_index {|j,i| j.indice = i+1}
@journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
@@ -175,7 +175,7 @@ class CustomersController < ApplicationController
@relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
@allowed_statuses = @issue.new_statuses_allowed_to(User.current)
@priorities = IssuePriority.active
@time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
@time_entry = TimeEntry.new(issue: @issue, project: @issue.project)
@relation = IssueRelation.new
rescue
render_403

12
app/controllers/estimate_controller.rb
View File

@@ -11,8 +11,8 @@ class EstimateController < ApplicationController
include AuthHelper
before_action :require_user, :unless => proc {|c| session[:token].nil? }
skip_before_action :verify_authenticity_token, :check_if_login_required, :unless => proc {|c| session[:token].nil? }
before_action :require_user, unless: proc {|c| session[:token].nil? }
skip_before_action :verify_authenticity_token, :check_if_login_required, unless: proc {|c| session[:token].nil? }
def get_estimate
# Force sync for estimate by doc number if not found
@@ -36,9 +36,9 @@ class EstimateController < ApplicationController
estimate = get_estimate
begin
send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", :disposition => 'inline', :type => "application/pdf"
send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", disposition: 'inline', type: "application/pdf"
rescue
redirect_to :back, :flash => { :error => "Estimate not found" }
redirect_to :back, flash: { error: "Estimate not found" }
end
end
@@ -49,9 +49,9 @@ class EstimateController < ApplicationController
estimate = get_estimate
begin
send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", :disposition => 'inline', :type => "application/pdf"
send_data estimate.pdf, filename: "estimate #{estimate.doc_number}.pdf", disposition: 'inline', type: "application/pdf"
rescue
redirect_to :back, :flash => { :error => "Estimate not found" }
redirect_to :back, flash: { error: "Estimate not found" }
end
end

10
app/controllers/invoice_controller.rb
View File

@@ -12,8 +12,8 @@ class InvoiceController < ApplicationController
include AuthHelper
require 'combine_pdf'
before_action :require_user, :unless => proc {|c| session[:token].nil? }
skip_before_action :verify_authenticity_token, :check_if_login_required, :unless => proc {|c| session[:token].nil? }
before_action :require_user, unless: proc {|c| session[:token].nil? }
skip_before_action :verify_authenticity_token, :check_if_login_required, unless: proc {|c| session[:token].nil? }
#
# Downloads and forwards the invoice pdf
@@ -23,7 +23,7 @@ class InvoiceController < ApplicationController
begin
qbo = Qbo.first
qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
service = Quickbooks::Service::Invoice.new(company_id: qbo.realm_id, access_token: access_token)
# If multiple id's then pull each pdf & combine them
if params[:invoice_ids]
@@ -45,10 +45,10 @@ class InvoiceController < ApplicationController
ref = invoice.doc_number
end
send_data @pdf, filename: "invoice #{ref}.pdf", :disposition => 'inline', :type => "application/pdf"
send_data @pdf, filename: "invoice #{ref}.pdf", disposition: 'inline', type: "application/pdf"
end
rescue
redirect_to :back, :flash => { :error => "Invoice not found" }
redirect_to :back, flash: { error: "Invoice not found" }
end
end
end

16
app/controllers/qbo_controller.rb
View File

@@ -14,8 +14,8 @@ class QboController < ApplicationController
include AuthHelper
before_action :require_user, :except => :webhook
skip_before_action :verify_authenticity_token, :check_if_login_required, :only => [:webhook]
before_action :require_user, except: :webhook
skip_before_action :verify_authenticity_token, :check_if_login_required, only: [:webhook]
def allowed_params
params.permit(:code, :state, :realmId, :id)
@@ -51,9 +51,9 @@ class QboController < ApplicationController
qbo.refresh_token!
if qbo.save!
redirect_to qbo_sync_path, :flash => { :notice => I18n.t(:label_connected) }
redirect_to qbo_sync_path, flash: { notice: I18n.t(:label_connected) }
else
redirect_to plugin_settings_path(:redmine_qbo), :flash => { :error => I18n.t(:label_error) }
redirect_to plugin_settings_path(:redmine_qbo), flash: { error: I18n.t(:label_error) }
end
end
@@ -65,9 +65,9 @@ class QboController < ApplicationController
i = Issue.find_by_id params[:id]
if i.customer
i.bill_time
redirect_to i, :flash => { :notice => I18n.t(:label_billed_success) + i.customer.name }
redirect_to i, flash: { notice: I18n.t(:label_billed_success) + i.customer.name }
else
redirect_to i, :flash => { :error => I18n.t(:label_billing_error) }
redirect_to i, flash: { error: I18n.t(:label_billing_error) }
end
end
@@ -125,7 +125,7 @@ class QboController < ApplicationController
ActiveRecord::Base.connection.close
end
# The webhook doesn't require a response but let's make sure we don't send anything
render :nothing => true, status: 200
render nothing: true, status: 200
else
render nothing: true, status: 400
end
@@ -152,6 +152,6 @@ class QboController < ApplicationController
ActiveRecord::Base.connection.close
end
redirect_to :home, :flash => { :notice => I18n.t(:label_syncing) }
redirect_to :home, flash: { notice: I18n.t(:label_syncing) }
end
end