mirror of
https://github.com/rickbarrette/redmine_qbo.git
synced 2026-11-17 18:20:36 -05:00
Fix duplicate estimates: make QuickBooks ids unique
The customers, employees, estimates and invoices tables were created with t.integer :id, options: 'PRIMARY KEY', which Rails ignores, so the QuickBooks id was never unique. Two syncs of the same record at once (saving an estimate in Redmine, then QuickBooks' webhook) inserted it twice, so it showed twice on the customer page and counted twice on the business report. - Migration 050 keeps one row per id (the most recently updated) and adds a unique index on id. - A sync that collides with another one's insert retries once as an update. - Estimates, customers and employees validate a unique id, like invoices already did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
5 files changed
+65
-2
No files matched your search
@@ -201,8 +201,10 @@ class SyncServiceBase
|
||||
Rails.logger.info "[#{@entity.name}SyncService] #{msg}"
|
||||
end
|
||||
|
||||
# Create or update a local entity record based on the QBO remote data
|
||||
def persist(remote)
|
||||
# Create or update a local entity record based on the QBO remote data. If another sync inserts the same
|
||||
# record at the same moment (e.g. a save in Redmine and QuickBooks' webhook), the database's unique id
|
||||
# refuses the second insert; it's then retried once as an update of the row the other sync created.
|
||||
def persist(remote, retried: false)
|
||||
local = @entity.find_or_initialize_by(id: remote.id)
|
||||
|
||||
if destroy_local?(remote)
|
||||
@@ -223,6 +225,12 @@ class SyncServiceBase
|
||||
attach_documents(local, remote)
|
||||
end
|
||||
|
||||
rescue ActiveRecord::RecordNotUnique, ActiveRecord::RecordInvalid => e
|
||||
if !retried && (e.is_a?(ActiveRecord::RecordNotUnique) || @entity.exists?(id: remote.id))
|
||||
log "#{@entity.name} #{remote.id} was saved by another sync meanwhile; updating it instead"
|
||||
return persist(remote, retried: true)
|
||||
end
|
||||
log "Failed to sync #{@entity.name} #{remote.id}: #{e.message}"
|
||||
rescue => e
|
||||
log "Failed to sync #{@entity.name} #{remote.id}: #{e.message}"
|
||||
end
|
||||
|
||||
Reference in new issue
Block a user