Fix duplicate estimates: make QuickBooks ids unique

The customers, employees, estimates and invoices tables were created with
t.integer :id, options: 'PRIMARY KEY', which Rails ignores, so the QuickBooks id was never unique. Two
syncs of the same record at once (saving an estimate in Redmine, then QuickBooks' webhook) inserted it
twice, so it showed twice on the customer page and counted twice on the business report.

- Migration 050 keeps one row per id (the most recently updated) and adds a unique index on id.
- A sync that collides with another one's insert retries once as an update.
- Estimates, customers and employees validate a unique id, like invoices already did.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
Claude committed 2026-10-31 11:48:23 -04:00
1 parent 388ac915d7
commit b739b84917
5 files changed
+65 -2

No files matched your search

+1
View File
@@ -18,6 +18,7 @@ class Customer < QboBaseModel
has_many :estimates
has_many :payments
validates_presence_of :name
validates :id, uniqueness: true, allow_nil: true
before_validation :normalize_phone_numbers
self.primary_key = :id
qbo_sync push: true
+1
View File
@@ -12,6 +12,7 @@ class Employee < QboBaseModel
has_many :users
validates_presence_of :id, :name
validates :id, uniqueness: true
self.primary_key = :id
qbo_sync push: false
+1
View File
@@ -13,6 +13,7 @@ class Estimate < QboBaseModel
has_many :issues
belongs_to :customer
validates_presence_of :doc_number, :id
validates :id, uniqueness: true
self.primary_key = :id
qbo_sync push: false
+10 -2
View File
@@ -201,8 +201,10 @@ class SyncServiceBase
Rails.logger.info "[#{@entity.name}SyncService] #{msg}"
end
# Create or update a local entity record based on the QBO remote data
def persist(remote)
# Create or update a local entity record based on the QBO remote data. If another sync inserts the same
# record at the same moment (e.g. a save in Redmine and QuickBooks' webhook), the database's unique id
# refuses the second insert; it's then retried once as an update of the row the other sync created.
def persist(remote, retried: false)
local = @entity.find_or_initialize_by(id: remote.id)
if destroy_local?(remote)
@@ -223,6 +225,12 @@ class SyncServiceBase
attach_documents(local, remote)
end
rescue ActiveRecord::RecordNotUnique, ActiveRecord::RecordInvalid => e
if !retried && (e.is_a?(ActiveRecord::RecordNotUnique) || @entity.exists?(id: remote.id))
log "#{@entity.name} #{remote.id} was saved by another sync meanwhile; updating it instead"
return persist(remote, retried: true)
end
log "Failed to sync #{@entity.name} #{remote.id}: #{e.message}"
rescue => e
log "Failed to sync #{@entity.name} #{remote.id}: #{e.message}"
end