From 9fd6e90c81e7f44268ac6e6a88a20ac921fd1ba1 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 31 Oct 2026 00:12:03 -0400 Subject: [PATCH] Drop QuickBooks estimate and payment links from customer actions Estimates and payments are handled in Redmine; each action shows only to users with its permission. The customer's name still links to their QuickBooks account page as a fallback. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM --- README.md | 4 ++-- app/views/customers/show.html.erb | 9 ++------- config/locales/en.yml | 1 - 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 30831df..18e336a 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ Customer records are automatically updated in the local database when changes oc ## Billing: Estimates, Invoices and Payments -* **New estimate** from the customer page (the Create Estimate link opens the Redmine editor instead of QuickBooks). +* **New estimate** from the customer page: Create Estimate opens the Redmine editor. The customer page no longer links to QuickBooks' estimate or payment screens; the customer's name still opens their QuickBooks account page as a fallback. * **Edit** any estimate from the Edit link next to it on the customer page or the issue page. * **Duplicate** an estimate to start a similar one: same customer, lines, subtotals, VIN and messages, dated today, with the current user as sales person. * **Read-only once linked to an issue**: an estimate that an issue is linked to can be viewed, emailed and duplicated, but not changed, so the work doesn't drift from what was quoted. The list shows a View link for these instead of Edit. @@ -124,7 +124,7 @@ Customer records are automatically updated in the local database when changes oc ### Payments -* **Receive payment** on the customer page (it replaces the link to QuickBooks' receive payment screen) or on an unpaid invoice: the customer, payment date, payment method (QuickBooks' list: Cash, Check...), reference number (e.g. the check number), amount and a memo. +* **Receive payment** on the customer page or on an unpaid invoice: the customer, payment date, payment method (QuickBooks' list: Cash, Check...), reference number (e.g. the check number), amount and a memo. * Tick open invoices to fill in the amount (their open balances added up) and pay just those; the header box ticks them all. * With none ticked, the payment is applied to the customer's open invoices **oldest first**, like QuickBooks does; the page shows how it will be split as the amount is typed, and it's worked out again from QuickBooks when saving. Anything more than the open balances stays as a credit. * Tick **Deposit** to keep the whole payment as a credit on the customer's account without paying any invoice (also what happens when there are no open invoices). diff --git a/app/views/customers/show.html.erb b/app/views/customers/show.html.erb index 3ac91f6..54db347 100644 --- a/app/views/customers/show.html.erb +++ b/app/views/customers/show.html.erb @@ -4,12 +4,10 @@ id: 'dynamic-new-issue-link', class: 'icon icon-add', target: :_blank %> <%# Plugins add their customer actions here (e.g. redmine_qbo_calendar's Add appointment) %> <%= call_hook :view_customers_show_contextual, { customer: @customer } %> - <%# Estimates, invoices and payments are written here; users without those permissions get QuickBooks' screens %> + <%# Estimates, invoices and payments are handled here, each shown to users with its permission. The customer's + name below links to their QuickBooks account page as a fallback. %> <% if RedmineQboBilling.writer? %> <%= render partial: 'qbo_estimates/customer_link', locals: { customer: @customer } %> - <% else %> - <%= link_to sprite_icon('document', l(:label_create_estimate)), "https://qbo.intuit.com/app/estimate?nameId=#{@customer.id}", - class: 'icon icon-document', target: :_blank %> <% end %> <% if RedmineQboBilling.invoice_writer? %> <%= render partial: 'qbo_invoices/customer_link', locals: { customer: @customer } %> @@ -19,9 +17,6 @@ <% end %> <% if RedmineQboBilling.payment_receiver? %> <%= link_to sprite_icon('add', l(:button_receive_payment)), new_qbo_payment_path(customer_id: @customer.id), class: 'icon icon-add' %> - <% else %> - <%= link_to sprite_icon('add', l(:label_create_payment)), "https://qbo.intuit.com/app/recvpayment?nameId=#{@customer.id}", - class: 'icon icon-add', target: :_blank %> <% end %> <% if User.current.allowed_to?(:edit_customers, nil, global: true) %> <%= link_to sprite_icon('edit', l(:button_edit)), edit_customer_path(@customer), diff --git a/config/locales/en.yml b/config/locales/en.yml index 9fa101e..b52180c 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -37,7 +37,6 @@ en: label_closed_issues: "Closed Issues" label_connected: "Successfully connected to QuickBooks" label_create_estimate: "Create Estimate" - label_create_payment: "Create Payment" label_customer_count: "Customer Count" label_customer_link_expires: "This customer link expires in" label_customer: "Customer"