From 9201c4ca96927d618c002550913b57890417a0a1 Mon Sep 17 00:00:00 2001 From: Ricky Barrette Date: Sun, 6 Mar 2022 09:23:05 -0500 Subject: [PATCH] render 404 on all exceptions --- app/controllers/customers_controller.rb | 8 ++++---- app/controllers/vehicles_controller.rb | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/controllers/customers_controller.rb b/app/controllers/customers_controller.rb index 9494fcd..cb91fb2 100644 --- a/app/controllers/customers_controller.rb +++ b/app/controllers/customers_controller.rb @@ -93,7 +93,7 @@ class CustomersController < ApplicationController @billing_address = address_to_s(@customer.billing_address) @shipping_address = address_to_s(@customer.shipping_address) @closed_issues = (@issues - @issues.open) - rescue ActiveRecord::RecordNotFound + rescue render_404 end end @@ -102,7 +102,7 @@ class CustomersController < ApplicationController def edit begin @customer = Customer.find_by_id(params[:id]) - rescue ActiveRecord::RecordNotFound + rescue render_404 end end @@ -118,7 +118,7 @@ class CustomersController < ApplicationController redirect_to edit_customer_path flash[:error] = @customer.errors.full_messages.to_sentence if @customer.errors end - rescue ActiveRecord::RecordNotFound + rescue render_404 end end @@ -129,7 +129,7 @@ class CustomersController < ApplicationController Customer.find_by_id(params[:id]).destroy flash[:notice] = "Customer deleted successfully" redirect_to action: :index - rescue ActiveRecord::RecordNotFound + rescue render_404 end end diff --git a/app/controllers/vehicles_controller.rb b/app/controllers/vehicles_controller.rb index 4336821..66648cd 100644 --- a/app/controllers/vehicles_controller.rb +++ b/app/controllers/vehicles_controller.rb @@ -64,7 +64,7 @@ class VehiclesController < ApplicationController @vin = @vehicle.vin.scan(/.{1,9}/) if @vehicle.vin @issues = @vehicle.issues.order(id: :desc) @closed_issues = (@issues - @issues.open) - rescue ActiveRecord::RecordNotFound + rescue render_404 end end @@ -74,7 +74,7 @@ class VehiclesController < ApplicationController begin @vehicle = Vehicle.find_by_id(params[:id]) @customer = @vehicle.customer - rescue ActiveRecord::RecordNotFound + rescue render_404 end end @@ -92,7 +92,7 @@ class VehiclesController < ApplicationController end #show any errors anyways flash[:error] = @vehicle.errors.full_messages.to_sentence unless @vehicle.errors.empty? - rescue ActiveRecord::RecordNotFound + rescue render_404 end end @@ -103,7 +103,7 @@ class VehiclesController < ApplicationController Vehicle.find_by_id(params[:id]).destroy flash[:notice] = "Vehicle deleted successfully" redirect_to action: :index - rescue ActiveRecord::RecordNotFound + rescue render_404 end end