From 8838d3679383d8624119cc3a8f0e5ac725244cb4 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Sat, 3 Mar 2018 13:54:19 -0500 Subject: [PATCH] Fixed vin decoding --- app/models/vehicle.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/models/vehicle.rb b/app/models/vehicle.rb index 0e5d771..716bf85 100644 --- a/app/models/vehicle.rb +++ b/app/models/vehicle.rb @@ -83,15 +83,15 @@ class Vehicle < ActiveRecord::Base where("vin LIKE ?", "%#{search}%") end - private +private # init method to pull JSON details from Edmunds def get_details if self.vin? begin query = NhtsaVin.get(self.vin) - raise error if not @details.valid? - @details = query.response = NhtsaVin.get(self.vin) + raise RuntimeError, query.error unless query.valid? + @details = query.response rescue Exception => e errors.add(:vin, e.message) end @@ -103,9 +103,9 @@ class Vehicle < ActiveRecord::Base get_details if @details begin - self.year = @details.year - self.make = @details.make - self.model = @details.model + self.year = @details.year unless @details.year.nil? + self.make = @details.make unless @details.make.nil? + self.model = @details.model unless @details.model.nil? rescue Exception => e errors.add(:vin, e.message) end