Inital update for redmine 4.0+ compatibility

lib/pdf_patch.rb

@@ -1,3 +1,13 @@
+#The MIT License (MIT)
+#
+#Copyright (c) 2022 rick barrette
+#
+#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+#
+#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+#
+#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
 require_dependency 'redmine/export/pdf'
 require_dependency 'redmine/export/pdf/issues_pdf_helper'
 
@@ -7,7 +17,9 @@ module IssuesPdfHelperPatch
     base.send(:include, InstanceMethods)
     base.class_eval do
       unloadable # Send unloadable so it will not be unloaded in development
-      alias_method_chain :issue_to_pdf, :patch
+      alias_method :issue_to_pdf, :issue_to_pdf_with_patch
+      alias_method :issue_to_pdf_with_patch, :issue_to_pdf
+      
     end
   end
 

lib/query_patch.rb

@@ -1,6 +1,6 @@
 #The MIT License (MIT)
 #
-#Copyright (c) 2017 rick barrette
+#Copyright (c) 2022 rick barrette
 #
 #Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 #
@@ -11,62 +11,24 @@
 require_dependency 'issue_query'
 
 module QueryPatch
-
-  def self.included(base) # :nodoc:
-    base.extend(ClassMethods)
-
-    base.send(:include, InstanceMethods)
-
-    # Same as typing in the class 
-    base.class_eval do
-      unloadable # Send unloadable so it will not be unloaded in development
-      
-      alias_method_chain :available_columns, :qbo
-      alias_method_chain :available_filters, :qbo
+  
+  # Add qbo options to the aviable columns
+  def available_columns
+    unless @available_columns
+      @available_columns = self.class.available_columns.dup
+      @available_columns << QueryColumn.new(:customer, :sortable => "#{Customer.table_name}.name", :groupable => true, :caption => :field_customer)
+      @available_columns << QueryColumn.new(:qbo_billed, :sortable => "#{TimeEntry.table_name}.qbo_billed", :groupable => true, :caption => :field_qbo_billed)
     end
-  end
-      
-  module ClassMethods
-    
+    super
   end
   
-  module InstanceMethods
-  
-    def available_columns_with_qbo
-      unless @available_columns
-        @available_columns = available_columns_without_qbo
-        @available_columns << QueryColumn.new(:customer, :sortable => "#{Customer.table_name}.name", :groupable => true, :caption => :field_customer)
-        @available_columns << QueryColumn.new(:qbo_billed, :sortable => "#{TimeEntry.table_name}.qbo_billed", :groupable => true, :caption => :field_qbo_billed)
-      end
-      @available_columns
-    end
-    
-    def available_filters_with_qbo
-      unless @available_filters
-        @available_filters = available_filters_without_qbo 
-        
-        #qbo_filters = {
-        #  :customer => { 
-        #    :id => l(:field_customer),
-        #    :type => :integer, 
-        #    :order => @available_filters.size + 1},
-        #}
-        
-        #qbo_filters = { 
-        #  "customer_id" => {
-        #    :id => :customer_id,
-        #    :type => :list_optional
-            #:order => @available_filters.size + 1,
-            #:values => Customer.find(:all).collect { |c| [c.name, c.id.to_s]}
-        #  }
-        #}
-        
-        #@available_filters.merge!(qbo_filters)
-      end
-      @available_filters
-    end
+  # Add customers to filters
+  def initialize_available_filters
+    add_available_filter "customer", :type => :text
+    super
   end
+
 end
 
 # Add module to Issue
-IssueQuery.send(:include, QueryPatch)
+IssueQuery.send(:prepend, QueryPatch)

lib/time_entry_query_patch.rb

@@ -1,6 +1,6 @@
 #The MIT License (MIT)
 #
-#Copyright (c) 2017 rick barrette
+#Copyright (c) 2022 rick barrette
 #
 #Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 #
@@ -12,60 +12,22 @@ require_dependency 'time_entry_query'
 
 module TimeEntryQueryPatch
 
-  def self.included(base) # :nodoc:
-    base.extend(ClassMethods)
-
-    base.send(:include, InstanceMethods)
-
-    # Same as typing in the class 
-    base.class_eval do
-      unloadable # Send unloadable so it will not be unloaded in development
-      
-      alias_method_chain :available_columns, :qbo_billed
-      alias_method_chain :available_filters, :qbo_billed
+  # Add QBO options to columns
+  def available_columns
+    unless @available_columns
+      @available_columns = self.class.available_columns.dup
+      @available_columns << QueryColumn.new(:qbo_billed, :sortable => "#{TimeEntry.table_name}.name", :groupable => true, :caption => :field_qbo_billed)
     end
-  end
-      
-  module ClassMethods
-    
+    super
   end
   
-  module InstanceMethods
-  
-    def available_columns_with_qbo_billed
-      unless @available_columns
-        @available_columns = available_columns_without_qbo
-        @available_columns << QueryColumn.new(:qbo_billed, :sortable => "#{TimeEntry.table_name}.name", :groupable => true, :caption => :field_qbo_billed)
-      end
-      @available_columns
-    end
-    
-    def available_filters_with_qbo_billed
-      unless @available_filters
-        @available_filters = available_filters_without_qbo 
-        
-        #qbo_filters = {
-        #  :customer => { 
-        #    :id => l(:field_qbo_billed),
-        #    :type => :boolean, 
-        #    :order => @available_filters.size + 1},
-        #}
-        
-        qbo_filters = { 
-          "qbo_billed" => {
-            :id => :qbo_billed,
-            :type => :list_optional, 
-            :order => @available_filters.size + 1,
-            #:values => Customer.find(:all).collect { |c| [c.name, c.id.to_s]}
-          }
-        }
-        
-        @available_filters.merge!(qbo_filters)
-      end
-      @available_filters
-    end
+  # Add QBO options to the filter
+  def initialize_available_filters
+    add_available_filter "qbo_billed", :type => :boolean
+    super
   end
+
 end
 
 # Add module to TimeEntryQuery
-TimeEntryQuery.send(:include, QueryPatch)
+TimeEntryQuery.send(:prepend, QueryPatch)