From 7b63e64da0e4d2c305a9880c50a5429afb0c779d Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Wed, 2 Mar 2016 14:43:22 -0500 Subject: [PATCH] Update qbo_invoice.rb Loose the loop! --- app/models/qbo_invoice.rb | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/app/models/qbo_invoice.rb b/app/models/qbo_invoice.rb index 837a605..3c00944 100644 --- a/app/models/qbo_invoice.rb +++ b/app/models/qbo_invoice.rb @@ -18,14 +18,15 @@ class QboInvoice < ActiveRecord::Base Qbo.get_base(:invoice) end - def self.update_all + def self.update_all + #Pull the invoices from the quickbooks server invoices = get_base.service.all + ids = invoices.map {|i| i.id} + doc_numbers = invoices.map {|i| i.doc_number} + # Update the invoice table - invoices.each { | invoice | - find_or_create_by(id: invoice.id) do |i| - i.doc_number - end - } + find_or_create_by(id: ids, doc_number: doc_numbers) + #remove deleted invoices where.not(invoices.map(&:id)).destroy_all end