From 65be0c5f7a6b3bd5856a127b4d21eaac3d950f57 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Mon, 29 Feb 2016 09:39:33 -0500 Subject: [PATCH] Update qbo_item.rb Simplified Item Deletion --- app/models/qbo_item.rb | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/app/models/qbo_item.rb b/app/models/qbo_item.rb index 626d7f0..104d12d 100644 --- a/app/models/qbo_item.rb +++ b/app/models/qbo_item.rb @@ -19,23 +19,16 @@ class QboItem < ActiveRecord::Base end def self.update_all - service = get_base.service + items = get_base.service.all.find_by(:type, "Service") # Update the item table - service.find_by(:type, "Service").each { |item| + items.each { |item| qbo_item = QboItem.find_or_create_by(id: item.id) qbo_item.name = item.name - qbo_item.id = item.id qbo_item.save! } #remove deleted items - all.each { |item| - begin - service.fetch_by_id(item.id) - rescue - delete_all(id: item.id) - end - } + where.not(items.map(&:id)).destroy_all end end