From 88a6be0d274b18eb5915d75d98e852f54ed22a74 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Sat, 3 Mar 2018 12:26:25 -0500 Subject: [PATCH 1/3] Remove Edmunds API Key Setting --- app/views/qbo/_settings.html.erb | 8 -------- 1 file changed, 8 deletions(-) diff --git a/app/views/qbo/_settings.html.erb b/app/views/qbo/_settings.html.erb index 3821a88..70c98fe 100644 --- a/app/views/qbo/_settings.html.erb +++ b/app/views/qbo/_settings.html.erb @@ -20,14 +20,6 @@ intuit.ipp.anywhere.setup({menuProxy: '/path/to/blue-dot', grantUrl: '<%= qbo_au - - - - From 667d0bfa97f0ae3627a152e568419995888ddb19 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Sat, 3 Mar 2018 12:38:56 -0500 Subject: [PATCH 2/3] Remove Edmunds API & Added NhtsaVin --- app/models/vehicle.rb | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/app/models/vehicle.rb b/app/models/vehicle.rb index 0bf4fb1..b51a9d8 100644 --- a/app/models/vehicle.rb +++ b/app/models/vehicle.rb @@ -41,7 +41,7 @@ class Vehicle < ActiveRecord::Base # returns the style of the vehicle def style begin - return @details['years'][0]['styles'][0]['name'] if @details + return @details.trim if @details rescue return nil end @@ -49,12 +49,12 @@ class Vehicle < ActiveRecord::Base # returns the drive of the vehicle i.e. 2 wheel, 4 wheel, ect. def drive - return @details['drivenWheels'].to_s.upcase if @details + return @details.drive_type if @details end # returns the number of doors of the vehicle def doors - return @details['numOfDoors'] if @details + return @details.doors if @details end # Force Upper Case for VIN numbers @@ -87,28 +87,23 @@ class Vehicle < ActiveRecord::Base def get_details if self.vin? begin - @details = JSON.parse get_decoder.full(self.vin) - raise @details['message'] if @details['status'].to_s.eql? "NOT_FOUND" - raise @details['message'] if @details['status'].to_s.eql? "BAD_REQUEST" + query = NhtsaVin.get(self.vin) + raise error if not @details.valid? + @details = query.response = NhtsaVin.get(self.vin) rescue Exception => e errors.add(:vin, e.message) end end end - # returns the Edmunds decoder service - def get_decoder - return decoder = Edmunds::Vin.new(Setting.plugin_redmine_qbo['settingsEdmundsAPIKey']) - end - # decodes a vin and updates self def decode_vin get_details if @details begin - self.year = @details['years'][0]['year'] - self.make = @details['make']['name'] - self.model = @details['model']['name'] + self.year = @details.year + self.make = @details.make + self.model = @details.model rescue Exception => e errors.add(:vin, e.message) end From 17183f96435bcc63e61f11a77b2c89f2aaf4d772 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Sat, 3 Mar 2018 13:11:58 -0500 Subject: [PATCH 3/3] Update vehicle.rb --- app/models/vehicle.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/models/vehicle.rb b/app/models/vehicle.rb index b51a9d8..0e5d771 100644 --- a/app/models/vehicle.rb +++ b/app/models/vehicle.rb @@ -49,7 +49,9 @@ class Vehicle < ActiveRecord::Base # returns the drive of the vehicle i.e. 2 wheel, 4 wheel, ect. def drive - return @details.drive_type if @details + #todo fix this + #return @details.drive_type if @details + return nil end # returns the number of doors of the vehicle
Edmunds API Key - -
Intuit QBO OAuth Consumer Key