Estimates QuickBooks can't read raise an ordinary error

EstimateService had no build_qbo_remote, so a failed read fell back to
ServiceBase's NotImplementedError, which rescue StandardError misses (e.g.
saving an appointment with an estimate while QuickBooks was down gave a 500).
Tests keep refund emails off redmine_qbo_reminders' SMTP server.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-20 21:50:22 -05:00
1 parent 7029aa70dc
commit 62d767b695
3 files changed
+50

No files matched your search

+8
View File
@@ -12,6 +12,14 @@ require File.expand_path('../../../test/test_helper', __dir__)
require File.expand_path('qbo_fake_service', __dir__)
require File.expand_path('qbo_editor_test_helper', __dir__)
# With redmine_qbo_reminders installed, refund emails go out through its SMTP server
# (smtp-relay.gmail.com by default). Keep tests on Redmine's own (test) delivery.
if defined?(RedmineQboReminders::Settings)
ActiveSupport::TestCase.setup do
Setting.plugin_redmine_qbo_reminders = { 'delivery' => 'redmine' }
end
end
module QboRefundTestHelper
CUSTOMER_ID = 9101