mirror of
https://github.com/rickbarrette/redmine_qbo.git
synced 2026-11-21 02:50:36 -05:00
Estimates QuickBooks can't read raise an ordinary error
EstimateService had no build_qbo_remote, so a failed read fell back to ServiceBase's NotImplementedError, which rescue StandardError misses (e.g. saving an appointment with an estimate while QuickBooks was down gave a 500). Tests keep refund emails off redmine_qbo_reminders' SMTP server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
7029aa70dc
commit
62d767b695
3 files changed
+50
No files matched your search
@@ -9,5 +9,15 @@
|
||||
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
||||
|
||||
class EstimateService < ServiceBase
|
||||
# Raised when an estimate can't be read from QuickBooks (e.g. QuickBooks is down or disconnected)
|
||||
class FetchError < StandardError; end
|
||||
|
||||
private
|
||||
|
||||
# Estimates are only read here (EstimateWriter saves them). When the read fails, raise an ordinary error
|
||||
# rather than ServiceBase's NotImplementedError, which callers' `rescue StandardError` would miss; nothing
|
||||
# is cached, so the next read tries QuickBooks again.
|
||||
def build_qbo_remote
|
||||
raise FetchError, "Could not read estimate ##{@local.id} from QuickBooks"
|
||||
end
|
||||
end
|
||||
Reference in new issue
Block a user