Implement issue creation error handling; add project validation and refactored issue hooks

config/locales/en.yml

@@ -100,5 +100,4 @@ en:
   notice_forbidden: "You do not have permission to access this resource"
   notice_issue_not_found: "Issue not found"
   customer_details: "Customer Details"
-  notice_error_project_nil: "The issue's project is nil."
-  notice_error_project_nil: "The issue's tracker is nil."
+  notice_error_project_nil: "The issue's project is nil, set project to: "

lib/redmine_qbo/hooks/issues_hook_listener.rb

@@ -10,11 +10,22 @@
 
 module RedmineQbo
   module Hooks
-
-    class IssuesFormHookListener < Redmine::Hook::ViewListener
+    class IssuesHookListener < Redmine::Hook::ViewListener
 
       include IssuesHelper
 
+      # Check the new issue form for a valid project.
+      # This is added to help prevent 422 unprocessable entity errors when creating an issue 
+      # See https://github.com/redmine/redmine/blob/84483d63828d0cb2efbf5bd786a2f0d22e34c93d/app/controllers/issues_controller.rb#L179
+      def controller_issues_new_before_save(context={})
+        if context[:issue].project.nil?
+          context[:issue].project = projects_for_select(context[:issue]).first
+          context[:controller].flash[:error] = I18n.t(:notice_error_project_nil) + context[:issue].project.to_s
+        end
+
+        return context
+      end
+
       # Edit Issue Form
       # Here we build the required form components before passing them to a partial view formatting. 
       def view_issues_form_details_bottom(context={})
@@ -54,7 +65,31 @@ module RedmineQbo
           }
         )
       end
+
+      # View Issue
+      # Displays the quickbooks customer, estimate, & invoices attached to the issue
+      def view_issues_show_details_bottom(context={})
+        issue = context[:issue]
+        
+        # Build a list of invoice links
+        invoice_link = ""
+        if issue.invoices
+          issue.invoices.each do |i|
+            invoice_link += "#{link_to i, i, target: :_blank}<br/>"
+          end
+        end
+        
+        context[:controller].send(:render_to_string, {
+          partial: 'issues/show_details',
+            locals: {
+              customer: issue.customer ? link_to(issue.customer) : nil, 
+              estimate_link: issue.estimate ? link_to(issue.estimate, issue.estimate, target: :_blank) : nil, 
+              invoice_link: invoice_link.html_safe,
+              issue: issue
+            } 
+          })
       end
       
     end
+  end 
 end

lib/redmine_qbo/hooks/issues_show_hook_listener.rb

@@ -1,43 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-module RedmineQbo
-  module Hooks
-
-    class IssuesShowHookListener < Redmine::Hook::ViewListener
-
-      # View Issue
-      # Displays the quickbooks customer, estimate, & invoices attached to the issue
-      def view_issues_show_details_bottom(context={})
-        issue = context[:issue]
-        
-        # Build a list of invoice links
-        invoice_link = ""
-        if issue.invoices
-          issue.invoices.each do |i|
-            invoice_link += "#{link_to i, i, target: :_blank}<br/>"
-          end
-        end
-        
-        context[:controller].send(:render_to_string, {
-          partial: 'issues/show_details',
-            locals: {
-              customer: issue.customer ? link_to(issue.customer) : nil, 
-              estimate_link: issue.estimate ? link_to(issue.estimate, issue.estimate, target: :_blank) : nil, 
-              invoice_link: invoice_link.html_safe,
-              issue: issue
-            } 
-          })
-      end
-      
-    end
-
-  end 
-end

lib/redmine_qbo/patches/issues_controller_patch.rb

@@ -24,28 +24,8 @@ module RedmineQbo
       def self.included(base)
         base.class_eval do
           helper Helper
-          before_action :error_check, only: [:create]
         end
       end 
-
-      # Check for errors when creating an issue. 
-      # If the project or tracker is not set, reload the new issue form with an error message.
-      def error_check
-        logger.info "Creating issue for: #{@issue.project}"
-        
-        if @issue.project.nil?
-          @issue.project = Project.first
-          flash[:error] = t :notice_error_project_nil 
-          render :new, status: :unprocessable_entity
-        end
-
-        if @issue.tracker.nil?
-          @issue.tracker = Tracker.first
-          flash[:error] = t :notice_error_tracker_nil 
-          render :new, status: :unprocessable_entity
-        end
-      end
-
     end
 
     # Add module to IssuessController