Use rails router, not hard coded links

This commit is contained in:
2022-03-09 19:05:12 -05:00
parent 8e6eeab680
commit 13bbd5dfc1

View File

@@ -17,13 +17,13 @@ class IssuesShowHookListener < Redmine::Hook::ViewListener
# Check to see if there is a quickbooks user attached to the issue # Check to see if there is a quickbooks user attached to the issue
if issue.customer if issue.customer
customer = link_to issue.customer.name, "#{Redmine::Utils::relative_url_root}/customers/#{issue.customer.id}" customer = link_to issue.customer.name, customer_path( issue.customer.id )
end end
# Estimate Number # Estimate Number
if issue.qbo_estimate if issue.qbo_estimate
estimate = issue.qbo_estimate.doc_number estimate = issue.qbo_estimate.doc_number
estimate_link = link_to estimate, "#{Redmine::Utils::relative_url_root}/qbo/estimate/#{issue.qbo_estimate.id}", :target => "_blank" estimate_link = link_to estimate, estimate_path( issue.qbo_estimate.id ), :target => "_blank"
end end
# Invoice Number # Invoice Number
@@ -31,14 +31,14 @@ class IssuesShowHookListener < Redmine::Hook::ViewListener
if issue.qbo_invoice_ids if issue.qbo_invoice_ids
issue.qbo_invoice_ids.each do |i| issue.qbo_invoice_ids.each do |i|
invoice = QboInvoice.find i invoice = QboInvoice.find i
invoice_link = invoice_link + link_to( invoice.doc_number, "#{Redmine::Utils::relative_url_root}/qbo/invoice/#{i}", :target => "_blank").to_s + " " invoice_link = invoice_link + link_to( invoice.doc_number, invoice_path( i ), :target => "_blank").to_s + " "
invoice_link = invoice_link.html_safe invoice_link = invoice_link.html_safe
end end
end end
begin begin
v = Vehicle.find(issue.vehicles_id) v = Vehicle.find(issue.vehicles_id)
vehicle = link_to v.to_s, "#{Redmine::Utils::relative_url_root}/vehicles/#{v.id}" vehicle = link_to v.to_s, vehicle_path( v.id )
vin = v.vin vin = v.vin
notes = v.notes notes = v.notes
rescue rescue
@@ -61,8 +61,8 @@ class IssuesShowHookListener < Redmine::Hook::ViewListener
end end
def view_issues_show_description_bottom(context={}) def view_issues_show_description_bottom(context={})
bill_button = button_to "Bill Time", "#{Redmine::Utils::relative_url_root}/qbo/bill/#{context[:issue].id}", method: :get if User.current.admin? bill_button = button_to "Bill Time", bill_path( context[:issue].id ), method: :get if User.current.admin?
share_button = button_to "Share", "#{Redmine::Utils::relative_url_root}/customers/share/#{context[:issue].id}", method: :get if User.current.logged? share_button = button_to "Share", share_path( context[:issue].id ), method: :get if User.current.logged?
return "<br/> #{bill_button} #{share_button}" return "<br/> #{bill_button} #{share_button}"
end end