From 11b9876d4f114b2ae77bf055775a90b8201cbd35 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Wed, 11 Feb 2026 08:09:00 -0500 Subject: [PATCH] Removed unused controller_issues_new_before_save that was used for finding the 422 error --- lib/redmine_qbo/hooks/issues_hook_listener.rb | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/lib/redmine_qbo/hooks/issues_hook_listener.rb b/lib/redmine_qbo/hooks/issues_hook_listener.rb index 321bf0b..bac5c77 100644 --- a/lib/redmine_qbo/hooks/issues_hook_listener.rb +++ b/lib/redmine_qbo/hooks/issues_hook_listener.rb @@ -14,36 +14,6 @@ module RedmineQbo include IssuesHelper - # Check the new issue form for a valid project. - # This is added to help prevent 422 unprocessable entity errors when creating an issue - # See https://github.com/redmine/redmine/blob/84483d63828d0cb2efbf5bd786a2f0d22e34c93d/app/controllers/issues_controller.rb#L179 - def controller_issues_new_before_save(context={}) - - Rails.logger.debug "RedmineQbo::Hooks::IssuesHookListener.controller_issues_new_before_save: Checking for nil project or tracker" - Rails.logger.debug context[:params].inspect - Rails.logger.debug context[:issue].inspect - Rails.logger.debug context[:issue].project - Rails.logger.debug context[:issue].tracker - error = "" - if context[:issue].project.nil? - context[:issue].project ||= projects_for_select(context[:issue]).first - Rails.logger.error I18n.t(:notice_error_project_nil) + context[:issue].project.to_s - error = I18n.t(:notice_error_project_nil) + context[:issue].project.to_s - end - - if context[:issue].tracker.nil? - context[:issue].tracker ||= trackers_for_select(context[:issue]).first - Rails.logger.error I18n.t(:notice_error_tracker_nil) + context[:issue].tracker.to_s - error << "\n" - error << I18n.t(:notice_error_tracker_nil) + context[:issue].tracker.to_s - end - - context[:controller].flash[:error] = error unless error.blank? - Rails.logger.debug error unless error.blank? - - return context - end - # Edit Issue Form # Here we build the required form components before passing them to a partial view formatting. def view_issues_form_details_bottom(context={}) @@ -62,7 +32,6 @@ module RedmineQbo value: '#issue_customer' } - js_path = "updateIssueFrom('/issues/new.js', this)" js_path = "updateIssueFrom('#{escape_javascript update_issue_form_path(issue.project, issue)}', this)" unless issue.new_record? # This hidden field is used for the customer ID for the issue