ricky/redmine_qbo
1
1
Fork 0
mirror of https://github.com/rickbarrette/redmine_qbo.git synced 2025-11-08 17:04:23 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed returned variable handling

Browse Source
This commit is contained in:
Ricky Barrette
2023-12-30 22:53:08 -05:00
parent bf417c163c
commit 02b5fb4d0e
6 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/invoice_controller.rb
View File

@@ -21,10 +21,10 @@ class InvoiceController < ApplicationController
def show def show
begin begin
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| @pdf = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
invoice = service.fetch_by_id(params[:id]) invoice = service.fetch_by_id(params[:id])
@pdf = service.pdf(invoice) service.pdf(invoice)
end end
return unless @pdf return unless @pdf

16
app/models/customer.rb
View File

@@ -144,9 +144,9 @@ class Customer < ActiveRecord::Base
def self.sync def self.sync
# Sync ALL customers if the database is empty # Sync ALL customers if the database is empty
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| customers = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
customers = service.all service.all
end end
return unless customers return unless customers
@@ -178,9 +178,9 @@ class Customer < ActiveRecord::Base
# This needs to be simplified # This needs to be simplified
def self.sync_by_id(id) def self.sync_by_id(id)
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| customer = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
customer = service.fetch_by_id(id) service.fetch_by_id(id)
end end
return unless customer return unless customer
@@ -203,9 +203,9 @@ class Customer < ActiveRecord::Base
def save_with_push def save_with_push
begin begin
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| @details = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
@details = serivce.update(@details) serivce.update(@details)
end end
#raise "QBO Fault" if @details.fault? #raise "QBO Fault" if @details.fault?
self.id = @details.id self.id = @details.id
@@ -225,9 +225,9 @@ class Customer < ActiveRecord::Base
begin begin
raise Exception unless self.id raise Exception unless self.id
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| @details = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Customer.new(:company_id => qbo.realm_id, :access_token => access_token)
@details = bservice.ase.fetch_by_id(self.id) bservice.ase.fetch_by_id(self.id)
end end
rescue Exception => e rescue Exception => e
@details = Quickbooks::Model::Customer.new @details = Quickbooks::Model::Customer.new

8
app/models/employee.rb
View File

@@ -15,9 +15,9 @@ class Employee < ActiveRecord::Base
def self.sync def self.sync
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| employees = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Employee.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Employee.new(:company_id => qbo.realm_id, :access_token => access_token)
employees = service.all service.all
end end
return unless employees return unless employees
@@ -36,9 +36,9 @@ class Employee < ActiveRecord::Base
def self.sync_by_id(id) def self.sync_by_id(id)
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| employee = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Employee.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Employee.new(:company_id => qbo.realm_id, :access_token => access_token)
employee = service.fetch_by_id(id) service.fetch_by_id(id)
end end
return unless employee return unless employee

10
app/models/estimate.rb
View File

@@ -20,9 +20,9 @@ class Estimate < ActiveRecord::Base
def self.sync def self.sync
logger.debug "Syncing ALL estimates" logger.debug "Syncing ALL estimates"
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| estimates = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
estimates = service.all service.all
end end
return unless estimates return unless estimates
@@ -79,7 +79,7 @@ class Estimate < ActiveRecord::Base
qbo.perform_authenticated_request do |access_token| qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
estimate = service.fetch_by_id(id) estimate = service.fetch_by_id(id)
return service.pdf(estimate) service.pdf(estimate)
end end
end end
@@ -108,9 +108,9 @@ class Estimate < ActiveRecord::Base
begin begin
raise Exception unless self.id raise Exception unless self.id
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| @details = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Estimate.new(:company_id => qbo.realm_id, :access_token => access_token)
@details = service(:estimate).fetch_by_id(self.id) service(:estimate).fetch_by_id(self.id)
end end
rescue Exception => e rescue Exception => e
@details = Quickbooks::Model::Estimate.new @details = Quickbooks::Model::Estimate.new

12
app/models/invoice.rb
View File

@@ -26,13 +26,9 @@ class Invoice < ActiveRecord::Base
# TODO actually do something with the above query # TODO actually do something with the above query
# .all() is never called since count is never initialized # .all() is never called since count is never initialized
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| invoices = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
if count == 0 service.all
invoices = service.all
else
invoices = service.query()
end
end end
return unless invoices return unless invoices
@@ -197,9 +193,9 @@ class Invoice < ActiveRecord::Base
begin begin
raise Exception unless self.id raise Exception unless self.id
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| @details = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
@details = service.fetch_by_id(self.id) service.fetch_by_id(self.id)
end end
rescue Exception => e rescue Exception => e
@details = Quickbooks::Model::Invoice.new @details = Quickbooks::Model::Invoice.new

4
db/migrate/032_add_txn_dates.rb
View File

@@ -27,9 +27,9 @@ class AddTxnDates < ActiveRecord::Migration[5.1]
say "Sync Invoices" say "Sync Invoices"
qbo = Qbo.first qbo = Qbo.first
qbo.perform_authenticated_request do |access_token| invoices = qbo.perform_authenticated_request do |access_token|
service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token) service = Quickbooks::Service::Invoice.new(:company_id => qbo.realm_id, :access_token => access_token)
invoices = service.all service.all
end end
return unless invoices return unless invoices